Paths

Table of Contentst

Differential D28702

Rename rfc6675_pipe to sack.revised, and enable by default
ClosedPublic
Actions

Authored by rscheff on Feb 16 2021, 1:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jan 27, 11:00 AM

	Unknown Object (File)
	Sun, Jan 26, 6:19 PM

	Unknown Object (File)
	Mon, Jan 13, 9:05 PM

	Unknown Object (File)
	Sun, Jan 12, 5:34 PM

	Unknown Object (File)
	Sun, Jan 12, 5:34 PM

	Unknown Object (File)
	Sun, Jan 12, 5:34 PM

	Unknown Object (File)
	Sun, Jan 12, 5:33 PM

	Unknown Object (File)
	Sun, Jan 12, 5:33 PM

Subscribers

zarychtam_plan-b.pwste.edu.pl

Details

Reviewers

tuexen
rgrimes
jtl
thj
bcr
kbowling
rrs

Group Reviewers

transport
manpages

Commits

rGd1de2b05a001: tcp: Rename rfc6675_pipe to sack.revised, and enable by default

Summary

All missing pieces to claim full RFC6675 support are in place,
but disabled by default. These algorithms are all fenced
behind the preexisting sysctl "rfc6675_pipe" (disabled by default).

It was noted earlier, that referencing RFCs directly in sysctls is
not the optimal choice.

To better reflect these mechanisms belonging with SACK loss
recovery, shuffling the sysctl into the net.inet.tcp.sack branch,
and rename it to "revised".

Further, to get some additional testing coverage, enabling by default
in HEAD, by mid-march.

Unless this change (or the change of defaults) has to be backed out,
planning for an MFC to stable/13 mid-april.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Feb 16 2021, 1:16 PM

Herald added a reviewer: manpages. · View Herald TranscriptFeb 16 2021, 1:16 PM

Herald added 1 blocking reviewer(s): transport. · View Herald Transcript

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Feb 16 2021, 1:16 PM

Harbormaster completed remote builds in B37050: Diff 84004.Feb 16 2021, 1:17 PM

Any chance to have a more specific name than newsack?

Certainly, I'm definitely open to suggestions. functional descriptions would be a mouthful, as 6675 has pipe, faster_lossrecovery, and rescue_rexmit.

rfc6675 was adopted in 2012... "sack2012"? Only "improved"? retain "rfc6675"? "lessrto"?

change pretty name of sysctl to 'revised'
rebase to include PRR pipe calculation

Harbormaster completed remote builds in B37227: Diff 84351.Feb 20 2021, 7:53 PM

rscheff retitled this revision from Rename rfc6675_pipe to sack.newsack, and enable by default to Rename rfc6675_pipe to sack.revised, and enable by default.Feb 20 2021, 7:53 PM

rscheff edited the summary of this revision. (Show Details)

Thanks for doing this!

This revision is now accepted and ready to land.Feb 21 2021, 12:00 AM

kbowling requested changes to this revision.Feb 23 2021, 5:32 PM

kbowling added inline comments.

sys/netinet/tcp_input.c
2610	This hunk fails too
sys/netinet/tcp_sack.c
835	This hunk rejected by patch, tcp_sack_partialack doesn't look like this in head

This revision now requires changes to proceed.Feb 23 2021, 5:32 PM

kbowling accepted this revision.Feb 23 2021, 8:56 PM

This revision is now accepted and ready to land.Feb 23 2021, 8:56 PM

changing vnet 6675_pipe to newsack
rename and shuffle rfc6675_pipe to sack.newsack
onboard the cc modules to the change
rebase to HEAD

This revision now requires review to proceed.Feb 25 2021, 7:22 PM

Harbormaster completed remote builds in B37379: Diff 84705.Feb 25 2021, 7:22 PM

zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.Mar 23 2021, 11:43 AM

rebase to HEAD
make old OID read-only with a warning message

Harbormaster completed remote builds in B38136: Diff 86431.Mar 28 2021, 11:58 AM

rrs accepted this revision.Apr 8 2021, 2:09 PM

This revision is now accepted and ready to land.Apr 8 2021, 2:09 PM

transport call: Just remove old sysctl, add pointer in man page

remove sysctlproc with hint, only mention change in man page

This revision now requires review to proceed.Apr 17 2021, 12:39 PM

Harbormaster completed remote builds in B38643: Diff 87611.Apr 17 2021, 12:40 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2021, 1:51 PM

Closed by commit rGd1de2b05a001: tcp: Rename rfc6675_pipe to sack.revised, and enable by default (authored by rscheff). · Explain Why

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rGd1de2b05a001: tcp: Rename rfc6675_pipe to sack.revised, and enable by default.

rscheff mentioned this in D43520: tcp: move cc_post_recovery past snd_una update.Jan 20 2024, 12:59 AM

rscheff mentioned this in rG0b3f9e435f2b: tcp: move cc_post_recovery past snd_una update.Jan 29 2024, 8:25 AM

rscheff mentioned this in rG9bc48382a5e8: tcp: move cc_post_recovery past snd_una update.Feb 5 2024, 11:42 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

25 lines

sys/

netinet/

cc/

2 lines

2 lines

2 lines

11 lines

12 lines

4 lines

Diff 87613

share/man/man4/tcp.4

Loading...

sys/netinet/cc/cc_cubic.c

Loading...

sys/netinet/cc/cc_htcp.c

Loading...

sys/netinet/cc/cc_newreno.c

Loading...

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_sack.c

Loading...

sys/netinet/tcp_var.h

Loading...