Page MenuHomeFreeBSD
Differential D27601

Rename NO_WERROR -> MK_WERROR=no
ClosedPublic
Actions

Authored by arichardson on Dec 13 2020, 6:49 PM.
Tags
None
Referenced Files
F157038032: D27601.id81797.diff
Mon, May 18, 2:02 AM
F157037929: D27601.id80668.diff
Mon, May 18, 2:02 AM
F157037922: D27601.id81759.diff
Mon, May 18, 2:02 AM
F157037916: D27601.id81797.diff
Mon, May 18, 2:02 AM
F157037911: D27601.id80667.diff
Mon, May 18, 2:02 AM
F157036673: D27601.diff
Mon, May 18, 1:54 AM
Unknown Object (File)
Sun, May 10, 5:11 AM
Unknown Object (File)
Sun, May 10, 5:07 AM
View All Files
Subscribers
bdrewery

Details

Reviewers
imp
emaste
brooks
bdrewery
Group Reviewers
manpages
Commits
rG7fa2f2a62f04: Rename NO_WERROR -> MK_WERROR=no
Summary

As suggested in D27598. This also supports MK_WERROR.clang=no and
MK_WERROR.gcc=no to support the existing NO_WERROR.<compiler> uses.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Dec 13 2020, 6:49 PM
arichardson held this revision as a draft.
Herald added a reviewer: manpages. · View Herald TranscriptDec 13 2020, 6:49 PM
Herald added a subscriber: bdrewery. · View Herald Transcript
Harbormaster completed remote builds in B35385: Diff 80667.Dec 13 2020, 6:49 PM
arichardson added a parent revision: D27598: Stop passing MK_WARNS=no for bootstrap tools.Dec 13 2020, 6:51 PM
arichardson added a reviewer: bdrewery.
arichardson updated this revision to Diff 80668.Dec 13 2020, 7:01 PM
  • update src.conf
Harbormaster completed remote builds in B35386: Diff 80668.Dec 13 2020, 7:01 PM
arichardson published this revision for review.Dec 13 2020, 7:05 PM

Seems to work fine when building amd64 world, but I haven't tried GCC yet.

brooks accepted this revision.Dec 14 2020, 7:08 PM

MK_WERROR.clang=no is a bit weird, but it's not going to fit easily no matter what so using an odd spelling is probably for the best.

This revision is now accepted and ready to land.Dec 14 2020, 7:08 PM
arichardson mentioned this in D27599: Fix all warnings emitted in `make kernel-toolchain`.Jan 6 2021, 10:03 AM
arichardson updated this revision to Diff 81759.Jan 6 2021, 5:54 PM

rebase after latest commits

This revision now requires review to proceed.Jan 6 2021, 5:54 PM
Harbormaster completed remote builds in B35973: Diff 81759.Jan 6 2021, 5:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2021, 11:09 AM
Closed by commit rG7fa2f2a62f04: Rename NO_WERROR -> MK_WERROR=no (authored by arichardson). · Explain Why
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG7fa2f2a62f04: Rename NO_WERROR -> MK_WERROR=no.

Revision Contents
Changeset List

PathSize
2 lines
10 lines
2 lines
lib/
googletest/
tests/
gmock/
2 lines
gmock_main/
2 lines
gtest/
2 lines
gtest_main/
2 lines
libalias/
libalias/
2 lines
libc/
tests/
ssp/
2 lines
libcompiler_rt/
2 lines
libgcc_s/
2 lines
share/
man/
man5/
2 lines
man7/
2 lines
mk/
2 lines
4 lines
6 lines
4 lines
2 lines
8 lines
targets/
pseudo/
bootstrap-tools/
2 lines
tools/
build/
options/
4 lines
usr.bin/
drill/
2 lines
kdump/
2 lines
truss/
1 line
usr.sbin/
unbound/
2 lines

Diff 81797

View Options

Makefile

Loading...
View Options

Makefile.inc1

Loading...
View Options

Makefile.libcompat

Loading...
View Options

lib/googletest/tests/gmock/Makefile

Loading...
View Options

lib/googletest/tests/gmock_main/Makefile

Loading...
View Options

lib/googletest/tests/gtest/Makefile

Loading...
View Options

lib/googletest/tests/gtest_main/Makefile

Loading...
View Options

lib/libalias/libalias/Makefile

Loading...
View Options

lib/libc/tests/ssp/Makefile

Loading...
View Options

lib/libcompiler_rt/Makefile

Loading...
View Options

lib/libgcc_s/Makefile

Loading...
View Options

share/man/man5/style.Makefile.5

Loading...
View Options

share/man/man7/build.7

Loading...
View Options

share/mk/bsd.README

Loading...
View Options

share/mk/bsd.lib.mk

Loading...
View Options

share/mk/bsd.opts.mk

Loading...
View Options

share/mk/bsd.prog.mk

Loading...
View Options

share/mk/bsd.progs.mk

Loading...
View Options

share/mk/bsd.sys.mk

Loading...
View Options

targets/pseudo/bootstrap-tools/Makefile

Loading...
View Options

tools/build/options/WITHOUT_WERROR

Loading...
View Options

usr.bin/drill/Makefile

Loading...
View Options

usr.bin/kdump/Makefile

Loading...
View Options

usr.bin/truss/Makefile

Loading...
View Options

usr.sbin/unbound/Makefile.inc

Loading...