Page MenuHomeFreeBSD

Stop passing MK_WARNS=no for bootstrap tools
ClosedPublic

Authored by arichardson on Dec 13 2020, 5:12 PM.

Details

Summary

I got annoyed by the number of warnings that the CheriBSD build was
emitting. It turns out that we are emitting lots of warnings during
bootstrap because bootstrap tools are built with the default compiler
flags and ignore the warnings flags that are set in bsd.sys.mk.

Looking at git blame, it appears that MK_WARNS=no has been passed since
rS112869, replacing the -DNO_WERROR option that was added in rS87775.

This commit changes MK_WARNS=no back to -DNO_WERROR. We need to pass
-DNO_WERROR, since the system compiler might have new warnings that we
don't know about yet, and we shouldn't fail the build in that case.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

In an ideal world, we'd have MK_WERROR={yes,no} and this would be WITHOUT_WERROR for users or MK_WERROR=no internally.
But this is better enough I'm clicking approve, though if you wanted to do this idea I'd be happier.

This revision is now accepted and ready to land.Dec 13 2020, 6:31 PM
In D27598#616727, @imp wrote:

In an ideal world, we'd have MK_WERROR={yes,no} and this would be WITHOUT_WERROR for users or MK_WERROR=no internally.
But this is better enough I'm clicking approve, though if you wanted to do this idea I'd be happier.

Will open a follow-up revision. There are a few more places that need a NO_WERROR -> MK_WERROR=no change and I'd rather do that in a separate commit.