Page MenuHomeFreeBSD
Projects pkgbase

pkgbaseProject
ActivePublic
Watch Project

Members (6)

Watchers (6)

Details

Description

For reviews on pkgbase

Recent Activity
View All

Nov 24 2023

dfr added a comment to D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
In D41873#975105, @dfr wrote:
In D41873#975104, @manu wrote:
In D41873#975103, @dfr wrote:
In D41873#975075, @manu wrote:

I think that the question is should we have a FreeBSD-sh package or not.

I really like the idea of a FreeBSD-sh package - it covers what I'm trying to achieve here and avoids breaking up the carefully curated set of libs in runtime. We would have to be careful about upgrades to try to avoid leaving systems without /bin/sh.

There is always FreeBSD-rescue in case sh fails to upgrade

Good point. I will abandon this review and make one to add FreeBSD-sh.

Nov 24 2023, 11:30 AM · pkgbase
dfr abandoned D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
Nov 24 2023, 10:34 AM · pkgbase
dfr added a comment to D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
In D41873#975104, @manu wrote:
In D41873#975103, @dfr wrote:
In D41873#975075, @manu wrote:

I think that the question is should we have a FreeBSD-sh package or not.

I really like the idea of a FreeBSD-sh package - it covers what I'm trying to achieve here and avoids breaking up the carefully curated set of libs in runtime. We would have to be careful about upgrades to try to avoid leaving systems without /bin/sh.

There is always FreeBSD-rescue in case sh fails to upgrade

Nov 24 2023, 10:33 AM · pkgbase
manu added a comment to D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
In D41873#975103, @dfr wrote:
In D41873#975075, @manu wrote:

I think that the question is should we have a FreeBSD-sh package or not.

I really like the idea of a FreeBSD-sh package - it covers what I'm trying to achieve here and avoids breaking up the carefully curated set of libs in runtime. We would have to be careful about upgrades to try to avoid leaving systems without /bin/sh.

Nov 24 2023, 10:25 AM · pkgbase
dfr added a comment to D41873: pkgbase: Move libz and libcrypt from runtime to clibs.
In D41873#975075, @manu wrote:

I think that the question is should we have a FreeBSD-sh package or not.

Nov 24 2023, 10:21 AM · pkgbase
manu added a comment to D41873: pkgbase: Move libz and libcrypt from runtime to clibs.

I'm not against *this* specifically, it will be nice to be able to have a shell-free nginx without FreeBSD-runtime but if we start doing this I think that we will end up moving all the libs in clibs.
I mean, it works with nginx but what about other programs ? Some that needs casper libs for example or gssapi ? Those are still in FreeBSD-runtime. Right now FreeBSD-runtime is only 8MiB so that's not that big.
I think that the question is should we have a FreeBSD-sh package or not.

Nov 24 2023, 9:26 AM · pkgbase

Nov 14 2023

freebsd_igalic.co added a reviewer for D41873: pkgbase: Move libz and libcrypt from runtime to clibs: pkgbase.
Nov 14 2023, 1:46 PM · pkgbase

Sep 14 2023

dfr closed D41861: pkgbase: Split out manpages by default.
Sep 14 2023, 3:51 PM · pkgbase
bapt accepted D41861: pkgbase: Split out manpages by default.
Sep 14 2023, 3:36 PM · pkgbase
dfr updated the diff for D41861: pkgbase: Split out manpages by default.

Document the change to MANSPLITPKG

Sep 14 2023, 2:54 PM · pkgbase
freebsd_igalic.co added a reviewer for D41861: pkgbase: Split out manpages by default: pkgbase.
Sep 14 2023, 2:53 PM · pkgbase

Jul 16 2023

grahamperrin added a watcher for pkgbase: grahamperrin.
Jul 16 2023, 5:25 PM

Mar 15 2023

imp closed D27962: rc: ignore .pkgsave files.
Mar 15 2023, 3:08 AM · pkgbase, rc
imp added a comment to D27962: rc: ignore .pkgsave files.

So where is this review? It seems to have wound down a bit.

Mar 15 2023, 2:54 AM · pkgbase, rc

Feb 20 2023

freebsd_igalic.co added a comment to D27962: rc: ignore .pkgsave files.

I'll be updating this review and try to revive it.

Feb 20 2023, 9:52 AM · pkgbase, rc

Nov 8 2021

freebsd_oprs.eu added a watcher for pkgbase: freebsd_oprs.eu.
Nov 8 2021, 4:45 AM

Apr 20 2021

ehem_freebsd_m5p.com added a comment to D29224: make only vital packages vital, not their sub-packages.

I'm unsure which commit did it, but at a point near this commit the time taken by release builds drastically decreased. Before this close to 20 hours for an aarch64 cross-build, just over 6 after. Even though I can leave my build machine running, the decrease in latency is very nice. Thank you.

Apr 20 2021, 12:54 AM · pkgbase

Mar 28 2021

manu closed D29224: make only vital packages vital, not their sub-packages.
Mar 28 2021, 10:19 AM · pkgbase

Mar 18 2021

freebsd_igalic.co updated the diff for D29224: make only vital packages vital, not their sub-packages.

rebase

Mar 18 2021, 8:21 PM · pkgbase
manu added a comment to D29224: make only vital packages vital, not their sub-packages.

Looks ok,
Can you rebase your patch against latest main ?
Thanks.

Mar 18 2021, 9:34 AM · pkgbase

Mar 12 2021

freebsd_igalic.co updated the summary of D29224: make only vital packages vital, not their sub-packages.
Mar 12 2021, 12:27 PM · pkgbase
freebsd_igalic.co retitled D29224: make only vital packages vital, not their sub-packages from make jail, runtimes & utilities sub-packages non-vital to make only vital packages vital, not their sub-packages.
Mar 12 2021, 11:59 AM · pkgbase
freebsd_igalic.co added a comment to D29224: make only vital packages vital, not their sub-packages.

addressed in latest update

Mar 12 2021, 11:58 AM · pkgbase
freebsd_igalic.co updated the diff for D29224: make only vital packages vital, not their sub-packages.

address @manu's review

Mar 12 2021, 11:57 AM · pkgbase

Mar 11 2021

freebsd_igalic.co added inline comments to D29224: make only vital packages vital, not their sub-packages.
Mar 11 2021, 10:30 PM · pkgbase
manu added inline comments to D29224: make only vital packages vital, not their sub-packages.
Mar 11 2021, 9:30 PM · pkgbase
manu added a comment to D29224: make only vital packages vital, not their sub-packages.

I don't think that the jail package should be vital.
Otherwise that looks good.

Mar 11 2021, 9:28 PM · pkgbase
freebsd_igalic.co added a reviewer for D29224: make only vital packages vital, not their sub-packages: pkgbase.
Mar 11 2021, 8:35 PM · pkgbase

Jan 30 2021

freebsd_igalic.co updated the diff for D27962: rc: ignore .pkgsave files.
Jan 30 2021, 8:40 PM · pkgbase, rc

Jan 21 2021

kevans updated subscribers of D27962: rc: ignore .pkgsave files.
Jan 21 2021, 9:40 PM · pkgbase, rc
kevans added a reviewer for D27962: rc: ignore .pkgsave files: kevans.
Jan 21 2021, 9:40 PM · pkgbase, rc
freebsd_igalic.co updated the summary of D27962: rc: ignore .pkgsave files.
Jan 21 2021, 2:26 PM · pkgbase, rc

Jan 14 2021

manu added a reverting change for D20734: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases (part 2): rG03cab14ea3a8: Revert "pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC….
Jan 14 2021, 1:18 PM · pkgbase
manu added a comment to D20734: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases (part 2).

Push with a rebase and a few modif (PRERELEASE didn't worked).

Jan 14 2021, 1:01 PM · pkgbase
manu closed D20734: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases (part 2).
Jan 14 2021, 1:00 PM · pkgbase

Jan 8 2021

freebsd_igalic.co added a comment to D27962: rc: ignore .pkgsave files.

addressed @swills' concerns.

Jan 8 2021, 8:36 PM · pkgbase, rc
freebsd_igalic.co updated the diff for D27962: rc: ignore .pkgsave files.
Jan 8 2021, 8:35 PM · pkgbase, rc
freebsd_igalic.co added a watcher for pkgbase: freebsd_igalic.co.
Jan 8 2021, 7:56 PM
freebsd_igalic.co added a member for pkgbase: freebsd_igalic.co.
Jan 8 2021, 7:54 PM
swills added inline comments to D27962: rc: ignore .pkgsave files.
Jan 8 2021, 3:05 PM · pkgbase, rc
freebsd_igalic.co added inline comments to D27962: rc: ignore .pkgsave files.
Jan 8 2021, 2:57 PM · pkgbase, rc
emaste added a comment to D27962: rc: ignore .pkgsave files.

I suggested this kind of approach in D27959 for kldxref; I think it's reasonable in that case, although perhaps we could indeed end up with something like if_em.test.ko

Jan 8 2021, 2:52 PM · pkgbase, rc
swills added inline comments to D27962: rc: ignore .pkgsave files.
Jan 8 2021, 2:35 PM · pkgbase, rc

Jan 4 2021

freebsd_igalic.co requested review of D27962: rc: ignore .pkgsave files.
Jan 4 2021, 9:48 PM · pkgbase, rc
manu closed D27690: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY.
Jan 4 2021, 3:26 PM · manpages, pkgbase
bapt accepted D27690: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY.
Jan 4 2021, 1:26 PM · manpages, pkgbase

Dec 31 2020

emaste added a member for pkgbase: emaste.
Dec 31 2020, 3:01 PM

Dec 24 2020

freebsd_igalic.co added a reviewer for D27690: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY: pkgbase.
Dec 24 2020, 12:17 PM · manpages, pkgbase

Dec 21 2020

bcr accepted D27690: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY.

OK from manpages.

Dec 21 2020, 8:34 AM · manpages, pkgbase

Dec 20 2020

freebsd_igalic.co added a comment to D27690: rename PKGSIGNKEY to PKG_REPO_SIGNING_KEY.

address @yuripv's comments.

Dec 20 2020, 8:19 PM · manpages, pkgbase