Page MenuHomeFreeBSD

freebsd_oprs.eu (Olivier Piras)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 3 2020, 9:55 PM (12 w, 2 d)

Recent Activity

Oct 20 2020

freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

Ah, I should have anticipated that. It's done, thank you.

Oct 20 2020, 7:12 PM · network
freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

This revision implements the test plan above as a proper set of ATF(7)/KYUA(1) test cases.
It also addresses the small nit in if_vlan.c (lowercase "802.1q" for consistency).

Oct 20 2020, 5:21 PM · network

Oct 19 2020

freebsd_oprs.eu added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

That's great news, thanks ! I'm currently catching up on Kyua & the ATF; I'll push some tests today.

Oct 19 2020, 10:08 AM · network

Oct 4 2020

freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

I'll just slip in a small cosmetic update while I still can (MT_LAMBDA becomes MT_FILTER).

Oct 4 2020, 2:38 PM · network

Sep 28 2020

freebsd_oprs.eu added inline comments to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..
Sep 28 2020, 7:56 AM · network
freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

This updated revision implements the alternative solution discussed earlier. I've updated the test plan to account for the new parameter-based syntax, so I will not dwell on that here, but in a nutshell:

ifconfig svlan5 create vlandev em0 vlan 5 up
ifconfig vlan42 create vlandev svlan5 vlan 42 inet 10.5.42.1/24

becomes

ifconfig vlan5 create vlandev em0 vlan 5 vlanproto 802.1ad up
ifconfig vlan42 create vlandev vlan5 vlan 42 inet 10.5.42.1/24

Dot notation is supported, as long as everyone agrees that any interface with a dot in its name is a VLAN.

Sep 28 2020, 7:38 AM · network
freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

This is mostly a cosmetic update. It fixes the small issues (typos, etc...) raised in the previous revision. The idea is to have a clean base to compare the (upcoming) alternative implementation to.

Sep 28 2020, 7:20 AM · network

Sep 20 2020

freebsd_oprs.eu added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

Re "vlan"/"svlan" naming - I don't have extremely strong opinion on this, but it would be nice if we could still consider using the same name for both. "Svlan" looks a bit like low-level implementation detail somehow leaked to the upper layers.

For example, it can be implemented in the following fashion:
ifconfig vlan5 create vlan 5 vlandev em0 vlanproto 802.1ad <-- svlan
ifconfig vlan5.25 create vlan 5 vlandev vlan5 <-- 8021.q on top of 802.1ad
ifconfig em0.5 create vlanproto 802.1ad <-- svlan

Do you think it would be more confusing for users?

Sep 20 2020, 6:18 PM · network

Sep 18 2020

freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

This updated revision improves support for dot notation.

Sep 18 2020, 4:57 PM · network

Sep 17 2020

freebsd_oprs.eu added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

Hmm.. parsing VLAN interface names is currently left to the kernel. It sounds like something ifconfig should handle instead, especially when non-trivial dot notation is involved (ie. ifconfig em0.x.y.z).
I mean, look at vlan_clone_create(), the first half of it is just about normalizing user input.

Sep 17 2020, 4:11 PM · network
freebsd_oprs.eu added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

@rscheff I completely agree with your points. I probably should have given this more thought to begin with.
I will amend the patch accordingly later today.

Sep 17 2020, 10:53 AM · network

Sep 16 2020

freebsd_oprs.eu added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

Hi, thanks for considering this patch.

Sep 16 2020, 11:48 PM · network
freebsd_oprs.eu added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

My mistake for not linting the man pages before submitting this revision.
Thanks for the heads-up !

Sep 16 2020, 12:01 PM · network
freebsd_oprs.eu updated the diff for D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..
  • Fix broken ifconfig.8 syntax.
  • Add svlan.4 and if_svlan.4 as symlinks to vlan.4.
  • Slight update to the revision title.
Sep 16 2020, 11:57 AM · network

Sep 15 2020

freebsd_oprs.eu added a comment to D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..

There should be eventually. However, unless the general consensus is that
this should be an absolute requirement, it is not on the top of my priority
list at this time (there are other things I'd like to go through first,
such as proper support for 802.1ad hardware tagging).

Sep 15 2020, 4:59 PM · network
freebsd_oprs.eu requested review of D26436: Add support for stacked VLANs (IEEE 802.1ad, AKA Q-in-Q)..
Sep 15 2020, 1:39 PM · network