For reviews on pkgbase
Details
Details
Description
Mon, Oct 13
Mon, Oct 13
yup, thanks for the bump.
ivy added a comment to D51275: Makefile.inc1: in _pkgbootstrap, use freshly built pkg, not host version.
i think we agreed this change is wrong, can we close the review?
Tue, Sep 30
Tue, Sep 30
Sep 25 2025
Sep 25 2025
ifreund_freebsdfoundation.org updated the diff for D51483: release: create pkgbase VM and cloud images.
Fix documentation of NOPKGBASE (this got inverted by the rebase)
ifreund_freebsdfoundation.org added inline comments to D51483: release: create pkgbase VM and cloud images.
emaste added inline comments to D51483: release: create pkgbase VM and cloud images.
emaste added inline comments to D51483: release: create pkgbase VM and cloud images.
emaste added inline comments to D51483: release: create pkgbase VM and cloud images.
ziaee updated the diff for D50289: build.7: Improve building pkgbase.
"building src into packages" > "building packages(7)"
ziaee updated the summary of D50289: build.7: Improve building pkgbase.
ifreund_freebsdfoundation.org updated the diff for D51516: release: add FreeBSD-base.conf to pkgbase VM/cloud images.
Rebase, resolving conflict from change to -DNOPKGBASE
ifreund_freebsdfoundation.org retitled D51483: release: create pkgbase VM and cloud images from release: support -DPKGBASE for VM and cloud images to release: create pkgbase VM and cloud images.
ifreund_freebsdfoundation.org updated the diff for D51483: release: create pkgbase VM and cloud images.
rebase, resolve conflicts with change to -DNOPKGBASE
ifreund_freebsdfoundation.org updated the diff for D51482: release: create pkgbase repo config from Makefile.
Fix bad rebase
ifreund_freebsdfoundation.org requested changes to D51482: release: create pkgbase repo config from Makefile.
emaste updated the diff for D51482: release: create pkgbase repo config from Makefile.
rebase
ivy accepted D50289: build.7: Improve building pkgbase.
aside from one or two stray instances of .Cm packages this looks good.
ziaee updated the diff for D50289: build.7: Improve building pkgbase.
use kevan's suggestion for update-packages
kevans added inline comments to D50289: build.7: Improve building pkgbase.
ziaee added inline comments to D50289: build.7: Improve building pkgbase.
ziaee updated the diff for D50289: build.7: Improve building pkgbase.
fix a straggler
ziaee updated the diff for D50289: build.7: Improve building pkgbase.
pkg(7) targets -> packages(7), apply ivy's suggestions elsewhere
ivy requested changes to D50289: build.7: Improve building pkgbase.
Sep 24 2025
Sep 24 2025
ziaee updated the diff for D50289: build.7: Improve building pkgbase.
fix incorrect backslash
ziaee updated the diff for D50289: build.7: Improve building pkgbase.
attmpt to fix objroot but honestly I don't really understand what I'm reading here.
ziaee updated the diff for D50289: build.7: Improve building pkgbase.
rebase
ifreund_freebsdfoundation.org added inline comments to D51483: release: create pkgbase VM and cloud images.
ifreund_freebsdfoundation.org added a comment to D51483: release: create pkgbase VM and cloud images.
I think this patch could use a bit more work than just updating for the -DNOPKGBASE change. It was written before package sets were added and it would be nice if we could leverage those rather than doing fragile regex-based matching.
ifreund_freebsdfoundation.org added a comment to D51483: release: create pkgbase VM and cloud images.
Sep 23 2025
Sep 23 2025
cperciva added a comment to D51483: release: create pkgbase VM and cloud images.
Actually, this is going to need some changes now that PKGBASE is the default and there's a new NOPKGBASE option. Should I just take over this patch?
cperciva added a comment to D51483: release: create pkgbase VM and cloud images.
@ifreund_freebsdfoundation.org Can we land this soon?
Aug 29 2025
Aug 29 2025
emaste added inline comments to D51482: release: create pkgbase repo config from Makefile.
ifreund_freebsdfoundation.org added inline comments to D51482: release: create pkgbase repo config from Makefile.
ifreund_freebsdfoundation.org updated the diff for D51482: release: create pkgbase repo config from Makefile.
Don't hardcode "worldstage"
ifreund_freebsdfoundation.org added inline comments to D51483: release: create pkgbase VM and cloud images.
emaste added inline comments to D51482: release: create pkgbase repo config from Makefile.
ifreund_freebsdfoundation.org added inline comments to D51482: release: create pkgbase repo config from Makefile.
des added inline comments to D50289: build.7: Improve building pkgbase.
Aug 28 2025
Aug 28 2025
ziaee updated the diff for D50289: build.7: Improve building pkgbase.
oops, forgot to switch it on line 729
ziaee updated the diff for D50289: build.7: Improve building pkgbase.
+ Add an entry for OBJROOT
emaste added inline comments to D51483: release: create pkgbase VM and cloud images.
emaste added a comment to D51482: release: create pkgbase repo config from Makefile.
Looks good but I'd like to avoid having the literal worldstage in two different places if we can