For reviews on pkgbase
Details
May 28 2024
May 27 2024
Nov 24 2023
I'm not against *this* specifically, it will be nice to be able to have a shell-free nginx without FreeBSD-runtime but if we start doing this I think that we will end up moving all the libs in clibs.
I mean, it works with nginx but what about other programs ? Some that needs casper libs for example or gssapi ? Those are still in FreeBSD-runtime. Right now FreeBSD-runtime is only 8MiB so that's not that big.
I think that the question is should we have a FreeBSD-sh package or not.
Nov 14 2023
Sep 14 2023
Document the change to MANSPLITPKG
Jul 16 2023
Mar 15 2023
So where is this review? It seems to have wound down a bit.
Feb 20 2023
I'll be updating this review and try to revive it.
Nov 8 2021
Apr 20 2021
I'm unsure which commit did it, but at a point near this commit the time taken by release builds drastically decreased. Before this close to 20 hours for an aarch64 cross-build, just over 6 after. Even though I can leave my build machine running, the decrease in latency is very nice. Thank you.
Mar 28 2021
Mar 18 2021
rebase
Looks ok,
Can you rebase your patch against latest main ?
Thanks.
Mar 12 2021
addressed in latest update
address @manu's review
Mar 11 2021
I don't think that the jail package should be vital.
Otherwise that looks good.
Jan 30 2021
Jan 21 2021
Jan 14 2021
Push with a rebase and a few modif (PRERELEASE didn't worked).
Jan 8 2021
addressed @swills' concerns.
I suggested this kind of approach in D27959 for kldxref; I think it's reasonable in that case, although perhaps we could indeed end up with something like if_em.test.ko