x86Umbrella
ActivePublic
Watch Project

Members (6)

Watchers (2)

Recent Activity
View All

Aug 20 2024

emaste added a comment to D22642: Intel IOMMU DMAR suspend/resume support (only without QI for now).

Referenced in PR280817

Aug 20 2024, 6:21 PM · x86

Feb 22 2024

royger closed D43764: x86/xen: implement early init hook.

Feb 22 2024, 10:32 AM · x86

royger closed D43763: x86/cpu: introduce an optional hook for early.

Feb 22 2024, 10:32 AM · x86

Feb 19 2024

markj accepted D43764: x86/xen: implement early init hook.

Feb 19 2024, 2:12 PM · x86

Feb 16 2024

royger closed D43765: x86/xen: fix migration when ACPI suspend is not available.

Feb 16 2024, 1:17 PM · x86

royger updated the diff for D43764: x86/xen: implement early init hook.

Context adjustments due to modifications in previous patches

Feb 16 2024, 12:44 PM · x86

royger updated the diff for D43764: x86/xen: implement early init hook.

Fix comments.

Feb 16 2024, 12:04 PM · x86

royger updated the diff for D43765: x86/xen: fix migration when ACPI suspend is not available.

Add Xen guest assert.

Feb 16 2024, 11:57 AM · x86

royger added inline comments to D43765: x86/xen: fix migration when ACPI suspend is not available.

Feb 16 2024, 11:56 AM · x86

Feb 11 2024

royger added inline comments to D43764: x86/xen: implement early init hook.

Feb 11 2024, 3:54 PM · x86

markj added inline comments to D43764: x86/xen: implement early init hook.

Feb 11 2024, 3:35 PM · x86

Feb 7 2024

markj added inline comments to D43763: x86/cpu: introduce an optional hook for early.

Feb 7 2024, 2:18 PM · x86

kib added inline comments to D43763: x86/cpu: introduce an optional hook for early.

Feb 7 2024, 2:13 PM · x86

markj accepted D43765: x86/xen: fix migration when ACPI suspend is not available.

Feb 7 2024, 1:32 PM · x86

markj added inline comments to D43763: x86/cpu: introduce an optional hook for early.

Feb 7 2024, 1:27 PM · x86

Feb 6 2024

kib accepted D43763: x86/cpu: introduce an optional hook for early.

Feb 6 2024, 10:12 PM · x86

royger added inline comments to D43764: x86/xen: implement early init hook.

Feb 6 2024, 8:02 PM · x86

ehem_freebsd_m5p.com added a comment to D43764: x86/xen: implement early init hook.

Guess I had it easy as I had a system running Linux and arcanist was available as a package.

Feb 6 2024, 7:54 PM · x86

royger added inline comments to D43765: x86/xen: fix migration when ACPI suspend is not available.

Feb 6 2024, 5:22 PM · x86

royger updated the diff for D43765: x86/xen: fix migration when ACPI suspend is not available.

Add comment.

Feb 6 2024, 5:21 PM · x86

markj added inline comments to D43763: x86/cpu: introduce an optional hook for early.

Feb 6 2024, 5:06 PM · x86

royger added inline comments to D43763: x86/cpu: introduce an optional hook for early.

Feb 6 2024, 4:17 PM · x86

royger updated the diff for D43764: x86/xen: implement early init hook.

Upload diff with context.

Feb 6 2024, 4:16 PM · x86

markj accepted D43763: x86/cpu: introduce an optional hook for early.

Feb 6 2024, 4:16 PM · x86

royger added a comment to D43764: x86/xen: implement early init hook.

In D43764#998154, @markj wrote:

In D43764#998147, @royger wrote:

In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Hm, that's the output from git format-patch. I wonder why it doesn't pick the context automatically from the repo?

How are you uploading it? arc diff --create <revision> or git arc create will indeed fetch context automatically. If you're manually uploading diffs, then it won't. See https://wiki.freebsd.org/Phabricator#Create_a_Revision

Feb 6 2024, 4:16 PM · x86

royger updated the diff for D43763: x86/cpu: introduce an optional hook for early.

Fix possaible use of init_fn uninitialized.

Feb 6 2024, 4:13 PM · x86

markj added inline comments to D43763: x86/cpu: introduce an optional hook for early.

Feb 6 2024, 4:04 PM · x86

markj added a comment to D43764: x86/xen: implement early init hook.

In D43764#998147, @royger wrote:

In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Hm, that's the output from git format-patch. I wonder why it doesn't pick the context automatically from the repo?

Feb 6 2024, 4:01 PM · x86

royger added inline comments to D43763: x86/cpu: introduce an optional hook for early.

Feb 6 2024, 4:01 PM · x86

markj added inline comments to D43765: x86/xen: fix migration when ACPI suspend is not available.

Feb 6 2024, 3:59 PM · x86

royger added a comment to D43764: x86/xen: implement early init hook.

In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Feb 6 2024, 3:58 PM · x86

markj added a comment to D43764: x86/xen: implement early init hook.

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Feb 6 2024, 3:56 PM · x86

markj added inline comments to D43763: x86/cpu: introduce an optional hook for early.

Feb 6 2024, 3:54 PM · x86

royger requested review of D43765: x86/xen: fix migration when ACPI suspend is not available.

Feb 6 2024, 8:43 AM · x86

royger updated the summary of D43764: x86/xen: implement early init hook.

Feb 6 2024, 8:42 AM · x86

royger requested review of D43764: x86/xen: implement early init hook.

Feb 6 2024, 8:42 AM · x86

royger requested review of D43763: x86/cpu: introduce an optional hook for early.

Feb 6 2024, 8:39 AM · x86

Sep 23 2022

martin_bxlr.sk updated the diff for D34479: Add support for custom keyboard layout when GELI asks for a passphrase.

I've updated the code to follow the style as you mentioned.
I've removed too wide CFLAGS from libsa Makefile.

Sep 23 2022, 11:14 PM · x86

Sep 21 2022

martin_bxlr.sk added a comment to D34479: Add support for custom keyboard layout when GELI asks for a passphrase.

As this was my first patch here I need to get familiar with the interface and the way how I can submit the changes. I also need to refresh my memory what I did as I did this in March.

Sep 21 2022, 8:20 PM · x86

Sep 20 2022

tsoome added a comment to D34479: Add support for custom keyboard layout when GELI asks for a passphrase.

In D34479#831843, @imp wrote:

Some general comments...

The style of indented #if isn't what we do in FreeBSD. Code should be indented as if the #if isn't present, and the # directives should be in column 1.
We don't add extra spaces around the ('s, as I've highlighted
We don't do if (foo) bar; on one line.
logical operators are at the end of the line, not the start of the continuation.

It's an interesting notion... You'll likely want to do something similar to the EFI boot loader as well.

Sep 20 2022, 9:02 PM · x86

imp added a comment to D34479: Add support for custom keyboard layout when GELI asks for a passphrase.

Some general comments...

Sep 20 2022, 8:53 PM · x86

manu added a reviewer for D34479: Add support for custom keyboard layout when GELI asks for a passphrase: Loader.

Sep 20 2022, 5:17 PM · x86

Sep 1 2022

cy added a member for x86: cy.

Sep 1 2022, 4:55 PM

Mar 8 2022

martin_bxlr.sk updated the test plan for D34479: Add support for custom keyboard layout when GELI asks for a passphrase.

Mar 8 2022, 2:23 PM · x86

martin_bxlr.sk requested review of D34479: Add support for custom keyboard layout when GELI asks for a passphrase.

Mar 8 2022, 2:19 PM · x86

Jan 13 2022

vangyzen closed D33667: atrtc: reads Century field from FADT table.

Jan 13 2022, 11:24 PM · x86

vangyzen accepted D33667: atrtc: reads Century field from FADT table.

Jan 13 2022, 11:24 PM · x86

Jan 6 2022

akumar3_isilon.com accepted D33667: atrtc: reads Century field from FADT table.

Jan 6 2022, 11:07 AM · x86

austin.zhang_dell.com added a reviewer for D33667: atrtc: reads Century field from FADT table: akumar3_isilon.com.

Jan 6 2022, 7:51 AM · x86

Dec 28 2021

dab accepted D33667: atrtc: reads Century field from FADT table.

LGTM

Dec 28 2021, 7:12 PM · x86