I'd suggest some function renames, but otherwise looks fine. I might do some followup changes.

AMD64 , Raptor Lake+

what platform did you see this on?

For reference, here's bug report I posted some time ago which made me deep-dive into this problem. It seems, as reduced ACPI hardware laptops (with Power buttons served by GPIO pin) become more frequent, we will have to solve this GPIO interrupts issue either way.

Last time I checked, porting x86 to intrng did not look trivial, at least for me.
Maybe it would not be too hard for someone with more experience in both.

most of this is fine but the code that handles the non-intrng path seems .. a lot. I think I want this eyeballed by some other folks and see if there's scope to just push to get everything migrated to intrng already.

Ok, I may have overlooked that wrinkle on sx_xlocked(9).

Referenced in PR280817

Context adjustments due to modifications in previous patches

Fix comments.

Add Xen guest assert.

Guess I had it easy as I had a system running Linux and arcanist was available as a package.

Add comment.

Upload diff with context.

In D43764#998154, @markj wrote:

In D43764#998147, @royger wrote:

In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Hm, that's the output from git format-patch. I wonder why it doesn't pick the context automatically from the repo?

How are you uploading it? arc diff --create <revision> or git arc create will indeed fetch context automatically. If you're manually uploading diffs, then it won't. See https://wiki.freebsd.org/Phabricator#Create_a_Revision

Fix possaible use of init_fn uninitialized.

In D43764#998147, @royger wrote:

In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Hm, that's the output from git format-patch. I wonder why it doesn't pick the context automatically from the repo?

In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.