Context adjustments due to modifications in previous patches

Fix comments.

Add Xen guest assert.

Guess I had it easy as I had a system running Linux and arcanist was available as a package.

Add comment.

Upload diff with context.

In D43764#998154, @markj wrote:

In D43764#998147, @royger wrote:

In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Hm, that's the output from git format-patch. I wonder why it doesn't pick the context automatically from the repo?

How are you uploading it? arc diff --create <revision> or git arc create will indeed fetch context automatically. If you're manually uploading diffs, then it won't. See https://wiki.freebsd.org/Phabricator#Create_a_Revision

Fix possaible use of init_fn uninitialized.

In D43764#998147, @royger wrote:

In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Hm, that's the output from git format-patch. I wonder why it doesn't pick the context automatically from the repo?

In D43764#998144, @markj wrote:

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

Could you please upload diffs with context? i.e., add -U99999 or so to diff's parameters.

• I've updated the code to follow the style as you mentioned.
• I've removed too wide CFLAGS from libsa Makefile.

As this was my first patch here I need to get familiar with the interface and the way how I can submit the changes. I also need to refresh my memory what I did as I did this in March.

In D34479#831843, @imp wrote:

Some general comments...

The style of indented #if isn't what we do in FreeBSD. Code should be indented as if the #if isn't present, and the # directives should be in column 1.
We don't add extra spaces around the ('s, as I've highlighted
We don't do if (foo) bar; on one line.
logical operators are at the end of the line, not the start of the continuation.

It's an interesting notion... You'll likely want to do something similar to the EFI boot loader as well.

Some general comments...

LGTM