Meant to add:

• use the correct pci_get_subdevice macro

• Fix nits

In D49759#1134392, @bz wrote:

PCI accessors are all there @adrian pci_get_(first column)

PCI_ACCESSOR(subvendor,         SUBVENDOR,      uint16_t)
PCI_ACCESSOR(subdevice,         SUBDEVICE,      uint16_t)
PCI_ACCESSOR(vendor,            VENDOR,         uint16_t)
PCI_ACCESSOR(device,            DEVICE,         uint16_t)
PCI_ACCESSOR(devid,             DEVID,          uint32_t)
PCI_ACCESSOR(class,             CLASS,          uint8_t)
PCI_ACCESSOR(subclass,          SUBCLASS,       uint8_t)
...

are all there.

Thanks for writing up the page! I started, but got distracted with something else. I've added some bits which will help us align to other wifi man pages

I added this to iwx to debug firmware crashes in comparison to the openbsd driver. I can move back to being a header only and out of iwx. Those crashes aren't happening anymore with the move to the fc release

• Update copyright statements based on advice from review

"GPL-2.0" without only isn't in the spdx license list so I would like to avoid that. I think only here means "not and later" rather than it being a file exclusively licensed with the gpl.

I'm waiting for an ack on spdx tags from @emaste or @imp and I'm not going to commit at 4 on a Friday :D

• Add spdx tags and FreeBSD Foundation Copyright

• rewrite channel map with patch from bz
• Add more printing to rate debugging
• Add an ignore around payload_len

• Comment out debug flags
• Remove FreeBSD revision specifier
• Move iwx to be in the sourcelss block with other intel drivers
• Remove unused functions from build

• Tidy up headers
• Split out debug.h
• Fix build without debug
• Manage firmware lifetimes better
• Change probe priority

• Use iwlwifi names for firmware files
• Parameterise iwx in the modules makefile
• Remove a debug panic

I'm happy with the ieee80211 and driver changes, but bz@ should respond for the linuxkpi as he has all the experience there.

I think that dot11rate should be a uint8_t, but you can change it on commit if you agree

just and fyi, I've broken this down to 5 commits and only pushed the first so far

From my testing this seems good. From there I will break this down a bit so the commits are smaller and start adding stuff next week

In D46689#1082245, @damjan.jov_gmail.com wrote:

This update:

• Makes EIM opt-in, off by default, although I still think this decision needs broader discussion, or even a vote.

Is there a reason this moves in the ordering of nat rules? We tend to aim for roughly alphabetical ordering if there isn't a reason for something different?

Generally looks good, there are some small nits, but I'm happy for this to land once you've made the changes to the man page and the comment at the top.

Sorry one more thing, can you upload future diffs with full context. It makes reviewing on phabricator much easier.

Two small things, I will start testing now

Tweak some wording to imply reality

Sorry it is a bit late

In D16851#1066818, @bdcom.dragon_gmail.com wrote:

I think we just need to check first fragments in frag6_input() and check whole header chain everytime:

if (fragoff == 0)
{
    if (!ip6_valid_hdrchain(&m, off, nxt, frgpartlen))
    {
         icmp6_error(m, ICMP6_PARAM_PROB, ICMP6_PARAMPROB_MISSING_HDR, 0);
         return (IPPROTO_DONE);
     }
}

This will conform with RFC 8200, page 21, last paragraph.

Thanks Ed, I think that is a useful clarification.

For anyone looking into this the ACPI reference table might help:

Thanks for the comments both, I'm sorry I rolled my confusion about the use of cdevpriv and clean up with this change.