User Details
- User Since
- Jan 7 2016, 3:15 PM (510 w, 24 m)
Thu, Oct 9
Fri, Oct 3
I am happy with all three revisions and echo the comments from rgrimes and jtl on a single review and the impact being documented.
Thu, Oct 2
Tue, Sep 30
This seems ok to me, if it doesn't smoke and you can still do vht then its a good step forward
Mon, Sep 22
right after the start of stab week seems like a good time to see if iwx explodes with these
From a glance I am pretty sure this is all incorporated in the udbc patchset.
Thu, Sep 18
Sep 16 2025
Sep 15 2025
Sep 12 2025
Unless someone shouts at me I will land this on Monday so it can make ALPHA3 on Thursday
Sep 10 2025
- fix a typo in man page
- provide full year in copyright
- move devmethod_end onto its own line
- use interface define rather than device define
Sep 9 2025
Sep 8 2025
I am pretty sure I've addressed all outstanding comments, but I could easily have missed some. Could interested people check again?
Sep 4 2025
- move tr_setup label to start of line
- remove body of ioctl function
Sep 3 2025
- take hrs's text for the man page
Sep 2 2025
- remove null check for sc
- Reference latest standard
- Remove XXX comment, this isn't that unclear
- Don't hide reserved and vendor print behind print verbose
- Add extended MSI and usb tunnel capabilities
- don't check first in loop
- spell tun as usb3_tun (and correctly)
Aug 14 2025
- don't check first in loop
Aug 13 2025
- Reference latest standard
- Remove XXX comment, this isn't that unclear
- Don't hide reserved and vendor print behind print verbose
- Add extended MSI and usb tunnel capabilities
Aug 12 2025
Aug 11 2025
- Don't split subdir += lines
- rearrange headers to build (I am sure this built in this tree before)
- Move DRIVER_MODULE to the bottom of the file
- Address review comments on makefile
Jul 15 2025
I think starting wpa_supplicant will result in the interface being brought up, but I still think this is a good action to do explicitly.
Jul 14 2025
- remove null check for sc
Jul 11 2025
Jul 4 2025
Jul 2 2025
Jun 24 2025
Jun 19 2025
Jun 10 2025
As far as I can tell this is nop, but good ground work for future stuff.
This looks to do what is advertised in some simple tests. ddb is pretty fragile for me to use on the best of days so I'm happy enough
May 30 2025
I've done a little testing and this does what I would expect on my test laptop.
Setting the regdomain on iwlwifi cleared this out - sorry for the testing delay.
May 29 2025
I've sent test output via email. With 160MHz configured on my ap and it beaconing iwlwifi doesn't pick a vht rate for the band, just 80211a
May 28 2025
I'm not able to convince an ap to actually do 160MHz channels - despite support in the radios.
Please commit this with "Tested by: thj".
May 27 2025
Please add
- iwx: unlock on error path
- create a diff that can be applied on main (sorry)
No regressions I can see, iwlwifi has vht160 enabled without any configuration.
@adrian said in irc that this should have been caught with other changes. Could you test again on main?
May 26 2025
I unintentionally created another review with my in progress change please see D50462
- Use iwx_init on resume
May 22 2025
May 9 2025
May 6 2025
Apr 14 2025
Meant to add: