Page MenuHomeFreeBSD

thj (Tom Jones)
User

Projects (6)

User Details

User Since
Jan 7 2016, 3:15 PM (510 w, 7 h)

Recent Activity

Thu, Oct 9

thj requested review of D52994: xhci: Add some Alder lake device ids.
Thu, Oct 9, 1:49 PM

Fri, Oct 3

thj accepted D52873: sockets: bump socket buffer limit.
Fri, Oct 3, 6:40 AM
thj accepted D52872: tcp: bump max snd buffer size for autoscaling.
Fri, Oct 3, 6:39 AM
thj accepted D52871: tcp: bump max rcv buffer size for autoscaling.

I am happy with all three revisions and echo the comments from rgrimes and jtl on a single review and the impact being documented.

Fri, Oct 3, 6:39 AM

Thu, Oct 2

thj added a reviewer for D52771: socket(2): refactor the manual page: thj.
Thu, Oct 2, 3:37 PM

Tue, Sep 30

thj accepted D52711: net80211: create accessors for accessing the ieee80211_key key/mic data.
Tue, Sep 30, 10:22 AM · wireless
thj closed D52571: Status/2025/Q3/usb-debugging.adoc: Add status report.
Tue, Sep 30, 10:16 AM
thj committed R9:3a3aaf464aac: Status/2025/Q3/usb-debugging.adoc: Add status report (authored by thj).
Status/2025/Q3/usb-debugging.adoc: Add status report
Tue, Sep 30, 10:16 AM
thj accepted D52767: iwx: rewrite iwx_rs_update() to be VHT aware, refactor it a bit.

This seems ok to me, if it doesn't smoke and you can still do vht then its a good step forward

Tue, Sep 30, 10:11 AM · wireless
thj accepted D52766: iwx: don't log VHT rate lookups in iwx_tx_fill_cmd() for data frames.
Tue, Sep 30, 10:10 AM · wireless

Mon, Sep 22

thj accepted D52655: iwx: add some lock assertions in the TX start path.

right after the start of stab week seems like a good time to see if iwx explodes with these

Mon, Sep 22, 7:54 AM · wireless
thj added a comment to D9157: xHCI Debug Capability support for USB 3.0.

From a glance I am pretty sure this is all incorporated in the udbc patchset.

Mon, Sep 22, 7:52 AM

Thu, Sep 18

thj committed rGe8d181eeb204: udbc(4): connect to build (authored by lwhsu).
udbc(4): connect to build
Thu, Sep 18, 12:55 PM
thj committed rG46e6e9173875: udbc: Add usb debug host mode driver (authored by thj).
udbc: Add usb debug host mode driver
Thu, Sep 18, 12:55 PM

Sep 16 2025

thj requested review of D52571: Status/2025/Q3/usb-debugging.adoc: Add status report.
Sep 16 2025, 12:22 PM

Sep 15 2025

thj committed rGd566b6a70bcb: udbc: Add usb debug host mode driver (authored by thj).
udbc: Add usb debug host mode driver
Sep 15 2025, 2:46 PM
thj closed D51299: udbc: Add usb debug host mode driver.
Sep 15 2025, 2:45 PM

Sep 12 2025

thj added a comment to D51299: udbc: Add usb debug host mode driver.

Unless someone shouts at me I will land this on Monday so it can make ALPHA3 on Thursday

Sep 12 2025, 4:09 PM

Sep 10 2025

thj updated the diff for D51299: udbc: Add usb debug host mode driver.
  • fix a typo in man page
  • provide full year in copyright
  • move devmethod_end onto its own line
  • use interface define rather than device define
Sep 10 2025, 2:03 PM
thj closed D52458: Add "WiFi" to page tags.
Sep 10 2025, 9:11 AM
thj closed D52459: Remove reference to sio(4).
Sep 10 2025, 9:11 AM
thj committed R9:f20f69093944: Remove reference to sio(4) (authored by thj).
Remove reference to sio(4)
Sep 10 2025, 9:11 AM
thj committed R9:aa8043485d35: Add "WiFi" to page tags (authored by thj).
Add "WiFi" to page tags
Sep 10 2025, 9:10 AM
thj added inline comments to D51299: udbc: Add usb debug host mode driver.
Sep 10 2025, 8:58 AM

Sep 9 2025

thj requested review of D52459: Remove reference to sio(4).
Sep 9 2025, 3:11 PM
thj requested review of D52458: Add "WiFi" to page tags.
Sep 9 2025, 3:02 PM

Sep 8 2025

thj added a comment to D51299: udbc: Add usb debug host mode driver.

I am pretty sure I've addressed all outstanding comments, but I could easily have missed some. Could interested people check again?

Sep 8 2025, 1:56 PM

Sep 4 2025

thj updated the diff for D51299: udbc: Add usb debug host mode driver.
  • move tr_setup label to start of line
  • remove body of ioctl function
Sep 4 2025, 9:26 AM

Sep 3 2025

thj updated the diff for D51299: udbc: Add usb debug host mode driver.
  • take hrs's text for the man page
Sep 3 2025, 12:54 PM
thj added inline comments to D51299: udbc: Add usb debug host mode driver.
Sep 3 2025, 12:48 PM

Sep 2 2025

thj committed rG405cfeef615f: xhci: Parse and print extended capabilities (authored by thj).
xhci: Parse and print extended capabilities
Sep 2 2025, 9:38 AM
thj closed D51255: xhci: Parse and print extended capabilities (CFT).
Sep 2 2025, 9:38 AM
thj updated the diff for D51255: xhci: Parse and print extended capabilities (CFT).
  • remove null check for sc
  • Reference latest standard
  • Remove XXX comment, this isn't that unclear
  • Don't hide reserved and vendor print behind print verbose
  • Add extended MSI and usb tunnel capabilities
  • don't check first in loop
  • spell tun as usb3_tun (and correctly)
Sep 2 2025, 9:33 AM

Aug 14 2025

thj updated the diff for D51255: xhci: Parse and print extended capabilities (CFT).
  • don't check first in loop
Aug 14 2025, 8:34 AM
thj added inline comments to D51299: udbc: Add usb debug host mode driver.
Aug 14 2025, 8:30 AM

Aug 13 2025

thj added inline comments to D51255: xhci: Parse and print extended capabilities (CFT).
Aug 13 2025, 3:51 PM
thj updated the diff for D51255: xhci: Parse and print extended capabilities (CFT).
  • Reference latest standard
  • Remove XXX comment, this isn't that unclear
  • Don't hide reserved and vendor print behind print verbose
  • Add extended MSI and usb tunnel capabilities
Aug 13 2025, 2:24 PM

Aug 12 2025

thj added inline comments to D51255: xhci: Parse and print extended capabilities (CFT).
Aug 12 2025, 12:49 PM
thj added inline comments to D51255: xhci: Parse and print extended capabilities (CFT).
Aug 12 2025, 8:49 AM

Aug 11 2025

thj updated the diff for D51299: udbc: Add usb debug host mode driver.
  • Don't split subdir += lines
  • rearrange headers to build (I am sure this built in this tree before)
  • Move DRIVER_MODULE to the bottom of the file
  • Address review comments on makefile
Aug 11 2025, 3:14 PM
thj added inline comments to D51299: udbc: Add usb debug host mode driver.
Aug 11 2025, 2:17 PM

Jul 15 2025

thj accepted D51313: bsdinstall: wlanconfig: properly format regdomain dialog input.
Jul 15 2025, 12:05 PM
thj accepted D51312: bsdinstall: wlanconfig: make sure the interface is up before scanning.

I think starting wpa_supplicant will result in the interface being brought up, but I still think this is a good action to do explicitly.

Jul 15 2025, 12:01 PM

Jul 14 2025

thj added reviewers for D51299: udbc: Add usb debug host mode driver: bz, mhorne.
Jul 14 2025, 12:59 PM
thj requested review of D51299: udbc: Add usb debug host mode driver.
Jul 14 2025, 12:58 PM
thj added reviewers for D51255: xhci: Parse and print extended capabilities (CFT): aokblast, hrs, emaste.
Jul 14 2025, 8:10 AM
thj updated the diff for D51255: xhci: Parse and print extended capabilities (CFT).
  • remove null check for sc
Jul 14 2025, 8:10 AM
thj committed rG4d718f57c58e: xhci pci: Add some amd xhci controller device ids (authored by thj).
xhci pci: Add some amd xhci controller device ids
Jul 14 2025, 8:05 AM
thj closed D51259: xhci pci: Add some amd xhci controller device ids.
Jul 14 2025, 8:05 AM
thj closed D51003: Status/2025/Q2/usb-debugging.adoc: Add status report.
Jul 14 2025, 7:55 AM
thj committed R9:87bfd93c0b86: Status/2025/Q2/usb-debugging.adoc: Add status report (authored by thj).
Status/2025/Q2/usb-debugging.adoc: Add status report
Jul 14 2025, 7:55 AM

Jul 11 2025

thj requested review of D51259: xhci pci: Add some amd xhci controller device ids.
Jul 11 2025, 11:41 AM
thj added inline comments to D51255: xhci: Parse and print extended capabilities (CFT).
Jul 11 2025, 10:58 AM
thj requested review of D51255: xhci: Parse and print extended capabilities (CFT).
Jul 11 2025, 8:05 AM

Jul 4 2025

thj committed rGd72c74a6c52c: loader: Add halt as an alias to poweroff machine (authored by thj).
loader: Add halt as an alias to poweroff machine
Jul 4 2025, 6:48 AM
thj closed D51132: loader: Support halt as well as poweroff to turn off machine.
Jul 4 2025, 6:48 AM

Jul 2 2025

thj requested review of D51132: loader: Support halt as well as poweroff to turn off machine.
Jul 2 2025, 2:33 PM

Jun 24 2025

thj requested review of D51003: Status/2025/Q2/usb-debugging.adoc: Add status report.
Jun 24 2025, 8:19 AM

Jun 19 2025

thj accepted D50929: iwx: correct rssi calculations and reporting.
Jun 19 2025, 11:34 AM
thj accepted D50927: iwx: correct rx status reporting.
Jun 19 2025, 11:33 AM
thj accepted D50926: iwx: correct chain number reporting.
Jun 19 2025, 11:33 AM

Jun 10 2025

thj accepted D50694: iwx: enable seqno offload.

As far as I can tell this is nop, but good ground work for future stuff.

Jun 10 2025, 1:10 PM · wireless
thj accepted D50629: ddb: add optional printing of BBLog entries.

This looks to do what is advertised in some simple tests. ddb is pretty fragile for me to use on the best of days so I'm happy enough

Jun 10 2025, 1:06 PM

May 30 2025

thj accepted D44280: bsdinstall: implement rootpass with bsddialog.

I've done a little testing and this does what I would expect on my test laptop.

May 30 2025, 12:55 PM
thj accepted D49773: net80211: fix VHT160 and VHT80P80 selection and enable in LinuxKPI 802.11.

Setting the regdomain on iwlwifi cleared this out - sorry for the testing delay.

May 30 2025, 8:45 AM

May 29 2025

thj requested changes to D49773: net80211: fix VHT160 and VHT80P80 selection and enable in LinuxKPI 802.11.

I've sent test output via email. With 160MHz configured on my ap and it beaconing iwlwifi doesn't pick a vht rate for the band, just 80211a

May 29 2025, 8:43 AM

May 28 2025

thj accepted D49773: net80211: fix VHT160 and VHT80P80 selection and enable in LinuxKPI 802.11.

I'm not able to convince an ap to actually do 160MHz channels - despite support in the radios.

May 28 2025, 12:56 PM
thj abandoned D37079: diff: Fix matching of CRLF when ignoring white space.
May 28 2025, 9:34 AM
thj committed rG969f6c635358: if_iwx: use net80211 suspend and resume methods (authored by thj).
if_iwx: use net80211 suspend and resume methods
May 28 2025, 9:07 AM
thj committed rG28345b17efca: if_iwx: Make firmware load error messages clearer (authored by thj).
if_iwx: Make firmware load error messages clearer
May 28 2025, 9:07 AM
thj closed D50462: if_iwx: use net80211 suspend and resume methods.
May 28 2025, 9:07 AM
thj closed D49826: iwx: Try to make error messages cleared.
May 28 2025, 9:07 AM
thj accepted D50516: ddb: add show all tcpcbs.

Please commit this with "Tested by: thj".

May 28 2025, 8:36 AM
thj accepted D50535: ddb: improve show tcpcb.
May 28 2025, 8:32 AM

May 27 2025

thj accepted D50488: sound: Terminate stream properly when closing vchans.

Please add

May 27 2025, 1:51 PM
thj accepted D50535: ddb: improve show tcpcb.

Tested by: thj

May 27 2025, 1:31 PM
thj updated the diff for D50462: if_iwx: use net80211 suspend and resume methods.
  • iwx: unlock on error path
  • create a diff that can be applied on main (sorry)
May 27 2025, 9:51 AM
thj added a comment to D49773: net80211: fix VHT160 and VHT80P80 selection and enable in LinuxKPI 802.11.

No regressions I can see, iwlwifi has vht160 enabled without any configuration.

May 27 2025, 9:27 AM
thj added a comment to D38854: rtwn: Fix RTL8188EU and RTL8192EU cannot associate in STA mode.

@adrian said in irc that this should have been caught with other changes. Could you test again on main?

May 27 2025, 8:24 AM

May 26 2025

thj edited reviewers for D48943: Add StarFive JH7110 true random number generator driver, added: csprng; removed: security.
May 26 2025, 3:12 PM · riscv
thj added a reviewer for D48943: Add StarFive JH7110 true random number generator driver: security.
May 26 2025, 3:09 PM · riscv
thj added a comment to D49773: net80211: fix VHT160 and VHT80P80 selection and enable in LinuxKPI 802.11.
In D49773#1153069, @bz wrote:

I've had a few people try this at least with no ill effects (though I am not sure they could test VHT160). @thj can you test the net80211 part?
I don't know otherwise what to do with it as it's been sitting here for a month now.

May 26 2025, 3:06 PM
thj abandoned D35531: Propigate v_free_target updates to pid controllers in each domain.
May 26 2025, 3:03 PM
thj abandoned D49827: iwx: Take the iwx lock in the resume path.

I unintentionally created another review with my in progress change please see D50462

May 26 2025, 3:03 PM
thj added inline comments to D50462: if_iwx: use net80211 suspend and resume methods.
May 26 2025, 1:13 PM
thj updated the diff for D50462: if_iwx: use net80211 suspend and resume methods.
  • Use iwx_init on resume
May 26 2025, 1:12 PM

May 22 2025

thj requested review of D50462: if_iwx: use net80211 suspend and resume methods.
May 22 2025, 2:32 PM

May 9 2025

thj accepted D50219: net/if_dl.h: add param names in prototypes.
May 9 2025, 9:01 AM
thj requested changes to D50264: wtap build error - missing header file.
May 9 2025, 8:56 AM · wireless

May 6 2025

thj accepted D48334: jail: copy mtu settings to vnet interface.
May 6 2025, 9:55 AM

Apr 14 2025

thj requested review of D49827: iwx: Take the iwx lock in the resume path.
Apr 14 2025, 1:49 PM
thj requested review of D49826: iwx: Try to make error messages cleared.
Apr 14 2025, 1:47 PM
thj added a comment to D49825: firmware: Be clearer about where load errors originate.

Meant to add:

Apr 14 2025, 1:44 PM
thj added reviewers for D49825: firmware: Be clearer about where load errors originate: bz, adrian.
Apr 14 2025, 1:43 PM
thj requested review of D49825: firmware: Be clearer about where load errors originate.
Apr 14 2025, 1:43 PM
thj committed rG71baab405ef6: iwx: Remove debug logging code (authored by thj).
iwx: Remove debug logging code
Apr 14 2025, 8:57 AM
thj closed D49783: if_iwx: Remove debug logging code.
Apr 14 2025, 8:57 AM
thj committed rG1110ed3b46ea: iwx: Use subdevice for comparison (authored by thj).
iwx: Use subdevice for comparison
Apr 14 2025, 8:17 AM
thj closed D49759: iwx: Look up subdevice rather than device.
Apr 14 2025, 8:17 AM

Apr 11 2025

thj requested review of D49783: if_iwx: Remove debug logging code.
Apr 11 2025, 3:03 PM