Page MenuHomeFreeBSD

iwx: Try to make error messages cleared
ClosedPublic

Authored by thj on Apr 14 2025, 1:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 3:46 AM
Unknown Object (File)
Tue, Sep 30, 3:50 AM
Unknown Object (File)
Sat, Sep 27, 2:39 AM
Unknown Object (File)
Sep 15 2025, 10:04 PM
Unknown Object (File)
Sep 15 2025, 7:16 AM
Unknown Object (File)
Sep 9 2025, 8:27 PM
Unknown Object (File)
Sep 8 2025, 2:38 PM
Unknown Object (File)
Sep 1 2025, 1:36 AM

Details

Summary

There are quite a lot of prints in the firmware error path right of iwx.
Try and make it clearer where the errors are coming from particularly
make it clear that transferring firmware failed, not loading firmware.

High the init firmware failed message behind a debug level, there are
other errors which will show already in this path and for most people
this doesn't add much.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

thj requested review of this revision.Apr 14 2025, 1:47 PM

I like this!

We also likely can create an IWN_PRINTF(sc, fmt, ...) that does device_printf(), so you're not manually assembling things with DEVNAME, etc.
Let's talk about it on irc. :-)

This revision is now accepted and ready to land.Apr 14 2025, 2:19 PM