Page MenuHomeFreeBSD
Differential D50535

ddb: improve show tcpcb
ClosedPublic
Actions

Authored by tuexen on May 26 2025, 6:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 5:35 PM
Unknown Object (File)
Wed, Oct 8, 1:45 AM
Unknown Object (File)
Fri, Oct 3, 2:27 PM
Unknown Object (File)
Wed, Oct 1, 12:16 AM
Unknown Object (File)
Tue, Sep 30, 8:58 AM
Unknown Object (File)
Mon, Sep 29, 11:29 PM
Unknown Object (File)
Wed, Sep 24, 12:26 PM
Unknown Object (File)
Sat, Sep 20, 3:51 AM
View All 45 Files
Subscribers
glebius
imp
melifaro
thj

Details

Reviewers
rrs
rscheff
cc
peter.lei_ieee.org
lstewart
thj
Group Reviewers
transport
Commits
rGca0fcea09cf4: ddb: improve show tcpcb
rG8d4f495df465: ddb: improve show tcpcb
Summary

Print the name of the TCP function block and the name of the congestion control algorithm. Furthermore, print some information related to Black Box Logging.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen created this revision.May 26 2025, 6:52 PM
Herald added a reviewer: transport. · View Herald TranscriptMay 26 2025, 6:52 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.May 26 2025, 6:52 PM
tuexen edited the summary of this revision. (Show Details)May 26 2025, 7:17 PM
thj accepted this revision.May 27 2025, 1:31 PM
thj added a subscriber: thj.

Tested by: thj

sys/netinet/tcp_usrreq.c
3052

I think we should include TCP_LOG_STATE_RATIO_OFF and TCP_LOG_STATE_CLEAR, I know CLEAR shouldn't be stored, but it will avoid spurious debugging of UNKNOWN in ddb.

This revision is now accepted and ready to land.May 27 2025, 1:31 PM
tuexen updated this revision to Diff 156099.May 27 2025, 5:11 PM

Add handling of TCP_LOG_STATE_RATIO_OFF and TCP_LOG_STATE_CLEAR as suggested by thj.

This revision now requires review to proceed.May 27 2025, 5:11 PM
tuexen marked an inline comment as done.May 27 2025, 5:11 PM
tuexen added inline comments.
sys/netinet/tcp_usrreq.c
3052

Done.

thj accepted this revision.May 28 2025, 8:32 AM
This revision is now accepted and ready to land.May 28 2025, 8:32 AM
Closed by commit rG8d4f495df465: ddb: improve show tcpcb (authored by tuexen). · Explain WhyMay 28 2025, 10:15 AM
This revision was automatically updated to reflect the committed changes.
tuexen marked an inline comment as done.
tuexen added a commit: rG8d4f495df465: ddb: improve show tcpcb.
tuexen added a commit: rGca0fcea09cf4: ddb: improve show tcpcb.Sep 4 2025, 8:00 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
52 lines

Diff 156161

View Options

sys/netinet/tcp_usrreq.c

Loading...