Differential D51255
xhci: Parse and print extended capabilities (CFT) Authored by thj on Fri, Jul 11, 8:05 AM. Tags None Referenced Files
Subscribers
Details We need to pick up extended capabilities for xhci debug. It makes sense to me to parse out all the capabilities on the controller, printing those that we know. This will make it easier to know if debug is supported, we can tell someone to check dmesg, and it lets us gather up from dmesgd the deployment of other features. A change like this should make it possible to know if other interesting extensions are implemented or not by vendors, virt is one which if available would be worth exploring. Please patch, reboot and provide the output from the following commands: $ dmesg | grep xhci; sysctl hw.model; pciconf -l | grep xhciIt will look something like this: xhci0: <Intel Union Point USB 3.0 controller> mem 0xf7030000-0xf703ffff at device 20.0 on pci0 xhci0: 32 bytes context size, 64-bit DMA xhci0: xECP capabilities <PROTO,PROTO,LEGACY,DEBUG> usbus0 on xhci0 hw.model: Intel(R) Core(TM) i5-7600T CPU @ 2.80GHz xhci0@pci0:0:20:0: class=0x0c0330 rev=0x00 hdr=0x00 vendor=0x8086 device=0xa2af subvendor=0x17aa subdevice=0x3111 The pciconf line will help me spot controllers using the generic driver, if any appear I'll add them to the parse list. Testing on systems with none pcie xhci controllers would be great too as I don't have any handy right now. The raspberry pi is supposed to support xhci debug, but I've no direct evidence
Diff Detail
Event TimelineComment Actions I'll see if I can try this on real hardware tomorrow.
Comment Actions ➜ ~ dmesg | grep xhci; sysctl hw.model; pciconf -l | grep xhci xhci0: <XHCI (generic) USB 3.0 controller> mem 0xf6700000-0xf6707fff at device 0.0 on pci10 xhci0: 32 bytes context size, 64-bit DMA xhci0: xECP capabilities <LEGACY,PROTO,PROTO,PROTO,DEBUG> usbus0 on xhci0 xhci1: <XHCI (generic) USB 3.0 controller> mem 0xf6300000-0xf63fffff at device 0.3 on pci13 xhci1: 64 bytes context size, 64-bit DMA xhci1: xECP capabilities <LEGACY,PROTO,PROTO,PROTO,DEBUG> usbus1 on xhci1 xhci2: <XHCI (generic) USB 3.0 controller> mem 0xf6200000-0xf62fffff at device 0.4 on pci13 xhci2: 64 bytes context size, 64-bit DMA xhci2: xECP capabilities <LEGACY,PROTO,PROTO,PROTO,DEBUG> usbus2 on xhci2 xhci3: <XHCI (generic) USB 3.0 controller> mem 0xf6a00000-0xf6afffff at device 0.0 on pci14 xhci3: 64 bytes context size, 64-bit DMA xhci3: xECP capabilities <LEGACY,PROTO,DEBUG> usbus3 on xhci3 hw.model: AMD Ryzen 9 7900X 12-Core Processor xhci0@pci0:10:0:0: class=0x0c0330 rev=0x01 hdr=0x00 vendor=0x1022 device=0x43f7 subvendor=0x1b21 subdevice=0x1142 xhci1@pci0:13:0:3: class=0x0c0330 rev=0x00 hdr=0x00 vendor=0x1022 device=0x15b6 subvendor=0x1043 subdevice=0x8877 xhci2@pci0:13:0:4: class=0x0c0330 rev=0x00 hdr=0x00 vendor=0x1022 device=0x15b7 subvendor=0x1043 subdevice=0x8877 xhci3@pci0:14:0:0: class=0x0c0330 rev=0x00 hdr=0x00 vendor=0x1022 device=0x15b8 subvendor=0x1043 subdevice=0x8877
Comment Actions xhci0: <Intel Lewisburg USB 3.0 controller> mem 0x92f00000-0x92f0ffff irq 16 at device 20.0 numa-domain 0 on pci0 Comment Actions # my crappy xps13 laptop dmesg |grep xhci ; sysctl hw.model; pciconf -l |grep xhci xhci0: <Intel Sunrise Point-LP USB 3.0 controller> mem 0xdc310000-0xdc31ffff at device 20.0 on pci0 xhci0: 32 bytes context size, 64-bit DMA xhci0: xECP capabilities <PROTO,PROTO,LEGACY,DEBUG> usbus0 on xhci0 xhci0: <Intel Sunrise Point-LP USB 3.0 controller> mem 0xdc310000-0xdc31ffff at device 20.0 on pci0 xhci0: 32 bytes context size, 64-bit DMA xhci0: xECP capabilities <PROTO,PROTO,LEGACY,DEBUG> usbus0 on xhci0 hw.model: Intel(R) Core(TM) i7-7560U CPU @ 2.40GHz xhci0@pci0:0:20:0: class=0x0c0330 rev=0x21 hdr=0x00 vendor=0x8086 device=0x9d2f subvendor=0x1028 subdevice=0x075b Comment Actions Looks fine to me, although I haven't looked at the doc in detail yet.
In a future commit we should decode the PROTO entries more.
| ||||||||||||||||||||||||||||||||||||||||||||||||||