Page MenuHomeFreeBSD

me_jamesrm.com (James Mintram)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2020, 5:28 PM (76 w, 3 d)

Recent Activity

May 7 2021

me_jamesrm.com updated the diff for D30050: Adds uuid validation to bhyve(8) arg parsing.

Update's error message as per the suggestion from @editor_callfortesting.org

May 7 2021, 8:16 AM

May 2 2021

me_jamesrm.com updated the diff for D30050: Adds uuid validation to bhyve(8) arg parsing.

style(9)

May 2 2021, 12:26 PM

May 1 2021

me_jamesrm.com added inline comments to D30050: Adds uuid validation to bhyve(8) arg parsing.
May 1 2021, 11:39 PM
me_jamesrm.com updated the diff for D30050: Adds uuid validation to bhyve(8) arg parsing.

Cleanup

May 1 2021, 11:37 PM
me_jamesrm.com updated the diff for D30050: Adds uuid validation to bhyve(8) arg parsing.

Feedback

May 1 2021, 11:36 PM
me_jamesrm.com added a comment to D26743: Factor out code from fstyp into libfstyp.

Thanks for the feedback @trasz - I can see the argument for isolation - but shelling out introduces it's own problems. The APIs are implicit + can break without anyone noticing. If the output (API) of fstyp changes it's dependencies could break or exhibit undefined behaviour, and this will not be obvious to the person making those changes. Also consuming fstyp as a library makes it much easier to see it's dependencies, they are declared in the build files.

May 1 2021, 6:57 PM
me_jamesrm.com updated the diff for D30050: Adds uuid validation to bhyve(8) arg parsing.

Ok, after additional feedback from @rgrimes I have reworked the patch. Thanks for the feedback.

May 1 2021, 3:13 PM
me_jamesrm.com added a comment to D30050: Adds uuid validation to bhyve(8) arg parsing.

I see that doing the validation twice makes no sense. However I do
like the idea of validating inputs early on in the program execution. It's
also where the rest of the command line argument validation exists, so it seems
like the natural place for it?

May 1 2021, 1:57 PM
me_jamesrm.com updated the diff for D30050: Adds uuid validation to bhyve(8) arg parsing.

Review feedback

May 1 2021, 1:55 PM

Apr 30 2021

me_jamesrm.com updated the diff for D30050: Adds uuid validation to bhyve(8) arg parsing.

Style feedback thanks @kp

Apr 30 2021, 5:52 PM
me_jamesrm.com updated the diff for D30050: Adds uuid validation to bhyve(8) arg parsing.

Fix history

Apr 30 2021, 5:31 PM
me_jamesrm.com updated the diff for D30050: Adds uuid validation to bhyve(8) arg parsing.
  • Whitespace
Apr 30 2021, 5:28 PM
me_jamesrm.com added a reviewer for D30050: Adds uuid validation to bhyve(8) arg parsing: editor_callfortesting.org.

Adding Michael as he raised the bug here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255467

Apr 30 2021, 5:25 PM
me_jamesrm.com requested review of D30050: Adds uuid validation to bhyve(8) arg parsing.
Apr 30 2021, 5:24 PM

Dec 14 2020

me_jamesrm.com added inline comments to D26976: bhyve - ARMv8 implementation.
Dec 14 2020, 3:47 PM

Dec 12 2020

me_jamesrm.com added inline comments to D26976: bhyve - ARMv8 implementation.
Dec 12 2020, 3:21 PM

Oct 11 2020

me_jamesrm.com updated the summary of D26743: Factor out code from fstyp into libfstyp.
Oct 11 2020, 9:40 PM
me_jamesrm.com added a reviewer for D26743: Factor out code from fstyp into libfstyp: kevans.
Oct 11 2020, 9:37 PM
me_jamesrm.com requested review of D26743: Factor out code from fstyp into libfstyp.
Oct 11 2020, 9:36 PM

Jun 23 2020

me_jamesrm.com updated the diff for D25349: Add support for CPU freq to Raspberry PI 4.

Cleanup

Jun 23 2020, 3:27 AM
me_jamesrm.com updated the diff for D25349: Add support for CPU freq to Raspberry PI 4.

Cleanup

Jun 23 2020, 3:27 AM

Jun 22 2020

me_jamesrm.com updated the diff for D22493: Support for bcm2838 RNG.

Fixes pointer arithmetic and adds const qualifier to conf data pointers.

Jun 22 2020, 6:45 AM · arm64
me_jamesrm.com commandeered D22493: Support for bcm2838 RNG.

Commandeering revision after speaking with @crowston_protonmail.com

Jun 22 2020, 6:43 AM · arm64

Jun 21 2020

me_jamesrm.com added inline comments to D22493: Support for bcm2838 RNG.
Jun 21 2020, 4:53 PM · arm64

Jun 18 2020

me_jamesrm.com requested review of D25349: Add support for CPU freq to Raspberry PI 4.
Jun 18 2020, 9:27 PM