- User Since
- Jun 15 2020, 5:28 PM (144 w, 5 d)
Apr 16 2022
@jhb apologies.. I only just realised this had outstanding feedback :-o
May 7 2021
Update's error message as per the suggestion from @editor_callfortesting.org
May 2 2021
May 1 2021
Thanks for the feedback @trasz - I can see the argument for isolation - but shelling out introduces it's own problems. The APIs are implicit + can break without anyone noticing. If the output (API) of fstyp changes it's dependencies could break or exhibit undefined behaviour, and this will not be obvious to the person making those changes. Also consuming fstyp as a library makes it much easier to see it's dependencies, they are declared in the build files.
Ok, after additional feedback from @rgrimes I have reworked the patch. Thanks for the feedback.
I see that doing the validation twice makes no sense. However I do
like the idea of validating inputs early on in the program execution. It's
also where the rest of the command line argument validation exists, so it seems
like the natural place for it?
Apr 30 2021
Style feedback thanks @kp
Adding Michael as he raised the bug here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255467
Dec 14 2020
Dec 12 2020
Oct 11 2020
Jun 23 2020
Jun 22 2020
Fixes pointer arithmetic and adds const qualifier to conf data pointers.
Commandeering revision after speaking with @crowston_protonmail.com