User Details
- User Since
- Jun 15 2020, 5:28 PM (265 w, 3 d)
Fri, Jul 11
➜ ~ dmesg | grep xhci; sysctl hw.model; pciconf -l | grep xhci xhci0: <XHCI (generic) USB 3.0 controller> mem 0xf6700000-0xf6707fff at device 0.0 on pci10 xhci0: 32 bytes context size, 64-bit DMA xhci0: xECP capabilities <LEGACY,PROTO,PROTO,PROTO,DEBUG> usbus0 on xhci0 xhci1: <XHCI (generic) USB 3.0 controller> mem 0xf6300000-0xf63fffff at device 0.3 on pci13 xhci1: 64 bytes context size, 64-bit DMA xhci1: xECP capabilities <LEGACY,PROTO,PROTO,PROTO,DEBUG> usbus1 on xhci1 xhci2: <XHCI (generic) USB 3.0 controller> mem 0xf6200000-0xf62fffff at device 0.4 on pci13 xhci2: 64 bytes context size, 64-bit DMA xhci2: xECP capabilities <LEGACY,PROTO,PROTO,PROTO,DEBUG> usbus2 on xhci2 xhci3: <XHCI (generic) USB 3.0 controller> mem 0xf6a00000-0xf6afffff at device 0.0 on pci14 xhci3: 64 bytes context size, 64-bit DMA xhci3: xECP capabilities <LEGACY,PROTO,DEBUG> usbus3 on xhci3 hw.model: AMD Ryzen 9 7900X 12-Core Processor xhci0@pci0:10:0:0: class=0x0c0330 rev=0x01 hdr=0x00 vendor=0x1022 device=0x43f7 subvendor=0x1b21 subdevice=0x1142 xhci1@pci0:13:0:3: class=0x0c0330 rev=0x00 hdr=0x00 vendor=0x1022 device=0x15b6 subvendor=0x1043 subdevice=0x8877 xhci2@pci0:13:0:4: class=0x0c0330 rev=0x00 hdr=0x00 vendor=0x1022 device=0x15b7 subvendor=0x1043 subdevice=0x8877 xhci3@pci0:14:0:0: class=0x0c0330 rev=0x00 hdr=0x00 vendor=0x1022 device=0x15b8 subvendor=0x1043 subdevice=0x8877
Apr 16 2022
@jhb apologies.. I only just realised this had outstanding feedback :-o
May 7 2021
Update's error message as per the suggestion from @editor_callfortesting.org
May 2 2021
style(9)
May 1 2021
Cleanup
Feedback
Thanks for the feedback @trasz - I can see the argument for isolation - but shelling out introduces it's own problems. The APIs are implicit + can break without anyone noticing. If the output (API) of fstyp changes it's dependencies could break or exhibit undefined behaviour, and this will not be obvious to the person making those changes. Also consuming fstyp as a library makes it much easier to see it's dependencies, they are declared in the build files.
Ok, after additional feedback from @rgrimes I have reworked the patch. Thanks for the feedback.
I see that doing the validation twice makes no sense. However I do
like the idea of validating inputs early on in the program execution. It's
also where the rest of the command line argument validation exists, so it seems
like the natural place for it?
Review feedback
Apr 30 2021
Style feedback thanks @kp
Fix history
- Whitespace
Adding Michael as he raised the bug here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255467
Dec 14 2020
Dec 12 2020
Oct 11 2020
Jun 23 2020
Cleanup
Cleanup
Jun 22 2020
Fixes pointer arithmetic and adds const qualifier to conf data pointers.
Commandeering revision after speaking with @crowston_protonmail.com