The widest value used with code is 32 bits, other values are smaller.
Reduce this down. Update printfs.
This the build on i386.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I was looking it this post-commit and wondered a lot. I don't know what's it's good for? Most of this can be done with a 7 line Dtrace script. And in addition for async commands most of this doesn't help too much as you need the information you grab from the firmware to see which hcmd it was actually executing for problems. This lots of smells like "I want to compare Linux traceinfo with FreeBSD command order" to replicate but then again you'll need the full argument information for most to actually make sense and I cannot see that here either.
(and I am not talking about the looking up command names bits which are useful elsewhere as well even without DEBUG)
Comment Actions
I added this to iwx to debug firmware crashes in comparison to the openbsd driver. I can move back to being a header only and out of iwx. Those crashes aren't happening anymore with the move to the fc release