Page MenuHomeFreeBSD

bsdinstall: wlanconfig: make sure the interface is up before scanning
ClosedPublic

Authored by bz on Jul 14 2025, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 11, 3:14 PM
Unknown Object (File)
Sun, May 10, 3:41 PM
Unknown Object (File)
Wed, Apr 29, 4:06 AM
Unknown Object (File)
Wed, Apr 29, 4:03 AM
Unknown Object (File)
Tue, Apr 28, 2:22 AM
Unknown Object (File)
Mon, Apr 27, 10:00 PM
Unknown Object (File)
Thu, Apr 23, 10:47 AM
Unknown Object (File)
Thu, Apr 23, 10:20 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Jul 14 2025, 7:44 PM
thj added a subscriber: thj.

I think starting wpa_supplicant will result in the interface being brought up, but I still think this is a good action to do explicitly.

This revision is now accepted and ready to land.Jul 15 2025, 12:01 PM

Yes. There were times when I was just running the script and wpa_supplicant was running already but the interface was "down" and then things failed horribly.
Unlikely to happen in the course of the normal auto install but with this shell script I am better save than sorry.

I should probably amend the commit message with the case I triggered this so it's clear as-to why?

emaste added a subscriber: emaste.

I should probably amend the commit message with the case I triggered this so it's clear as-to why?

Sounds good. Maybe even as a comment before the ifconfig $WLAN_IFACE up call.

Add comment before the ew line as suggested by @emaste.

This revision now requires review to proceed.Jul 15 2025, 6:11 PM
This revision is now accepted and ready to land.Jul 15 2025, 6:15 PM