Page MenuHomeFreeBSD

jkoshy (Joseph Koshy)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 12 2023, 8:52 AM (92 w, 5 d)

Recent Activity

Feb 20 2024

jkoshy committed rG81dc3a4d3bb9: tools/net80211/wlanwatch: Remove obsolete code. (authored by jkoshy).
tools/net80211/wlanwatch: Remove obsolete code.
Feb 20 2024, 8:30 AM

Sep 26 2023

jkoshy accepted D41978: pmcstat: fix duplicate event allocation on CPU 0.
Sep 26 2023, 11:43 AM

Aug 24 2023

jkoshy accepted D41270: hwpmc: tidy pcd_finalize methods.
Aug 24 2023, 8:09 PM

Aug 20 2023

jkoshy accepted D40753: pmc: better distinguish pmu-events allocation path.

I would like to commit this soon, ideally before the stable/14 branch. @jkoshy any further thoughts?

Aug 20 2023, 5:53 PM

Aug 9 2023

jkoshy accepted D41271: hwpmc_core: remove two non-existent function prototypes.
Aug 9 2023, 5:15 AM
jkoshy accepted D41273: hwpmc_amd: simplify counter descriptor definitions.
Aug 9 2023, 5:15 AM
jkoshy accepted D41274: hwpmc_amd: kill off k7 support bits.
Aug 9 2023, 5:14 AM
jkoshy accepted D41275: pmc: remove last bits of AMD K7 CPU support.
Aug 9 2023, 5:13 AM
jkoshy added inline comments to D41276: hwpmc_amd: tighten up MSR definitions.
Aug 9 2023, 5:13 AM
jkoshy accepted D41276: hwpmc_amd: tighten up MSR definitions.
Aug 9 2023, 5:10 AM
jkoshy accepted D41277: hwpmc_amd: check extended CPUID bits.
Aug 9 2023, 5:09 AM

Aug 3 2023

jkoshy accepted D41272: hpwmc_amd.c: style improvements.
Aug 3 2023, 6:01 PM

Aug 2 2023

jkoshy accepted D41268: hwpmc_arm64: plug memory leak.
Aug 2 2023, 7:12 PM
jkoshy accepted D41269: hwpmc_armv7: plug memory leak.
Aug 2 2023, 7:12 PM
jkoshy accepted D41279: pmc.amd(3): rename from pmc.k8(3).

LGTM.

Aug 2 2023, 7:09 PM
jkoshy added inline comments to D41277: hwpmc_amd: check extended CPUID bits.
Aug 2 2023, 7:47 AM
jkoshy added inline comments to D41278: hwpmc_amd: improve assertions in amd_pcpu_fini().
Aug 2 2023, 7:36 AM
jkoshy added a comment to D41275: pmc: remove last bits of AMD K7 CPU support.

Quick question: are K7 CPUs no longer supported?

Aug 2 2023, 7:24 AM
jkoshy added a comment to D41279: pmc.amd(3): rename from pmc.k8(3).

Please consider a rename to 'pmc.amd.k8.3'?

Aug 2 2023, 7:21 AM

Jul 8 2023

jkoshy accepted D40913: hwpmc(4): update DEBUGGING section details.
Jul 8 2023, 7:32 AM

Jul 7 2023

jkoshy accepted D40752: libpmc: make pmc_pmu_pmcallocate() machine-independent.
Jul 7 2023, 6:48 AM

Jun 26 2023

jkoshy added a comment to D40753: pmc: better distinguish pmu-events allocation path.

Have you considered translating the older event definitions to JSON form, and dispensing with the __PMC_EVENTS macro?

Jun 26 2023, 9:22 AM

Jun 20 2023

jkoshy accepted D40651: libpmc: Define a PMCLOG_SKIP32 helper macro to skip over a 32-bit field..
Jun 20 2023, 5:25 PM

Jun 16 2023

jkoshy accepted D40544: hwpmc: add error for HWPMC_DEBUG without KTR.
Jun 16 2023, 4:05 AM
jkoshy accepted D40542: hwpmc(4): more detailed SYNOPSYS.
Jun 16 2023, 4:04 AM
jkoshy accepted D40543: pmc: clarify and strengthen statements about API/ABI.
Jun 16 2023, 4:03 AM

Jun 14 2023

jkoshy requested changes to D40542: hwpmc(4): more detailed SYNOPSYS.
Jun 14 2023, 8:09 PM
jkoshy accepted D40541: hwpmc(4): remove paragraph about Pentium Pro handling.

Please also mention in the commit log that hwpmc(4) no longer supports this CPU model?

Jun 14 2023, 8:07 PM
jkoshy added inline comments to D40542: hwpmc(4): more detailed SYNOPSYS.
Jun 14 2023, 7:35 PM
jkoshy added inline comments to D40289: hwpmc: style(9) pass of hwpmc_mod.c.
Jun 14 2023, 10:01 AM
jkoshy accepted D40517: hwpmc_mod.c: misc style cleanup.
Jun 14 2023, 9:58 AM
jkoshy accepted D40515: hwpmc_mod.c: conditional and loop style.
Jun 14 2023, 9:53 AM
jkoshy accepted D40513: hwpmc_mod.c: return statement style.
Jun 14 2023, 9:46 AM
jkoshy accepted D40518: hwpmc: flatten conditional in pmc_process_exit().
Jun 14 2023, 9:45 AM
jkoshy accepted D40514: hwpmc_mod.c: whitespace style cleanup.
Jun 14 2023, 9:42 AM
jkoshy added inline comments to D40514: hwpmc_mod.c: whitespace style cleanup.
Jun 14 2023, 9:24 AM
jkoshy accepted D40516: hwpmc_mod.c: prototype style.
Jun 14 2023, 9:18 AM

Jun 13 2023

jkoshy added inline comments to D40289: hwpmc: style(9) pass of hwpmc_mod.c.
Jun 13 2023, 7:36 AM
jkoshy accepted D40292: hwpmc: split out PMC_OP_PMCALLOCATE.
Jun 13 2023, 7:19 AM

Jun 5 2023

jkoshy accepted D40333: hwpmc: split out PMC_FN_PROCESS_EXEC.
Jun 5 2023, 5:15 PM

Jun 2 2023

jkoshy accepted D40294: hwpmc: split out PMC_OP_PMCRW.
Jun 2 2023, 8:53 PM
jkoshy accepted D40293: hwpmc: split out PMC_OP_PMCRELEASE.
Jun 2 2023, 8:47 PM

May 31 2023

jkoshy requested changes to D40293: hwpmc: split out PMC_OP_PMCRELEASE.
May 31 2023, 6:55 AM
jkoshy requested changes to D40294: hwpmc: split out PMC_OP_PMCRW.
May 31 2023, 6:48 AM

May 30 2023

jkoshy accepted D40291: hwpmc: split out PMC_OP_PMCATTACH/PMC_OP_PMCDETACH.
May 30 2023, 8:05 PM
jkoshy accepted D40334: libpmc: expand PMC_OP* defines.
May 30 2023, 5:11 PM

May 26 2023

jkoshy accepted D40288: hpwmc: add __pmcdbg_used annotation.
May 26 2023, 8:36 PM

May 12 2023

jkoshy accepted D39626: libpmcstat: Teach pmcstat_image_get_elf_params about debug files.
May 12 2023, 6:10 AM
jkoshy accepted D40048: pmc: Provide full path to modules from kernel linker.
May 12 2023, 6:07 AM
jkoshy accepted D40050: pmc: Bump major version for just-committed breaking changes.
May 12 2023, 6:01 AM

May 5 2023

jkoshy committed rGc2eae5c39adc: man9: Add a manual page for kstack_contains(9). (authored by jkoshy).
man9: Add a manual page for kstack_contains(9).
May 5 2023, 2:45 PM
jkoshy closed D39933: man9: Add a manual page for kstack_contains(9)..
May 5 2023, 2:44 PM

May 3 2023

jkoshy accepted D39903: pmc_events.h: event list formatting.
May 3 2023, 10:22 AM
jkoshy accepted D39902: pmc_events.h: update event list comment.
May 3 2023, 10:16 AM
jkoshy accepted D39901: hwpmc: remove remaining UCP event definitions.
May 3 2023, 10:16 AM
jkoshy accepted D39904: hwpmc: trim obsolete Intel CPU and class defs.
May 3 2023, 10:14 AM
jkoshy accepted D39905: hwpmc: trim MIPS CPU and class defs.

Was support for these CPUs ever implemented?

May 3 2023, 10:05 AM
jkoshy accepted D39911: hwpmc_logging: less macro magic for type names.
May 3 2023, 10:00 AM
jkoshy accepted D39912: hwpmc: remove pmd_pcpu_{init,fini} callbacks.

Thanks for the clean up.

May 3 2023, 9:58 AM
jkoshy accepted D39913: hwpmc: remove stub pmd_switch_{in,out} methods.

LGTM

May 3 2023, 9:57 AM
jkoshy accepted D39906: hwpmc: formatting of CPU and class lists.

LGTM

May 3 2023, 9:55 AM
jkoshy accepted D39907: pmcstat: augment an error message.

LGTM

May 3 2023, 9:53 AM
jkoshy accepted D39915: hwpmc: pass pmc pointer to more class methods.

FYI, the pm_id field in a struct pmc contains the CPU and 'row index' for the PMC, so we could potentially drop the cpu and ri fields in a future change.

May 3 2023, 9:48 AM

May 2 2023

jkoshy accepted D39914: hwpmc: unused/diagused annotations in tsc class.

LGTM

May 2 2023, 6:09 PM
jkoshy accepted D39909: hwpmc: use kstack_contains().
May 2 2023, 6:04 PM
jkoshy accepted D39900: hwpmc: drop vestigial IAP event definitions.

LGTM

May 2 2023, 6:01 PM
jkoshy accepted D39910: hwpmc: don't use deprecated copystr(9).

LGTM

May 2 2023, 5:59 PM
jkoshy added a comment to D39933: man9: Add a manual page for kstack_contains(9)..

One thing I am trying to be more considerate of when it comes to section 9
pages is "how can this page be discovered?" In other words, is it cross-referenced
from another man page or is it referenced anywhere in the source code? I do not
think there are any obvious candidates which should reference kstack_contains(9)
in their SEE ALSO, but pointing to the man page at the kstack_contains() definitions
might help the reader learn that the page exists at all. Just something to consider,
I am not asking you to do anything specific here.

May 2 2023, 5:57 PM
jkoshy accepted D39934: hwpmc: simplify arm64 kernel stack unwinding.
May 2 2023, 5:49 PM
jkoshy added a comment to D39933: man9: Add a manual page for kstack_contains(9)..

Addressed a review comment.

May 2 2023, 5:38 PM
jkoshy updated the diff for D39933: man9: Add a manual page for kstack_contains(9)..

Address a review comment.

May 2 2023, 5:38 PM
jkoshy added a comment to D39933: man9: Add a manual page for kstack_contains(9)..

Addressed review comments.

May 2 2023, 2:33 PM
jkoshy updated the diff for D39933: man9: Add a manual page for kstack_contains(9)..

Addressed review comments.

May 2 2023, 2:33 PM
jkoshy accepted D39908: arm/arm64 pmu: add a PMCDBG to interrupt handler.
May 2 2023, 9:52 AM
jkoshy added a reviewer for D39933: man9: Add a manual page for kstack_contains(9).: mhorne.
May 2 2023, 9:44 AM
jkoshy accepted D39909: hwpmc: use kstack_contains().
May 2 2023, 9:43 AM
jkoshy requested review of D39933: man9: Add a manual page for kstack_contains(9)..
May 2 2023, 9:39 AM
jkoshy requested changes to D39910: hwpmc: don't use deprecated copystr(9).
May 2 2023, 7:42 AM

Apr 20 2023

jkoshy added inline comments to D39595: pmc: Rework PROCEXEC event to support PIEs.
Apr 20 2023, 7:51 AM

Apr 18 2023

jkoshy added inline comments to D39595: pmc: Rework PROCEXEC event to support PIEs.
Apr 18 2023, 6:19 PM

Apr 10 2023

jkoshy committed rG0e9e9048ae08: procfs: Sync a documentation comment with the code. (authored by jkoshy).
procfs: Sync a documentation comment with the code.
Apr 10 2023, 6:00 PM
jkoshy closed D39488: procfs: Sync a documentation comment with the code..
Apr 10 2023, 5:59 PM
jkoshy requested review of D39488: procfs: Sync a documentation comment with the code..
Apr 10 2023, 5:30 PM
jkoshy committed rGde07f7f06e5e: procfs: Document the content of /proc/$PID/map. (authored by jkoshy).
procfs: Document the content of /proc/$PID/map.
Apr 10 2023, 4:38 PM
jkoshy closed D39484: procfs: Document the content of /proc/$PID/map..
Apr 10 2023, 4:37 PM

Apr 5 2023

jkoshy committed rGf401d82ef7cf: pmc: Keep a list sorted. (authored by jkoshy).
pmc: Keep a list sorted.
Apr 5 2023, 8:52 PM
jkoshy closed D39439: pmc: Keep a list sorted..
Apr 5 2023, 8:51 PM
jkoshy updated the diff for D39439: pmc: Keep a list sorted..

Updated the manual page date.

Apr 5 2023, 6:40 PM
jkoshy requested review of D39439: pmc: Keep a list sorted..
Apr 5 2023, 6:38 PM

Mar 29 2023

jkoshy committed rG57014ab77647: pmc: Add a reminder to maintain documentation. (authored by jkoshy).
pmc: Add a reminder to maintain documentation.
Mar 29 2023, 9:13 AM
jkoshy closed D39298: pmc: Add a reminder to maintain documentation..
Mar 29 2023, 9:13 AM

Mar 28 2023

jkoshy requested review of D39298: pmc: Add a reminder to maintain documentation..
Mar 28 2023, 9:43 PM

Mar 25 2023

jkoshy committed rG609312077684: procfs: Add manual page cross references. (authored by jkoshy).
procfs: Add manual page cross references.
Mar 25 2023, 4:23 PM
jkoshy closed D39264: procfs: Add manual page cross references..
Mar 25 2023, 4:22 PM
jkoshy requested review of D39264: procfs: Add manual page cross references..
Mar 25 2023, 6:46 AM

Mar 24 2023

jkoshy committed rG047ce3db9776: pmcstat: Warn about text output format stability. (authored by jkoshy).
pmcstat: Warn about text output format stability.
Mar 24 2023, 6:47 PM
jkoshy closed D39249: pmcstat: Warn about text output format stability..
Mar 24 2023, 6:47 PM
jkoshy requested review of D39249: pmcstat: Warn about text output format stability..
Mar 24 2023, 9:42 AM

Feb 24 2023

jkoshy committed rG163dd260e3cb: Add gnn@ as my mentor. (authored by jkoshy).
Add gnn@ as my mentor.
Feb 24 2023, 9:44 PM
jkoshy closed D38673: Add gnn@ as my mentor..
Feb 24 2023, 9:44 PM