Page MenuHomeFreeBSD
Differential D59895

lib/msun: add LoongArch support
Needs ReviewPublic
Actions

Authored by zhaoxiaoqiang007_gmail.com on Tue, Sep 22, 2:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 13, 10:00 AM
Unknown Object (File)
Mon, Oct 12, 5:11 PM
Unknown Object (File)
Sat, Oct 10, 4:40 PM
Unknown Object (File)
Wed, Oct 7, 4:58 AM
Unknown Object (File)
Mon, Oct 5, 12:29 AM
Unknown Object (File)
Sat, Oct 3, 8:00 PM
Unknown Object (File)
Sat, Oct 3, 12:32 PM
Unknown Object (File)
Fri, Oct 2, 8:13 PM
View All 38 Files
Subscribers
gehaowu_bitmoe.com
imp
shipujin.t_gmail.com
zishun.yi.dev_gmail.com

Details

Reviewers
jkoshy
kib
imp
shipujin.t_gmail.com
Summary

Add the fenv implementation and build glue, and mark the known
long-double test failures as expected on loongarch.

Signed-off-by: Xiaoqiang Zhao <zhaoxiaoqiang007@gmail.com>
Signed-off-by: yu shan wei <mpysw@vip.163.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77175
Build 74058: arc lint + arc unit

Event Timeline

zhaoxiaoqiang007_gmail.com created this revision.Tue, Sep 22, 2:24 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 22, 2:24 PM
zhaoxiaoqiang007_gmail.com requested review of this revision.Tue, Sep 22, 2:24 PM
Harbormaster completed remote builds in B77175: Diff 187413.Tue, Sep 22, 2:24 PM
zhaoxiaoqiang007_gmail.com added a parent revision: D59894: libsys: add LoongArch support.Tue, Sep 22, 2:24 PM
zhaoxiaoqiang007_gmail.com added a child revision: D59896: libproc: add LoongArch support.
zishun.yi.dev_gmail.com added a subscriber: zishun.yi.dev_gmail.com.Tue, Sep 22, 2:42 PM
gehaowu_bitmoe.com added a subscriber: gehaowu_bitmoe.com.Tue, Sep 22, 8:47 PM
jkoshy added a reviewer: jkoshy.Wed, Sep 23, 8:13 AM
zhaoxiaoqiang007_gmail.com added reviewers: kib, imp.Wed, Sep 23, 8:17 AM
shipujin.t_gmail.com added a subscriber: shipujin.t_gmail.com.Fri, Sep 25, 8:01 AM
shipujin.t_gmail.com added inline comments.
lib/msun/loongarch/fenv.h
198

fadd.d $f0,$f0,$f assumes $f0+$f0 is exact, but LoongArch ELF ABI Table 2 ($fa0, "Preserved across calls: No") leaves $f0 an unspecified caller residue — verified: stale DBL_MAX makes feraise(FE_INEXACT) set OVERFLOW (0x50000), worst case spurious SIGFPE and Cause overwritten (Vol 1 Table 3-3). Trigger idea is right per §3.2.4.5; zero scratch first (change,verified).

Suggested change to:

	__asm __volatile("movgr2fr.d $f0, $zero\n\tfadd.d $f0,$f0,$f0" : : : "$f0");

https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html#_register_convention

shipujin.t_gmail.com added a reviewer: shipujin.t_gmail.com.Sat, Oct 17, 1:07 AM

Revision Contents
Changeset List

PathSize
lib/
msun/
loongarch/
2 lines
11 lines
361 lines
124 lines
tests/
2 lines
4 lines
4 lines
2 lines
2 lines
6 lines
2 lines

Diff 187413

View Options

lib/msun/loongarch/Makefile.inc

Loading...
View Options

lib/msun/loongarch/Symbol.map

Loading...
View Options

lib/msun/loongarch/fenv.h

Loading...
View Options

lib/msun/loongarch/fenv.c

Loading...
View Options

lib/msun/tests/exponential_test.c

Loading...
View Options

lib/msun/tests/fma_test.c

Loading...
View Options

lib/msun/tests/invtrig_test.c

Loading...
View Options

lib/msun/tests/logarithm_test.c

Loading...
View Options

lib/msun/tests/lrint_test.c

Loading...
View Options

lib/msun/tests/next_test.c

Loading...
View Options

lib/msun/tests/trig_test.c

Loading...