lib/csu: add LoongArch support
Needs ReviewPublic
Actions

Authored by zhaoxiaoqiang007_gmail.com on Tue, Sep 22, 2:23 PM.

Details

Reviewers

kib
imp
dchagin

Summary

crt1/crti/crtn and self-relocation for LoongArch.

Signed-off-by: Xiaoqiang Zhao <zhaoxiaoqiang007@gmail.com>
Signed-off-by: yu shan wei <mpysw@vip.163.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77172
Build 74055: arc lint + arc unit

Event Timeline

zhaoxiaoqiang007_gmail.com created this revision.Tue, Sep 22, 2:23 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Sep 22, 2:23 PM

zhaoxiaoqiang007_gmail.com requested review of this revision.Tue, Sep 22, 2:23 PM

Harbormaster completed remote builds in B77172: Diff 187410.Tue, Sep 22, 2:23 PM

zhaoxiaoqiang007_gmail.com added a parent revision: D59891: build: add LoongArch build infrastructure.Tue, Sep 22, 2:23 PM

zhaoxiaoqiang007_gmail.com added a child revision: D59893: libc: add LoongArch support.

zishun.yi.dev_gmail.com added a subscriber: zishun.yi.dev_gmail.com.Tue, Sep 22, 2:41 PM

gehaowu_bitmoe.com added a subscriber: gehaowu_bitmoe.com.Tue, Sep 22, 8:47 PM

zhaoxiaoqiang007_gmail.com added reviewers: kib, imp, dchagin.Wed, Sep 23, 8:11 AM

A few high-level comments.

These files contain $FreeBSD$ which should is long obsolete and should never be present.

As with @imp's comments on D59893, the bringing over the copyrights and acknowledgements is questionable.

Please don't implement crti and crtn. The _init and _fini functions are obsolete and should not be supported in new architectures. IMO it was an error to have added support to RISC-V.

In D59892#1375242, @brooks wrote:

A few high-level comments.

These files contain $FreeBSD$ which should is long obsolete and should never be present.

As with @imp's comments on D59893, the bringing over the copyrights and acknowledgements is questionable.

Please don't implement crti and crtn. The _init and _fini functions are obsolete and should not be supported in new architectures. IMO it was an error to have added support to RISC-V.