Differential D59889
loader: add LoongArch EFI loader support Authored by zhaoxiaoqiang007_gmail.com on Tue, Sep 22, 2:23 PM. Tags None Referenced Files
Details Add LoongArch support to the EFI loader: loader/arch/loongarch Clang FreeBSD target for LoongArch is landed upstream after clang 20.1.0, Signed-off-by: Xiaoqiang Zhao <zhaoxiaoqiang007@gmail.com>
Diff Detail
Event TimelineComment Actions This is cool! I'd love to take it for a test-spin!
Comment Actions Thanks for reviewing! I think I need to figure out how to write this test script ;-) 1. build kernelMAKEOBJDIRPREFIX=/home/hitmoon/fb16 \ MK_TOOLCHAIN=no \ MK_WERROR=no \ MK_BOOT=yes \ TARGET=loongarch TARGET_ARCH=loongarch64 KERNCONF=QEMU make kernel-toolchain NOCLEAN=yes -j10 MAKEOBJDIRPREFIX=/home/hitmoon/fb16 \ MK_TOOLCHAIN=no \ MK_WERROR=no \ MK_BOOT=yes \ TARGET=loongarch TARGET_ARCH=loongarch64 KERNCONF=QEMU make buildkernel -j10 2. build worldMAKEOBJDIRPREFIX=/home/hitmoon/fb16 \ MK_TOOLCHAIN=no \ MK_WERROR=no \ MK_BOOT=yes \ MK_RESCUE=no \ TARGET=loongarch TARGET_ARCH=loongarch64 make buildworld -j10 3. make qemu imageTARGET=loongarch
TARGET_ARCH=loongarch64
SRCTOP=/home/hitmoon/fb16_loongarch
OBJTOP=/home/hitmoon/fb16/home/hitmoon/fb16_loongarch/loongarch.loongarch64
STAGE=/home/hitmoon/fb16-stage
IMG=/home/hitmoon/loongarch64.img
MAKEOBJDIRPREFIX=/home/hitmoon/fb16
# --- Step 1: installworld + installkernel into staging dir ---
echo "==> Installing world into ${STAGE} ..."
# Clean staging dir
if [ -d "${STAGE}" ]; then
chflags -R noschg "${STAGE}" 2>/dev/null || true
rm -rf "${STAGE}"
fi
mkdir -p "${STAGE}"
cd ${SRCTOP}
MAKEOBJDIRPREFIX=${MAKEOBJDIRPREFIX} \
MK_TOOLCHAIN=no \
MK_WERROR=no \
MK_BOOT=yes \
MK_RESCUE=no \
TARGET=${TARGET} TARGET_ARCH=${TARGET_ARCH} \
DESTDIR=${STAGE} \
NO_ROOT=yes \
make installworld distribution
echo "==> Installing kernel ..."
MAKEOBJDIRPREFIX=${MAKEOBJDIRPREFIX} \
MK_TOOLCHAIN=no \
MK_WERROR=no \
MK_BOOT=yes \
MK_RESCUE=no \
TARGET=${TARGET} TARGET_ARCH=${TARGET_ARCH} \
DESTDIR=${STAGE} \
KERNCONF=QEMU \
NO_ROOT=yes \
make installkernel
# --- Step 1.5: site customization (rc.conf, sshd root login, root password) ---
echo "==> Writing /etc/rc.conf ..."
cat > ${STAGE}/etc/rc.conf <<'EOF'
hostname="loong"
ifconfig_vtnet0="DHCP"
sshd_enable="YES"
EOF
echo "==> Enabling root login in /etc/ssh/sshd_config ..."
# The stock sshd_config has "#PermitRootLogin ..." commented out; append an
# uncommented directive (sshd uses the first uncommented occurrence).
echo "PermitRootLogin yes" >> ${STAGE}/etc/ssh/sshd_config
echo "==> Setting root password ..."
# SHA-512 crypt hash of "freebsd" (openssl passwd -6 -salt loongsalt freebsd).
ROOT_HASH='$6$loongsalt$8pil6bJ4atMUDICBnyn5Txgtjpa9SbOYMGY5fU8fROzCXLZ69.mYdRXx7bWuPx4/bH2/u4Nc0yJHWMrWW21v8.'
sed -i '' "s|^root:[^:]*:|root:${ROOT_HASH}:|" ${STAGE}/etc/master.passwd
# -d sets the output directory for pwd.db/spwd.db (default /etc); use the
# staging /etc so the distribution's locked-root databases are overwritten.
pwd_mkdb -d ${STAGE}/etc ${STAGE}/etc/master.passwd
# --- Step 1.6: /boot/loader.conf ---
echo "==> Writing /boot/loader.conf ..."
cat > ${STAGE}/boot/loader.conf <<'EOF'
#kern.maxcpus=1
#vm.memguard.frequency="0"
debug.vmmap_check=2
autoboot_delay="5"
EOF
cat > ${STAGE}/root/t.sh << EOF
kyua test -k /usr/tests/Kyuafile
EOF
# --- Step 2: Create EFI partition contents ---
echo "==> Preparing EFI partition ..."
# Find the EFI loader
EFI_LOADER=$(find ${OBJTOP}/stand/efi -name loader_lua.efi -type f 2>/dev/null | head -1)
if [ -z "${EFI_LOADER}" ]; then
echo "WARNING: EFI loader not found, trying alternative locations ..."
EFI_LOADER=$(find ${OBJTOP} -path '*/efi/*loader*.efi' -type f 2>/dev/null | head -1)
fi
if [ -z "${EFI_LOADER}" ]; then
echo "ERROR: Cannot find EFI loader. Build stand/ first."
echo " Run: cd ${SRCTOP} && ./bl2-qemu.sh"
exit 1
fi
echo " EFI loader: ${EFI_LOADER}"
ESP_DIR=/tmp/esp.$$
rm -rf ${ESP_DIR}
mkdir -p ${ESP_DIR}/EFI/BOOT
cp ${EFI_LOADER} ${ESP_DIR}/EFI/BOOT/BOOTLOONGARCH64.EFI
# --- Step 3: Create filesystem images ---
echo "==> Creating UFS root filesystem image ..."
# Build the rootfs from METALOG (manifest mode): ownership comes from
# the manifest (root:wheel), not the on-disk staging tree, which is
# owned by the build user under -DNO_ROOT.
# Record the files created by this script (install(1) does not know
# about them). -D below tolerates duplicates.
for f in ./etc/rc.conf ./boot/loader.conf ./root/t.sh ; do
printf '%s type=file uname=root gname=wheel mode=0644\n' ${f} >> ${STAGE}/METALOG
done
# Sort: makefs needs directory entries before their contents, else
# directories get mode 000.
env -i LC_COLLATE=C sort -u ${STAGE}/METALOG > ${STAGE}/METALOG.sorted
mv ${STAGE}/METALOG.sorted ${STAGE}/METALOG
ROOTFS=/tmp/rootfs.$$.img
(cd ${STAGE} && makefs -B little -s 4g -D -N ./etc -o label=root ${ROOTFS} ./METALOG)
echo "==> Creating ESP (FAT) image ..."
ESPFS=/tmp/esp.$$.img
makefs -t msdos -s 64m ${ESPFS} ${ESP_DIR}
# --- Step 4: Assemble disk image ---
echo "==> Assembling disk image ..."
mkimg -s gpt \
-p efi:=${ESPFS} \
-p freebsd-ufs:=${ROOTFS} \
-o ${IMG}
# Cleanup
rm -rf ${ESP_DIR} ${ROOTFS} ${ESPFS}
echo ""
echo "============================================================"
echo "==> Done: ${IMG}"
ls -lh ${IMG}4. run in qemu ( version 10.0 or higher is preferred)default root password is: freebsd qemu-system-loongarch64 -M virt -smp 8 -m 8G \ -cpu la464,ptw=on \ -drive if=pflash,format=raw,readonly=on,file=/usr/share/edk2/loongarch64/QEMU_EFI.fd \ -drive if=pflash,format=raw,file=/usr/share/edk2/loongarch64/QEMU_VARS.fd \ -drive if=none,file=loongarch64.img,format=raw,id=rootfs \ -device virtio-blk-pci,drive=rootfs,disable-legacy=on,disable-modern=off,ioeventfd=off \ -device virtio-rng-pci \ -netdev user,id=net0,hostfwd=tcp::5588-:22 \ -device virtio-net-pci,netdev=net0 \ -nographic \ -serial stdio \ -monitor telnet::4444,server,nowait \ -qmp unix:/tmp/qmp.sock,server,nowait $@ Comment Actions It is suggested to remove it so that FP save/restore only covers $fs0–$fs7, consistent with the LoongArch-ELF-ABI Register Convention and other FreeBSD architectures. $fcsr0 is not in any callee-saved list, so an ordinary function call does not guarantee that it is preserved across calls. FreeBSD's _setjmp/_longjmp traditionally restores only the callee-saved registers, $ra, $sp, and the signal mask of setjmp; also saving the caller-saved $fcsr0 goes beyond this convention. LoongArch ELF ABI: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html (see the "Register Convention" section).
Comment Actions This HOB FDT fallback functionality is useful for both LoongArch and ArmVirt (as is also explicitly noted in the code comments), and it is not LoongArch-specific logic. It is suggested to split it out from the LoongArch port patch set and submit it separately as a standalone . This way:
Comment Actions MP Service Protocol query serves no real purpose, suggested to remove. This code retrieves and prints the CPU count, but it has no actual impact on the boot flow. It introduces unnecessary dependencies on <Protocol/MpService.h> and <Pi/PiMultiPhase.h>. If the MP Service Protocol is needed for multicore startup, it should be used where the CPUs are actually woken up, rather than being queried in exec() just for printing.
Comment Actions Passing entry itself and kernend to the kernel via registers is a custom ABI. If the kernel needs this information, it should obtain it from the modulep metadata (FreeBSD already has mechanisms such as MODINFOMD_KERNEND and MODINFOMD_MODULEP), rather than breaking cross-architecture consistency.
Comment Actions Much thanks!
Comment Actions dev_cleanup() must be called before bi_load(). dev_cleanup() must be called before bi_load(), because bi_load() internally calls ExitBootServices(), after which the Boot Service Protocols are no longer valid, and neither dev_cleanup() nor printf() can be used anymore.
Comment Actions It is suggested to use designated initializers for the struct file_format initialization.
Comment Actions Redundant includes and extern declaration.
This comment was removed by shipujin.t_gmail.com.
Comment Actions It is suggested to remove the explicitly defined setcommand_set and set_Xficl_compile_set output sections, and just retain them via objcopy -j.
Comment Actions Conduct code review
Comment Actions code review
Comment Actions
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||