Page MenuHomeFreeBSD
Differential D40544

hwpmc: add error for HWPMC_DEBUG without KTR
ClosedPublic
Actions

Authored by mhorne on Jun 14 2023, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 21, 9:40 AM
Unknown Object (File)
Sun, May 17, 10:56 PM
Unknown Object (File)
Wed, May 13, 9:41 PM
Unknown Object (File)
Wed, May 13, 9:41 PM
Unknown Object (File)
Wed, May 13, 9:32 PM
Unknown Object (File)
Tue, Apr 28, 8:12 PM
Unknown Object (File)
Tue, Apr 28, 8:07 PM
Unknown Object (File)
Mon, Apr 27, 6:57 PM
View All Files
Subscribers
imp

Details

Reviewers
jkoshy
emaste
Group Reviewers
pmc
Commits
rG3c4860d3eeed: hwpmc: add error for HWPMC_DEBUG without KTR
rG569f89b2f442: hwpmc: add error for HWPMC_DEBUG without KTR
Summary

The option is a no-op otherwise, but this is not necessarily obvious.
Failing the compile gives the user a hint.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Jun 14 2023, 5:58 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 14 2023, 5:58 PM
mhorne requested review of this revision.Jun 14 2023, 5:58 PM
mhorne added a parent revision: D40543: pmc: clarify and strengthen statements about API/ABI.
Harbormaster completed remote builds in B52057: Diff 123241.Jun 14 2023, 5:58 PM
mhorne added a child revision: D40545: hwpmc(4): document debugging options.Jun 14 2023, 5:58 PM
emaste added a comment.Jun 14 2023, 8:14 PM

It might be worth putting a comment in the src as well mentioning that HWPMC_DEBUG alone will compile but have no effect.

emaste accepted this revision.Jun 14 2023, 8:14 PM
This revision is now accepted and ready to land.Jun 14 2023, 8:14 PM
jkoshy accepted this revision.Jun 16 2023, 4:05 AM
Closed by commit rG569f89b2f442: hwpmc: add error for HWPMC_DEBUG without KTR (authored by mhorne). · Explain WhyJun 16 2023, 4:45 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG569f89b2f442: hwpmc: add error for HWPMC_DEBUG without KTR.
mhorne added a commit: rG3c4860d3eeed: hwpmc: add error for HWPMC_DEBUG without KTR.Jul 17 2023, 4:49 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
6 lines

Diff 123348

View Options

sys/sys/pmc.h

Loading...