Page MenuHomeFreeBSD

hpwmc_amd.c: style improvements
ClosedPublic

Authored by mhorne on Aug 1 2023, 4:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 6:09 PM
Unknown Object (File)
Sun, Nov 17, 4:16 PM
Unknown Object (File)
Tue, Nov 12, 1:44 AM
Unknown Object (File)
Oct 12 2024, 2:36 PM
Unknown Object (File)
Oct 12 2024, 2:36 PM
Unknown Object (File)
Oct 12 2024, 12:37 PM
Unknown Object (File)
Oct 1 2024, 2:50 PM
Unknown Object (File)
Sep 23 2024, 4:27 PM
Subscribers

Details

Summary
  • Return style
  • Explicit value checks
  • Whitespace formatting
  • Comment formatting
  • Local variable declaration order
  • __unused annotations

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne requested review of this revision.Aug 1 2023, 4:23 PM
sys/dev/hwpmc/hwpmc_amd.c
883

This snuck in; fixed locally.

jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_amd.c
981

Add a comment about this being the __i386__ case?

This revision is now accepted and ready to land.Aug 3 2023, 6:00 PM
sys/dev/hwpmc/hwpmc_amd.c
981

The ifdef gets removed in D41274, so I really have no idea why I bothered touching these lines. I'll drop this hunk of the diff before pushing.

This revision was automatically updated to reflect the committed changes.