Page MenuHomeFreeBSD
Differential D41272

hpwmc_amd.c: style improvements
ClosedPublic
Actions

Authored by mhorne on Aug 1 2023, 4:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 26, 3:34 PM
Unknown Object (File)
Fri, Aug 14, 10:33 PM
Unknown Object (File)
Wed, Aug 12, 10:01 PM
Unknown Object (File)
Sat, Aug 8, 6:29 PM
Unknown Object (File)
Sat, Aug 8, 1:57 PM
Unknown Object (File)
Sat, Aug 8, 1:27 PM
Unknown Object (File)
Sun, Aug 2, 4:59 AM
Unknown Object (File)
Sun, Aug 2, 1:13 AM
View All Files
Subscribers
imp

Details

Reviewers
jkoshy
gnn
Group Reviewers
pmc
Commits
rGd9e3fe322662: hpwmc_amd.c: style improvements
Summary
  • Return style
  • Explicit value checks
  • Whitespace formatting
  • Comment formatting
  • Local variable declaration order
  • __unused annotations

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Aug 1 2023, 4:23 PM
Herald added a reviewer: gnn. · View Herald TranscriptAug 1 2023, 4:23 PM
Herald added a subscriber: imp. · View Herald Transcript
mhorne requested review of this revision.Aug 1 2023, 4:23 PM
Harbormaster completed remote builds in B52930: Diff 125426.Aug 1 2023, 4:23 PM
mhorne added a parent revision: D41271: hwpmc_core: remove two non-existent function prototypes.Aug 1 2023, 4:23 PM
mhorne added a child revision: D41273: hwpmc_amd: simplify counter descriptor definitions.
mhorne added inline comments.Aug 1 2023, 4:27 PM
sys/dev/hwpmc/hwpmc_amd.c
883

This snuck in; fixed locally.

jkoshy accepted this revision.Aug 3 2023, 6:00 PM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_amd.c
981

Add a comment about this being the __i386__ case?

This revision is now accepted and ready to land.Aug 3 2023, 6:00 PM
mhorne added inline comments.Aug 4 2023, 1:38 PM
sys/dev/hwpmc/hwpmc_amd.c
981

The ifdef gets removed in D41274, so I really have no idea why I bothered touching these lines. I'll drop this hunk of the diff before pushing.

Closed by commit rGd9e3fe322662: hpwmc_amd.c: style improvements (authored by mhorne). · Explain WhyOct 18 2023, 6:06 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rGd9e3fe322662: hpwmc_amd.c: style improvements.

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
280 lines

Diff 129036

View Options

sys/dev/hwpmc/hwpmc_amd.c

Loading...