Page MenuHomeFreeBSD
Differential D41268

hwpmc_arm64: plug memory leak
ClosedPublic
Actions

Authored by mhorne on Aug 1 2023, 4:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 8:41 AM
Unknown Object (File)
Fri, Nov 22, 12:33 AM
Unknown Object (File)
Wed, Nov 13, 8:23 PM
Unknown Object (File)
Tue, Nov 12, 1:35 AM
Unknown Object (File)
Oct 13 2024, 2:40 AM
Unknown Object (File)
Oct 13 2024, 2:11 AM
Unknown Object (File)
Oct 13 2024, 2:11 AM
Unknown Object (File)
Oct 13 2024, 2:10 AM
View All 47 Files
Subscribers
emaste
imp

Details

Reviewers
jkoshy
andrew
gnn
Group Reviewers
pmc
Commits
rGdd70f2b48c9c: hwpmc_arm64: plug memory leak
rG8bdceaecabd9: hwpmc_arm64: plug memory leak
Summary

Free allocated per-CPU structures in the pcpu_fini and finalize methods.

While here, add debug trace entries to these methods.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Aug 1 2023, 4:22 PM
Herald added a reviewer: andrew. · View Herald TranscriptAug 1 2023, 4:22 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: gnn. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
mhorne requested review of this revision.Aug 1 2023, 4:22 PM
Harbormaster completed remote builds in B52926: Diff 125422.Aug 1 2023, 4:22 PM
mhorne added a child revision: D41269: hwpmc_armv7: plug memory leak.Aug 1 2023, 4:22 PM
mhorne added inline comments.Aug 1 2023, 4:33 PM
sys/dev/hwpmc/hwpmc_arm64.c
453

FYI this just makes it consistent with the trace entry I am adding. There is no need to encode cpu in the message, as every ktr record contains this value, and it is always true that cpu == curcpu for this function.

andrew added inline comments.Aug 1 2023, 6:08 PM
sys/dev/hwpmc/hwpmc_arm64.c
496–498

I think this would be safer if we moved it after disabling the PMC.

mhorne updated this revision to Diff 125443.Aug 1 2023, 7:06 PM
mhorne marked an inline comment as done.

Adjust order of operations.

Harbormaster completed remote builds in B52941: Diff 125443.Aug 1 2023, 7:07 PM
andrew accepted this revision.Aug 1 2023, 7:50 PM
This revision is now accepted and ready to land.Aug 1 2023, 7:50 PM
jkoshy accepted this revision.Aug 2 2023, 7:12 PM
Closed by commit rG8bdceaecabd9: hwpmc_arm64: plug memory leak (authored by mhorne). · Explain WhyAug 3 2023, 2:13 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG8bdceaecabd9: hwpmc_arm64: plug memory leak.
mhorne added a commit: rGdd70f2b48c9c: hwpmc_arm64: plug memory leak.Sep 11 2023, 10:44 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
10 lines

Diff 125503

View Options

sys/dev/hwpmc/hwpmc_arm64.c

Loading...