Page MenuHomeFreeBSD
Differential D41269

hwpmc_armv7: plug memory leak
ClosedPublic
Actions

Authored by mhorne on Aug 1 2023, 4:22 PM.
Tags
None
Referenced Files
F132429590: D41269.id125444.diff
Thu, Oct 16, 9:07 PM
Unknown Object (File)
Tue, Oct 14, 6:45 AM
Unknown Object (File)
Mon, Oct 13, 3:54 AM
Unknown Object (File)
Mon, Oct 13, 3:54 AM
Unknown Object (File)
Mon, Oct 13, 3:54 AM
Unknown Object (File)
Sun, Oct 12, 4:06 PM
Unknown Object (File)
Sun, Oct 12, 5:44 AM
Unknown Object (File)
Fri, Oct 10, 2:22 AM
View All Files
Subscribers
imp

Details

Reviewers
jkoshy
andrew
gnn
Group Reviewers
pmc
Commits
rG9f66a42db74e: hwpmc_armv7: plug memory leak
rG9c0a2d522f3a: hwpmc_armv7: plug memory leak
Summary

Free allocated per-CPU structures in the pcpu_fini and finalize methods.

While here, add debug trace entries to these methods.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Aug 1 2023, 4:22 PM
Herald added a reviewer: andrew. · View Herald TranscriptAug 1 2023, 4:22 PM
Herald added a reviewer: gnn. · View Herald Transcript
Herald added a subscriber: imp. · View Herald Transcript
mhorne requested review of this revision.Aug 1 2023, 4:22 PM
Harbormaster completed remote builds in B52927: Diff 125423.Aug 1 2023, 4:22 PM
mhorne added a parent revision: D41268: hwpmc_arm64: plug memory leak.Aug 1 2023, 4:22 PM
mhorne added a child revision: D41270: hwpmc: tidy pcd_finalize methods.
mhorne updated this revision to Diff 125444.Aug 1 2023, 7:07 PM

Adjust order of operations.

Harbormaster completed remote builds in B52942: Diff 125444.Aug 1 2023, 7:07 PM
andrew accepted this revision.Aug 1 2023, 7:50 PM
This revision is now accepted and ready to land.Aug 1 2023, 7:50 PM
jkoshy accepted this revision.Aug 2 2023, 7:11 PM
Closed by commit rG9c0a2d522f3a: hwpmc_armv7: plug memory leak (authored by mhorne). · Explain WhyAug 3 2023, 2:14 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG9c0a2d522f3a: hwpmc_armv7: plug memory leak.
mhorne added a commit: rG9f66a42db74e: hwpmc_armv7: plug memory leak.Sep 11 2023, 10:44 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
10 lines

Diff 125504

View Options

sys/dev/hwpmc/hwpmc_armv7.c

Loading...