Page MenuHomeFreeBSD
Differential D58497

libelftc: Const correctness for C23
ClosedPublic
Actions

Authored by ivy on Mon, Jul 27, 11:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 3, 12:50 AM
Unknown Object (File)
Sat, Aug 1, 8:39 PM
Unknown Object (File)
Sat, Aug 1, 5:00 AM
Unknown Object (File)
Fri, Jul 31, 10:21 PM
Unknown Object (File)
Fri, Jul 31, 9:56 AM
Unknown Object (File)
Fri, Jul 31, 7:03 AM
Unknown Object (File)
Fri, Jul 31, 6:59 AM
Unknown Object (File)
Fri, Jul 31, 1:38 AM
View All 10 Files
Subscribers
imp
jkoshy_users.sourceforge.net

Details

Reviewers
jkoshy
mhorne
dim
markj
emaste
des
kevans
andrew
Commits
rG85b07e977b04: libelftc: Const correctness for C23
Summary

On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr()
now implements the C23 behaviour where passing a const pointer to
strchr() also returns a const pointer. This breaks libelftc during
the bootstrap build, since it assumes the return value is always
a mutable pointer.

Since the returned pointer is never modified in either case, make
it const.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy created this revision.Mon, Jul 27, 11:07 PM
Herald added a reviewer: andrew. · View Herald TranscriptMon, Jul 27, 11:07 PM
Herald added a subscriber: imp. · View Herald Transcript
ivy requested review of this revision.Mon, Jul 27, 11:07 PM
Harbormaster completed remote builds in B75192: Diff 182861.Mon, Jul 27, 11:07 PM
ivy added a comment.Mon, Jul 27, 11:07 PM

i think this should be upstreamed, but i'm not sure who's in charge of this -- @emaste?

markj accepted this revision.Mon, Jul 27, 11:09 PM
This revision is now accepted and ready to land.Mon, Jul 27, 11:09 PM
emaste accepted this revision.Tue, Jul 28, 12:27 AM
emaste added a subscriber: jkoshy_users.sourceforge.net.

I'll take care of upstreaming later on if jkoshy@ doesn't pick it up -- CC @jkoshy @jkoshy_users.sourceforge.net

dim accepted this revision.Tue, Jul 28, 5:25 PM

LGTM

jkoshy accepted this revision.Wed, Jul 29, 2:04 PM

LGTM.

@emaste, @ivy : I'll take care of folding it in upstream, thanks for the heads-up.

Closed by commit rG85b07e977b04: libelftc: Const correctness for C23 (authored by ivy). · Explain WhyMon, Aug 3, 2:31 PM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rG85b07e977b04: libelftc: Const correctness for C23.

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
libelftc/
3 lines
5 lines

Diff 183312

View Options

contrib/elftoolchain/libelftc/libelftc_dem_arm.c

Loading...
View Options

contrib/elftoolchain/libelftc/libelftc_dem_gnu2.c

Loading...