Differential D40514

hwpmc_mod.c: whitespace style cleanup
ClosedPublic
Actions

Authored by mhorne on Jun 13 2023, 5:46 PM.

Tags

None

Referenced Files

	F174326377: D40514.diff
	Fri, Oct 2, 10:18 AM

	Unknown Object (File)
	Wed, Sep 2, 3:25 PM

	Unknown Object (File)
	Sep 2 2026, 8:29 AM

	Unknown Object (File)
	Aug 21 2026, 10:21 PM

	Unknown Object (File)
	Aug 14 2026, 10:35 PM

	Unknown Object (File)
	Aug 12 2026, 10:03 PM

	Unknown Object (File)
	Aug 8 2026, 4:10 PM

	Unknown Object (File)
	Aug 8 2026, 10:58 AM

Subscribers

Details

Reviewers

jkoshy
gnn

Commits

rG693cd30797b8: hwpmc_mod.c: whitespace style cleanup

Summary

Handle a few things related to spacing:

Remove redundant/superfluous blank lines (and add a couple where helpful)
Add spacing around binary operators
Remove spacing after casts and before goto labels
Adjustments for line width of 80 chars
Tab/space character issues

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Jun 13 2023, 5:46 PM

Herald added a reviewer: gnn. · View Herald TranscriptJun 13 2023, 5:46 PM

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.Jun 13 2023, 5:46 PM

Harbormaster completed remote builds in B52023: Diff 123162.Jun 13 2023, 5:46 PM

mhorne added a parent revision: D40513: hwpmc_mod.c: return statement style.Jun 13 2023, 5:46 PM

jkoshy added inline comments.Jun 14 2023, 9:24 AM

sys/dev/hwpmc/hwpmc_mod.c
1792	Consider keeping this blank line, as it visually separates exit processing steps from the rest of the function?

jkoshy accepted this revision.Jun 14 2023, 9:42 AM

jkoshy added inline comments.

sys/dev/hwpmc/hwpmc_mod.c
4999	Consider keeping this blank line to preserve visual separation?
5327	Consider keeping this blank line, for better visual separation of exit processing from the rest of the function?

This revision is now accepted and ready to land.Jun 14 2023, 9:42 AM

Closed by commit rG693cd30797b8: hwpmc_mod.c: whitespace style cleanup (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM

This revision was automatically updated to reflect the committed changes.

mhorne marked 3 inline comments as done.

mhorne added a commit: rG693cd30797b8: hwpmc_mod.c: whitespace style cleanup.

mhorne mentioned this in D40289: hwpmc: style(9) pass of hwpmc_mod.c.Jun 14 2023, 4:49 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

460 lines

Diff 123225

sys/dev/hwpmc/hwpmc_mod.c

Loading...