Differential D40293

hwpmc: split out PMC_OP_PMCRELEASE
ClosedPublic
Actions

Authored by mhorne on May 26 2023, 6:40 PM.

Tags

None

Referenced Files

	F132291532: D40293.id.diff
	Wed, Oct 15, 2:20 PM

	F132291530: D40293.id122495.diff
	Wed, Oct 15, 2:20 PM

	F132291529: D40293.id122722.diff
	Wed, Oct 15, 2:20 PM

	F132291527: D40293.id123232.diff
	Wed, Oct 15, 2:20 PM

	F132291525: D40293.diff
	Wed, Oct 15, 2:20 PM

	F132244164: D40293.diff
	Wed, Oct 15, 3:29 AM

	Unknown Object (File)
	Tue, Oct 14, 7:44 PM

	Unknown Object (File)
	Mon, Oct 13, 6:36 AM

Subscribers

Details

Reviewers

jkoshy
emaste
gnn

Group Reviewers

Commits

rGf4fac946c6a5: hwpmc: split out PMC_OP_PMCRELEASE

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.May 26 2023, 6:40 PM

Herald added a reviewer: gnn. · View Herald TranscriptMay 26 2023, 6:40 PM

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.May 26 2023, 6:40 PM

Harbormaster completed remote builds in B51721: Diff 122495.May 26 2023, 6:40 PM

mhorne added a parent revision: D40292: hwpmc: split out PMC_OP_PMCALLOCATE.May 26 2023, 6:40 PM

mhorne added a child revision: D40294: hwpmc: split out PMC_OP_PMCRW.

jkoshy requested changes to this revision.May 31 2023, 6:55 AM

jkoshy added inline comments.

sys/dev/hwpmc/hwpmc_mod.c
3648	How about returning early in case of an error? Doing so would be consistent with the way errors are handled in other parts of the code. error = pmc_find_pmc(...) if (error != 0) return (error);

This revision now requires changes to proceed.May 31 2023, 6:55 AM

Adjust error handling to return directly.

Harbormaster completed remote builds in B51842: Diff 122722.Jun 1 2023, 6:18 PM

mhorne marked an inline comment as done.Jun 1 2023, 6:18 PM

mhorne added inline comments.

sys/dev/hwpmc/hwpmc_mod.c
3648	Sure thing. Not sure why I structured this one this way...

jkoshy accepted this revision.Jun 2 2023, 8:47 PM

This revision is now accepted and ready to land.Jun 2 2023, 8:47 PM

Closed by commit rGf4fac946c6a5: hwpmc: split out PMC_OP_PMCRELEASE (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM

This revision was automatically updated to reflect the committed changes.

mhorne marked an inline comment as done.

mhorne added a commit: rGf4fac946c6a5: hwpmc: split out PMC_OP_PMCRELEASE.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

66 lines

Diff 123232

sys/dev/hwpmc/hwpmc_mod.c

Loading...