Page MenuHomeFreeBSD

hwpmc: split out PMC_OP_PMCRELEASE
ClosedPublic

Authored by mhorne on May 26 2023, 6:40 PM.
Tags
None
Referenced Files
F132209642: D40293.id122722.diff
Tue, Oct 14, 7:44 PM
Unknown Object (File)
Mon, Oct 13, 6:36 AM
Unknown Object (File)
Sun, Oct 12, 3:16 AM
Unknown Object (File)
Wed, Oct 1, 12:49 PM
Unknown Object (File)
Mon, Sep 29, 10:48 PM
Unknown Object (File)
Mon, Sep 29, 6:11 AM
Unknown Object (File)
Sun, Sep 28, 8:15 AM
Unknown Object (File)
Sun, Sep 28, 6:35 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jkoshy requested changes to this revision.May 31 2023, 6:55 AM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3648

How about returning early in case of an error? Doing so would be consistent with the way errors
are handled in other parts of the code.

error = pmc_find_pmc(...)
if (error != 0)
   return (error);
This revision now requires changes to proceed.May 31 2023, 6:55 AM

Adjust error handling to return directly.

mhorne added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3648

Sure thing. Not sure why I structured this one this way...

This revision is now accepted and ready to land.Jun 2 2023, 8:47 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.