Page MenuHomeFreeBSD

hwpmc: split out PMC_OP_PMCRELEASE
ClosedPublic

Authored by mhorne on May 26 2023, 6:40 PM.
Tags
None
Referenced Files
F132291532: D40293.id.diff
Wed, Oct 15, 2:20 PM
F132291530: D40293.id122495.diff
Wed, Oct 15, 2:20 PM
F132291529: D40293.id122722.diff
Wed, Oct 15, 2:20 PM
F132291527: D40293.id123232.diff
Wed, Oct 15, 2:20 PM
F132291525: D40293.diff
Wed, Oct 15, 2:20 PM
F132244164: D40293.diff
Wed, Oct 15, 3:29 AM
Unknown Object (File)
Tue, Oct 14, 7:44 PM
Unknown Object (File)
Mon, Oct 13, 6:36 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jkoshy requested changes to this revision.May 31 2023, 6:55 AM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3648

How about returning early in case of an error? Doing so would be consistent with the way errors
are handled in other parts of the code.

error = pmc_find_pmc(...)
if (error != 0)
   return (error);
This revision now requires changes to proceed.May 31 2023, 6:55 AM

Adjust error handling to return directly.

mhorne added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
3648

Sure thing. Not sure why I structured this one this way...

This revision is now accepted and ready to land.Jun 2 2023, 8:47 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.