hwpmc: split out PMC_OP_PMCALLOCATE
ClosedPublic
Actions

Authored by mhorne on May 26 2023, 6:39 PM.

Details

Reviewers

jkoshy
emaste
gnn

Group Reviewers

pmc

Commits

rGc514a571af74: hwpmc: split out PMC_OP_PMCALLOCATE

Summary

This is the biggest one.

Flip the return values of the pmc_can_allocate_row() and
pmc_can_allocate_rowindex() functions to boolean types, like their
naming implies. We weren't actually using the error codes they were
returning.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.May 26 2023, 6:39 PM

Herald added a reviewer: gnn. · View Herald TranscriptMay 26 2023, 6:39 PM

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.May 26 2023, 6:39 PM

Harbormaster completed remote builds in B51720: Diff 122494.May 26 2023, 6:39 PM

mhorne added a parent revision: D40291: hwpmc: split out PMC_OP_PMCATTACH/PMC_OP_PMCDETACH.May 26 2023, 6:39 PM

mhorne added a child revision: D40293: hwpmc: split out PMC_OP_PMCRELEASE.

jkoshy accepted this revision.Jun 13 2023, 7:18 AM

jkoshy added inline comments.

sys/dev/hwpmc/hwpmc_mod.c
3462	Setting `pmc` to `NULL` seems redundant.

This revision is now accepted and ready to land.Jun 13 2023, 7:18 AM

Closed by commit rGc514a571af74: hwpmc: split out PMC_OP_PMCALLOCATE (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM

This revision was automatically updated to reflect the committed changes.

mhorne marked an inline comment as done.

mhorne added a commit: rGc514a571af74: hwpmc: split out PMC_OP_PMCALLOCATE.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

hwpmc_mod.c

521 lines

Diff 123231

View Options

hwpmc: split out PMC_OP_PMCALLOCATEClosedPublicActions