Paths

Table of Contentst

Differential D40294

hwpmc: split out PMC_OP_PMCRW
ClosedPublic
Actions

Authored by mhorne on May 26 2023, 6:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 9:30 PM

	Unknown Object (File)
	Wed, Sep 2, 7:56 AM

	Unknown Object (File)
	Wed, Sep 2, 7:31 AM

	Unknown Object (File)
	Wed, Sep 2, 6:35 AM

	Unknown Object (File)
	Wed, Sep 2, 1:56 AM

	Unknown Object (File)
	Tue, Sep 1, 10:04 PM

	Unknown Object (File)
	Fri, Aug 28, 1:55 PM

	Unknown Object (File)
	Fri, Aug 28, 1:10 PM

Subscribers

Details

Reviewers

jkoshy
emaste
gnn

Group Reviewers

Commits

rG93fe5909babb: hwpmc: split out PMC_OP_PMCRW

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.May 26 2023, 6:40 PM

Herald added a reviewer: gnn. · View Herald TranscriptMay 26 2023, 6:40 PM

Herald added a subscriber: imp. · View Herald Transcript

mhorne requested review of this revision.May 26 2023, 6:40 PM

Harbormaster completed remote builds in B51722: Diff 122496.May 26 2023, 6:40 PM

mhorne added a parent revision: D40293: hwpmc: split out PMC_OP_PMCRELEASE.May 26 2023, 6:40 PM

jkoshy requested changes to this revision.May 31 2023, 6:48 AM

jkoshy added inline comments.

sys/dev/hwpmc/hwpmc_mod.c
3663	Argument `prw` is being passed by value so the `const` is redundant. How about using a `const` pointer here instead (`const struct pmc_op_pmcrw *prw`)?
4371–4372	We could move this line closer to where 'pprw' gets used?

This revision now requires changes to proceed.May 31 2023, 6:48 AM

Handle review comments.

Harbormaster completed remote builds in B51843: Diff 122723.Jun 1 2023, 6:19 PM

jkoshy accepted this revision.Jun 2 2023, 8:53 PM

This revision is now accepted and ready to land.Jun 2 2023, 8:53 PM

Closed by commit rG93fe5909babb: hwpmc: split out PMC_OP_PMCRW (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG93fe5909babb: hwpmc: split out PMC_OP_PMCRW.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hwpmc/

229 lines

Diff 123233

sys/dev/hwpmc/hwpmc_mod.c

Loading...