Page MenuHomeFreeBSD
Differential D40518

hwpmc: flatten conditional in pmc_process_exit()
ClosedPublic
Actions

Authored by mhorne on Jun 13 2023, 5:56 PM.
Tags
None
Referenced Files
F166323080: D40518.diff
Wed, Aug 12, 10:03 PM
Unknown Object (File)
Sat, Aug 8, 5:48 PM
Unknown Object (File)
Sat, Aug 8, 5:30 PM
Unknown Object (File)
Sat, Aug 8, 12:13 PM
Unknown Object (File)
Mon, Aug 3, 6:14 AM
Unknown Object (File)
Sun, Aug 2, 4:56 AM
Unknown Object (File)
Sun, Aug 2, 1:53 AM
Unknown Object (File)
Sat, Aug 1, 4:21 AM
View All Files
Subscribers
imp

Details

Reviewers
jkoshy
gnn
Commits
rG104e8215cc75: hwpmc: flatten conditional in pmc_process_exit()
Summary

Use a goto to clarify the control flow when there is no process
descriptor. This wins back a level of indentation.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Jun 13 2023, 5:56 PM
Herald added a reviewer: gnn. · View Herald TranscriptJun 13 2023, 5:56 PM
Herald added a subscriber: imp. · View Herald Transcript
mhorne requested review of this revision.Jun 13 2023, 5:56 PM
Harbormaster completed remote builds in B52027: Diff 123167.Jun 13 2023, 5:56 PM
jkoshy accepted this revision.Jun 14 2023, 9:45 AM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
5025

While here: "could be the target"?

This revision is now accepted and ready to land.Jun 14 2023, 9:45 AM
Closed by commit rG104e8215cc75: hwpmc: flatten conditional in pmc_process_exit() (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.
mhorne added a commit: rG104e8215cc75: hwpmc: flatten conditional in pmc_process_exit().

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
187 lines

Diff 123234

View Options

sys/dev/hwpmc/hwpmc_mod.c

Loading...