Page MenuHomeFreeBSD
Differential D40518

hwpmc: flatten conditional in pmc_process_exit()
ClosedPublic
Actions

Authored by mhorne on Jun 13 2023, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 13, 2:33 AM
Unknown Object (File)
Fri, Nov 7, 11:23 PM
Unknown Object (File)
Wed, Nov 5, 4:42 AM
Unknown Object (File)
Oct 29 2025, 10:58 AM
Unknown Object (File)
Oct 29 2025, 10:54 AM
Unknown Object (File)
Oct 29 2025, 10:41 AM
Unknown Object (File)
Oct 29 2025, 10:37 AM
Unknown Object (File)
Oct 27 2025, 12:37 AM
View All 85 Files
Subscribers
imp

Details

Reviewers
jkoshy
gnn
Commits
rG104e8215cc75: hwpmc: flatten conditional in pmc_process_exit()
Summary

Use a goto to clarify the control flow when there is no process
descriptor. This wins back a level of indentation.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 52027
Build 48918: arc lint + arc unit

Event Timeline

mhorne created this revision.Jun 13 2023, 5:56 PM
Herald added a reviewer: gnn. · View Herald TranscriptJun 13 2023, 5:56 PM
Herald added a subscriber: imp. · View Herald Transcript
mhorne requested review of this revision.Jun 13 2023, 5:56 PM
Harbormaster completed remote builds in B52027: Diff 123167.Jun 13 2023, 5:56 PM
jkoshy accepted this revision.Jun 14 2023, 9:45 AM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_mod.c
5028

While here: "could be the target"?

This revision is now accepted and ready to land.Jun 14 2023, 9:45 AM
Closed by commit rG104e8215cc75: hwpmc: flatten conditional in pmc_process_exit() (authored by mhorne). · Explain WhyJun 14 2023, 4:47 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked an inline comment as done.
mhorne added a commit: rG104e8215cc75: hwpmc: flatten conditional in pmc_process_exit().

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
171 lines

Diff 123167

View Options

sys/dev/hwpmc/hwpmc_mod.c

Loading...