Page MenuHomeFreeBSD

hwpmc: pass pmc pointer to more class methods
ClosedPublic

Authored by mhorne on May 1 2023, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 9, 7:23 AM
Unknown Object (File)
Fri, Jan 23, 4:33 PM
Unknown Object (File)
Wed, Jan 21, 5:45 AM
Unknown Object (File)
Jan 8 2026, 4:39 AM
Unknown Object (File)
Jan 8 2026, 4:39 AM
Unknown Object (File)
Jan 8 2026, 4:23 AM
Unknown Object (File)
Dec 30 2025, 12:50 AM
Unknown Object (File)
Dec 17 2025, 8:39 AM

Details

Summary

In many cases this avoids an extra lookup, since the callers always have
pm at hand. We can also eliminate several assertions, mostly for pm !=
NULL. The class methods are an internal interface, and the callers
already handle such a scenario. No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tinderbox points out that I didn't finish the change for a few platforms.

Update other classes; it now passes tinderbox.

FYI, the pm_id field in a struct pmc contains the CPU and 'row index' for the PMC, so we could potentially drop the cpu and ri fields in a future change.

This revision is now accepted and ready to land.May 3 2023, 9:48 AM
This revision was automatically updated to reflect the committed changes.