This means that the PSH and FIN flag correctly appear only in the last segment, but the CWR flag does not only appear in the first segment, but also in all middle segments.
Using this patch, this could be fixed.

When doing Accurate ECN as currently being specified in Accurate ECN, the masks should be:

mask.first	0xFF6
mask.middle	0xFF6
mask.last	0xFFF

The proposed patch would allow a NIC to be configured to do TSO for either classical ECN or accurate ECN.

Does this description make the motivation clear?

@Yogesh.Bhosale_intel.com I forgot to change the commit header to have you as the author; I'll fix that if/when I do the MFC.

In D46187#1053418, @zlei wrote:

In D46187#1052954, @erj wrote:

ixl(4) and ice(4) could integrate this function, too:

ixl(4) needs to remove the unused "vsi->oqdrops" variable and just not handle the IFCOUNTER_OQDROPS case in its switch statement in ixl_if_get_counter(), then call your new iflib_if_get_counter_default().

"vsi->oqdrops" is actually in use. It is set via IXL_SET_OQDROPS in function ixl_update_vsi_stats().

ixl(4) and ice(4) could integrate this function, too:

Is this supposed to help solve the problem in the PR? I'm not sure what's going on there, but I'm not sure it's clear in there except for your comment that Odrops isn't incrementing because they're not being retrieved properly.

I don't know if we'll see any other comments from anyone else on this, so I'll probably go and commit this sometime in the next couple days.

It would be nice if someone added a comment about what the operations in irdma_ctrl.c are doing, but I think I understand them and the replacements look ok to me.

It looks like it matches the cleanup that happens in the other return paths to me

The updates look good to me.

In D43093#1033039, @des wrote:

Eric, do you want me to commandeer this?

Content-wise, it looks good to me now.

Similar to the iavf(4) update here: https://reviews.freebsd.org/D43093, the documentation team here has generated a new man page for ice(4), but I haven't converted it to the FreeBSD upstream format, yet. I'm fine with this version with some fixes, but if you give me a couple days I can convert it and submit it here for review.

Committed.

Committed in 015f8cc5b0c10336a048f37a7071ea03516de242.

@gallatin Do you see the Stack tab?

In D39930#943725, @kbowling wrote:

@erj can you post the draft driver update, I'd like to see how it intends to use this patch stack before commentary

Committed in rG5b5f7d0e77a9eee73eb5d596f43aef4e1a3674d8.

Update value used for IFLIB_FEATURE_SUB_INTERFACES

Rebase on latest main; remove whitespace error

Rebase on latest main