Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (602 w, 4 d)

Recent Activity

Mon, Nov 24

andrew accepted D53738: arm64: Add Arm SPE thread mode support.
Mon, Nov 24, 2:35 PM

Thu, Nov 20

andrew added a comment to D53722: gdb: Fix the cache sync in write_instr().

Having talked to a Linux dev who is familiar with the kvm code I think we need to:

  1. ensure all VCPUs are stopped

This is guaranteed here.

  1. write the instruction
  2. clean the d-cache to the point of unification

Do we need to guarantee that this happens on the same host CPU? If so I think we need to move these operations into the kernel.

Thu, Nov 20, 5:03 PM

Wed, Nov 19

andrew added inline comments to D53738: arm64: Add Arm SPE thread mode support.
Wed, Nov 19, 11:38 AM

Tue, Nov 18

andrew committed rG7446569bbcb4: conf: Mark vchiq as depending on fdt (authored by andrew).
conf: Mark vchiq as depending on fdt
Tue, Nov 18, 6:03 PM
andrew committed rGa695ac2ce8bc: arm64: Move intr_pic_init_secondary earlier (authored by andrew).
arm64: Move intr_pic_init_secondary earlier
Tue, Nov 18, 6:03 PM
andrew closed D53665: arm64: Remove gicv3_get_support_lpis.
Tue, Nov 18, 6:03 PM
andrew committed rG2188e77bfdec: arm64: Remove gicv3_get_support_lpis (authored by andrew).
arm64: Remove gicv3_get_support_lpis
Tue, Nov 18, 6:03 PM
andrew closed D53664: arm64: Switch to gic_get_support_lpis in gicv3_its.
Tue, Nov 18, 6:03 PM
andrew committed rG3ef673e98af6: arm64: Switch to gic_get_support_lpis in gicv3_its (authored by andrew).
arm64: Switch to gic_get_support_lpis in gicv3_its
Tue, Nov 18, 6:03 PM
andrew closed D53685: arm64: Move intr_pic_init_secondary earlier.
Tue, Nov 18, 6:03 PM
andrew committed rG8178a4e3c132: arm/gic: Make GICV3_IVAR_SUPPORT_LPIS generic (authored by andrew).
arm/gic: Make GICV3_IVAR_SUPPORT_LPIS generic
Tue, Nov 18, 6:03 PM
andrew committed rG262fadda3700: arm: Handle GIC_IVAR_VGIC in the gic driver (authored by andrew).
arm: Handle GIC_IVAR_VGIC in the gic driver
Tue, Nov 18, 6:03 PM
andrew committed rG4713f5401317: arm64: Add non-PCI MSI support (authored by andrew).
arm64: Add non-PCI MSI support
Tue, Nov 18, 6:03 PM
andrew closed D53662: arm: Handle GIC_IVAR_VGIC in the gic driver.
Tue, Nov 18, 6:03 PM
andrew committed rG68e6422c6c91: dev/fdt: Add support for non-PCI MSI interrupts (authored by andrew).
dev/fdt: Add support for non-PCI MSI interrupts
Tue, Nov 18, 6:03 PM
andrew closed D53663: arm/gic: Make GICV3_IVAR_SUPPORT_LPIS generic.
Tue, Nov 18, 6:03 PM
andrew committed rG6b12b94c8fd2: dev/ofw: Teach ofw_cpu to find the pcpu on arm64 (authored by andrew).
dev/ofw: Teach ofw_cpu to find the pcpu on arm64
Tue, Nov 18, 6:03 PM
andrew closed D53331: arm64: Add non-PCI MSI support.
Tue, Nov 18, 6:03 PM
andrew closed D53330: dev/fdt: Add support for non-PCI MSI interrupts.
Tue, Nov 18, 6:02 PM
andrew closed D53327: dev/ofw: Teach ofw_cpu to find the pcpu on arm64.
Tue, Nov 18, 6:02 PM
andrew added a comment to D53738: arm64: Add Arm SPE thread mode support.

I see, hwt_switch_in calls hwt_backend_configure so the thread is configured on the new CPU

Tue, Nov 18, 3:12 PM
andrew added a comment to D53738: arm64: Add Arm SPE thread mode support.

How does the buffering work in threading mode on SMP? It looks like there is still a per-CPU buffer for SPE to write to where I would expect it to be per-thread. e.g. If userspace maps the CPU0 buffer, then the thread migrates to CPU1 would userspace still get SPE data?

Tue, Nov 18, 11:31 AM

Thu, Nov 13

andrew added reviewers for D53738: arm64: Add Arm SPE thread mode support: arm64, br.
Thu, Nov 13, 3:41 PM
andrew added a comment to D52243: arm64: 32-bit compat is little endian, read the correct word.

It looks like this was fixed in 1ca09538d94273601dac08204c1d0b3ca9115864

Thu, Nov 13, 1:57 PM
andrew accepted D53700: sys: Declare 'end' as an extern char so that &end is a char *.
Thu, Nov 13, 1:52 PM
andrew accepted D53699: arm64: Fix calculating kernel size for preload metadata.
Thu, Nov 13, 1:52 PM
andrew added a comment to D53722: gdb: Fix the cache sync in write_instr().

Having talked to a Linux dev who is familiar with the kvm code I think we need to:

  1. ensure all VCPUs are stopped
  2. write the instruction
  3. clean the d-cache to the point of unification
  4. if we have a VIPT icache and CTR_EL0.DIC == 0 then perform the i-cache maintenance in the kernel
Thu, Nov 13, 12:22 PM
andrew added a comment to D53722: gdb: Fix the cache sync in write_instr().

__clear_cache may not work for this use on CPUs with a VIPT i-cache. It will only invalidate the i-cache by virtual address, if the instruction is in the guests i-cache it will not be handled correctly.

Thu, Nov 13, 11:51 AM

Wed, Nov 12

andrew committed rG68f185ccc9f8: arm64: Add Arm SPE support (authored by zachary.leaf_arm.com).
arm64: Add Arm SPE support
Wed, Nov 12, 5:49 PM
andrew committed rGbe0ded8d64e3: arm64: Add a define for MDCR_EL2_E2PB_EL1_0_NO_TRAP (authored by sarah.walker2_arm.com).
arm64: Add a define for MDCR_EL2_E2PB_EL1_0_NO_TRAP
Wed, Nov 12, 5:49 PM
andrew committed rG736b7ec362a3: arm64: Add the PMBSR_MSS_BSC_BUFFER_FILLED define (authored by sarah.walker2_arm.com).
arm64: Add the PMBSR_MSS_BSC_BUFFER_FILLED define
Wed, Nov 12, 5:49 PM
andrew closed D46241: HWT: Arm Statistical Profiling Extension (SPE) support.
Wed, Nov 12, 5:49 PM

Tue, Nov 11

andrew requested review of D53691: arm: Support the optional limitation on dsb/dmb.
Tue, Nov 11, 5:28 PM
andrew requested review of D53685: arm64: Move intr_pic_init_secondary earlier.
Tue, Nov 11, 11:51 AM

Mon, Nov 10

andrew requested review of D53665: arm64: Remove gicv3_get_support_lpis.
Mon, Nov 10, 1:05 PM
andrew requested review of D53664: arm64: Switch to gic_get_support_lpis in gicv3_its.
Mon, Nov 10, 1:05 PM
andrew requested review of D53663: arm/gic: Make GICV3_IVAR_SUPPORT_LPIS generic.
Mon, Nov 10, 1:04 PM
andrew requested review of D53662: arm: Handle GIC_IVAR_VGIC in the gic driver.
Mon, Nov 10, 1:04 PM
andrew accepted D46241: HWT: Arm Statistical Profiling Extension (SPE) support.
Mon, Nov 10, 12:34 PM

Wed, Nov 5

andrew added inline comments to D46241: HWT: Arm Statistical Profiling Extension (SPE) support.
Wed, Nov 5, 10:48 AM

Tue, Nov 4

andrew accepted D53580: arm64/vmm: Move the vgic_max_cpu_count() check.
Tue, Nov 4, 4:34 PM
andrew added a comment to D46241: HWT: Arm Statistical Profiling Extension (SPE) support.

Just style issues

Tue, Nov 4, 11:38 AM

Oct 27 2025

andrew committed rGd539f2d9d2ce: dev/ofw: Register the ofw_cpu xref (authored by andrew).
dev/ofw: Register the ofw_cpu xref
Oct 27 2025, 12:03 PM
andrew closed D53329: dev/ofw: Register the xref.
Oct 27 2025, 12:03 PM
andrew committed rG87cea227e194: dev/ofw: Move ofw_cpu earlier (authored by andrew).
dev/ofw: Move ofw_cpu earlier
Oct 27 2025, 12:03 PM
andrew closed D53328: dev/ofw: Move ofw_cpu earlier.
Oct 27 2025, 12:03 PM
andrew committed rG95a5bfcee07c: arm64: Use _armreg.h in cpu.h (authored by andrew).
arm64: Use _armreg.h in cpu.h
Oct 27 2025, 12:03 PM
andrew committed rGb57a571a0019: arm64: Split out accessing special registers (authored by andrew).
arm64: Split out accessing special registers
Oct 27 2025, 12:03 PM
andrew closed D53325: arm64: Use _armreg.h in cpu.h.
Oct 27 2025, 12:03 PM
andrew committed rGf3ee178be2b2: arm64: Remove armreg.h from db_machdep.h (authored by andrew).
arm64: Remove armreg.h from db_machdep.h
Oct 27 2025, 12:03 PM
andrew committed rGaa22b68ec766: arm64: Include armreg.h in db_disasm.c (authored by andrew).
arm64: Include armreg.h in db_disasm.c
Oct 27 2025, 12:02 PM
andrew closed D53324: arm64: Split out accessing special registers.
Oct 27 2025, 12:02 PM
andrew committed rGfddf48eb012c: arm64/vmm: Remove armreg.h when not needed (authored by andrew).
arm64/vmm: Remove armreg.h when not needed
Oct 27 2025, 12:02 PM
andrew closed D53323: arm64: Remove armreg.h from db_machdep.h.
Oct 27 2025, 12:02 PM
andrew closed D53322: arm64: Include armreg.h in db_disasm.c.
Oct 27 2025, 12:02 PM
andrew closed D53321: arm64/vmm: Remove armreg.h when not needed.
Oct 27 2025, 12:02 PM

Oct 24 2025

andrew requested review of D53331: arm64: Add non-PCI MSI support.
Oct 24 2025, 3:20 PM
andrew requested review of D53330: dev/fdt: Add support for non-PCI MSI interrupts.
Oct 24 2025, 3:20 PM
andrew requested review of D53329: dev/ofw: Register the xref.
Oct 24 2025, 2:59 PM
andrew requested review of D53328: dev/ofw: Move ofw_cpu earlier.
Oct 24 2025, 2:58 PM
andrew requested review of D53327: dev/ofw: Teach ofw_cpu to find the pcpu on arm64.
Oct 24 2025, 2:58 PM
andrew requested review of D53325: arm64: Use _armreg.h in cpu.h.
Oct 24 2025, 12:35 PM
andrew requested review of D53324: arm64: Split out accessing special registers.
Oct 24 2025, 12:34 PM
andrew requested review of D53323: arm64: Remove armreg.h from db_machdep.h.
Oct 24 2025, 12:34 PM
andrew requested review of D53322: arm64: Include armreg.h in db_disasm.c.
Oct 24 2025, 12:34 PM
andrew requested review of D53321: arm64/vmm: Remove armreg.h when not needed.
Oct 24 2025, 12:34 PM

Oct 23 2025

andrew committed rGf4f638eb23d7: arm64: Add additional fields for PMBSR and PMSIDR (authored by sarah.walker2_arm.com).
arm64: Add additional fields for PMBSR and PMSIDR
Oct 23 2025, 11:05 AM
andrew committed rGb157c28ce97b: modules/dtb: Add the ARM dtb module (authored by andrew).
modules/dtb: Add the ARM dtb module
Oct 23 2025, 11:05 AM
andrew closed D51258: modules/dtb: Add the ARM dtb module.
Oct 23 2025, 11:05 AM
andrew committed rG82778970eeb2: share/mk: Add opencsd to the list of private libs (authored by andrew).
share/mk: Add opencsd to the list of private libs
Oct 23 2025, 11:05 AM
andrew closed D53217: share/mk: Add opencsd to the list of private libs.
Oct 23 2025, 11:04 AM

Oct 20 2025

andrew requested review of D53217: share/mk: Add opencsd to the list of private libs.
Oct 20 2025, 3:12 PM

Oct 17 2025

andrew committed rGedbbf26e2650: pci/n1sdp: Disable HotPlug (authored by andrew).
pci/n1sdp: Disable HotPlug
Oct 17 2025, 3:03 PM
andrew closed D53134: pci/n1sdp: Disable HotPlug.
Oct 17 2025, 3:03 PM

Oct 16 2025

andrew committed rGd970d0246fdd: arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework (authored by sarah.walker2_arm.com).
arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework
Oct 16 2025, 4:15 PM
andrew closed D53112: arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework.
Oct 16 2025, 4:14 PM
andrew updated the diff for D51258: modules/dtb: Add the ARM dtb module.
  • allwinner -> Arm
  • Attach the Makefile to std.arm
Oct 16 2025, 4:00 PM
andrew accepted D53112: arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework.
Oct 16 2025, 2:52 PM
andrew added a comment to D53112: arm64: Move BP hardening and SSBD workaround to CPU_FEAT framework.

The best names I can come up with for a workaround for a missing feature is feat_foo_missing or feat_foo_workaround

Oct 16 2025, 1:31 PM
andrew requested review of D53134: pci/n1sdp: Disable HotPlug.
Oct 16 2025, 10:48 AM

Oct 15 2025

andrew added inline comments to D46241: HWT: Arm Statistical Profiling Extension (SPE) support.
Oct 15 2025, 3:20 PM

Oct 13 2025

andrew requested review of D53074: arm64: Set a FAR value when it's not valid.
Oct 13 2025, 4:00 PM
andrew requested review of D53073: arm64: Handle more Synchronous External Aborts.
Oct 13 2025, 4:00 PM

Oct 9 2025

andrew committed rGf579cc44981b: arm64/vmm: Add missing debug traps (authored by andrew).
arm64/vmm: Add missing debug traps
Oct 9 2025, 4:33 PM
andrew committed rG9f85826c88ea: arm64/vmm: Handle debug exits (authored by andrew).
arm64/vmm: Handle debug exits
Oct 9 2025, 4:33 PM
andrew committed rGddd5ff0f770d: arm64: Add Debug OS Lock fields (authored by andrew).
arm64: Add Debug OS Lock fields
Oct 9 2025, 4:33 PM
andrew committed rG54ee094d9a98: arm64: Sort hypervisor.h (authored by andrew).
arm64: Sort hypervisor.h
Oct 9 2025, 4:33 PM
andrew committed rGcb004ced6350: arm64: Rename the MDCR_EL2 macros (authored by andrew).
arm64: Rename the MDCR_EL2 macros
Oct 9 2025, 4:33 PM
andrew committed rGe14f3edc16bc: arm64/vmm: Save dbgclaimset_el1 (authored by andrew).
arm64/vmm: Save dbgclaimset_el1
Oct 9 2025, 4:32 PM
andrew committed rGdcfe2e687e71: arm64/vmm: Save more PMU registers (authored by andrew).
arm64/vmm: Save more PMU registers
Oct 9 2025, 4:32 PM
andrew committed rG3e9e19e9674b: arm64/vmm: Clear all pmc fields (authored by andrew).
arm64/vmm: Clear all pmc fields
Oct 9 2025, 4:32 PM

Oct 7 2025

andrew committed rG534aec00976c: arm64/vmm: Handle debug exits (authored by andrew).
arm64/vmm: Handle debug exits
Oct 7 2025, 8:42 AM
andrew committed rGfa975e2a5bb2: arm64: Add Debug OS Lock fields (authored by andrew).
arm64: Add Debug OS Lock fields
Oct 7 2025, 8:42 AM
andrew closed D52930: arm64: Add Debug OS Lock fields.
Oct 7 2025, 8:42 AM
andrew closed D52931: arm64/vmm: Handle debug exits.
Oct 7 2025, 8:42 AM

Oct 6 2025

andrew added a comment to D52806: arm64/vmm: Add missing debug traps.

Can you try D52930 and D52931?

Oct 6 2025, 3:01 PM
andrew requested review of D52931: arm64/vmm: Handle debug exits.
Oct 6 2025, 1:50 PM
andrew requested review of D52930: arm64: Add Debug OS Lock fields.
Oct 6 2025, 1:38 PM

Oct 2 2025

andrew committed rGc67ea2707d2b: arm64/vmm: Add missing debug traps (authored by andrew).
arm64/vmm: Add missing debug traps
Oct 2 2025, 4:23 PM
andrew committed rG4aa762f3cb97: arm64: Sort hypervisor.h (authored by andrew).
arm64: Sort hypervisor.h
Oct 2 2025, 4:23 PM