Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (620 w, 6 d)

Recent Activity

Wed, Apr 1

andrew accepted D56203: ofw: bool-ify OF_hasprop().
Wed, Apr 1, 10:30 AM
andrew updated the diff for D43311: arm64: Add arm64 SVE tests.

Remove extra lines at the start of MAkefiles

Wed, Apr 1, 9:50 AM

Tue, Mar 31

andrew added inline comments to D43311: arm64: Add arm64 SVE tests.
Tue, Mar 31, 3:24 PM
andrew added inline comments to D43311: arm64: Add arm64 SVE tests.
Tue, Mar 31, 3:09 PM
andrew updated the diff for D43311: arm64: Add arm64 SVE tests.
  • Add an mtree entry
  • Check the headder type
  • Use a brk instruction to stop execution as a syscall may drop the SVE context
Tue, Mar 31, 2:44 PM

Mon, Mar 23

andrew added inline comments to D55943: arm64: Handle changing self-referential DMAP pages.
Mon, Mar 23, 9:51 AM

Thu, Mar 19

andrew updated the diff for D55961: arm64: Move the FEAT_VMID16 detection to vmm.
  • Zero the set in pmap_fini_asids
  • Add a missing tlbi
Thu, Mar 19, 6:31 PM
andrew added inline comments to D55860: arm64/vmm: Enable 16-bit VMIDs when in use by pmap.
Thu, Mar 19, 5:06 PM
andrew requested review of D55961: arm64: Move the FEAT_VMID16 detection to vmm.
Thu, Mar 19, 5:05 PM
andrew added reviewers for D55957: vm: Support swapping arm64 MTE tags: alc, kib, markj.
Thu, Mar 19, 4:27 PM
andrew added inline comments to D55947: arm64: mte: handle synchronous tag check faults.
Thu, Mar 19, 4:26 PM
andrew added reviewers for D55949: arm64: Support changing the DMAP memory type: alc, kib, markj.
Thu, Mar 19, 4:25 PM
andrew added reviewers for D55943: arm64: Handle changing self-referential DMAP pages: alc, kib, markj.
Thu, Mar 19, 4:25 PM
andrew added inline comments to D55860: arm64/vmm: Enable 16-bit VMIDs when in use by pmap.
Thu, Mar 19, 4:21 PM
andrew added a comment to D55956: arm64: Add PROT_MTE to mmap.

This is not complete, but would be useful to get feedback on the approach

Thu, Mar 19, 4:08 PM
andrew requested review of D55960: arm64: mte: cpu feature detection for FEAT_MTE/FEAT_MTE2.
Thu, Mar 19, 4:07 PM
andrew requested review of D55959: arm64: Support async MTE.
Thu, Mar 19, 4:07 PM
andrew requested review of D55958: arm64: mte: userspace configuration of MTE via sysarch() system call.
Thu, Mar 19, 4:07 PM
andrew requested review of D55957: vm: Support swapping arm64 MTE tags.
Thu, Mar 19, 4:07 PM
andrew requested review of D55956: arm64: Add PROT_MTE to mmap.
Thu, Mar 19, 4:06 PM
andrew requested review of D55955: arm64: mte: copy/save tags on copy-on-write.
Thu, Mar 19, 4:06 PM
andrew requested review of D55953: arm64: Add support for per-page flags.
Thu, Mar 19, 4:06 PM
andrew requested review of D55954: arm64: Add vm_page_t MTE flags.
Thu, Mar 19, 4:06 PM
andrew requested review of D55952: arm64: Check for MTE tag failures on kernel entry.
Thu, Mar 19, 4:06 PM
andrew requested review of D55951: arm64: Manage the MTE state like pointer auth.
Thu, Mar 19, 4:06 PM
andrew requested review of D55950: arm64: Support some per-thread sctlr_el1 fields.
Thu, Mar 19, 4:05 PM
andrew requested review of D55949: arm64: Support changing the DMAP memory type.
Thu, Mar 19, 4:05 PM
andrew requested review of D55948: arm64: mte: add tagged memory attribute.
Thu, Mar 19, 4:05 PM
andrew requested review of D55947: arm64: mte: handle synchronous tag check faults.
Thu, Mar 19, 4:05 PM
andrew requested review of D55946: arm64: mte: configure initial state for system registers.
Thu, Mar 19, 4:05 PM
andrew requested review of D55945: arm64: mte: add system register definitions.
Thu, Mar 19, 4:04 PM
andrew requested review of D55944: arm64: mte: cleanup cache register definitions.
Thu, Mar 19, 4:04 PM
andrew requested review of D55943: arm64: Handle changing self-referential DMAP pages.
Thu, Mar 19, 4:04 PM

Tue, Mar 17

andrew committed rG14e97448fceb: arm64: Have a common call to userret (authored by andrew).
arm64: Have a common call to userret
Tue, Mar 17, 5:12 PM
andrew closed D55250: arm64: Have a common call to userret.
Tue, Mar 17, 5:12 PM
andrew updated the diff for D55250: arm64: Have a common call to userret.

Remove userret from EXCP_MOE. Was missed in a rebase.

Tue, Mar 17, 1:59 PM
andrew committed rG1d13d938fe6c: virtio: Ensure power-of-two alignment for indirect queue (authored by sarah.walker2_arm.com).
virtio: Ensure power-of-two alignment for indirect queue
Tue, Mar 17, 11:25 AM
andrew closed D55843: virtio: Ensure power-of-two alignment for indirect queue.
Tue, Mar 17, 11:24 AM
andrew accepted D55843: virtio: Ensure power-of-two alignment for indirect queue.
Tue, Mar 17, 9:58 AM
andrew updated the diff for D55250: arm64: Have a common call to userret.

Fix the initial value of skip_userret

Tue, Mar 17, 9:51 AM

Mon, Mar 16

andrew added a comment to D55860: arm64/vmm: Enable 16-bit VMIDs when in use by pmap.

Is there a reason to not just read the ID register in the vmm code?

Mon, Mar 16, 5:06 PM

Tue, Mar 10

andrew committed rG1a92fc9c1210: virtio: Restore mb() calls (authored by sarah.walker2_arm.com).
virtio: Restore mb() calls
Tue, Mar 10, 7:11 PM
andrew committed rG522012c8bd07: Revert "virtio: Restore mb() calls" (authored by andrew).
Revert "virtio: Restore mb() calls"
Tue, Mar 10, 7:11 PM
andrew added a reverting change for rGd99e725c26a7: virtio: Restore mb() calls: rG522012c8bd07: Revert "virtio: Restore mb() calls".
Tue, Mar 10, 7:11 PM
andrew added a reverting change for D55766: virtio: Restore mb() calls: rG522012c8bd07: Revert "virtio: Restore mb() calls".
Tue, Mar 10, 7:10 PM
andrew committed rGd99e725c26a7: virtio: Restore mb() calls (authored by andrew).
virtio: Restore mb() calls
Tue, Mar 10, 7:09 PM
andrew closed D55766: virtio: Restore mb() calls.
Tue, Mar 10, 7:09 PM
andrew accepted D55766: virtio: Restore mb() calls.
Tue, Mar 10, 6:39 PM

Mon, Mar 9

andrew added a reviewer for D55766: virtio: Restore mb() calls: virtio.
Mon, Mar 9, 4:33 PM

Thu, Mar 5

andrew updated the diff for D55250: arm64: Have a common call to userret.

Set a variable to check if we need to skip userret

Thu, Mar 5, 3:42 PM
andrew committed rG80b4129bef8b: arm64: Optimise the repeated TLBI workaround (authored by andrew).
arm64: Optimise the repeated TLBI workaround
Thu, Mar 5, 3:14 PM
andrew committed rG570b8b25753c: arm64: Use a canonical address when TBI is enabled (authored by andrew).
arm64: Use a canonical address when TBI is enabled
Thu, Mar 5, 3:14 PM
andrew closed D55646: arm64: Optimise the repeated TLBI workaround.
Thu, Mar 5, 3:14 PM
andrew closed D55619: arm64: Use a canonical address when TBI is enabled.
Thu, Mar 5, 3:14 PM

Wed, Mar 4

andrew closed D51764: arm64/vmm: Support PMU v3p9.
Wed, Mar 4, 5:15 PM
andrew committed rGd1650d226205: arm64/vmm: Support PMU v3p9 (authored by andrew).
arm64/vmm: Support PMU v3p9
Wed, Mar 4, 5:15 PM
andrew committed rGe40e5458616d: arm64: Treat the PMUVer field of ID_AA64DFR0 as unsigned (authored by Kajetan Puchalski <kajetan.puchalski@arm.com>).
arm64: Treat the PMUVer field of ID_AA64DFR0 as unsigned
Wed, Mar 4, 5:14 PM
andrew accepted D55636: static dtb: add BTI note.

I see, the issue is the generated ifunc trampolines only have BTI landing pads when the note is in all object files.

Wed, Mar 4, 5:08 PM

Mar 4 2026

andrew added a comment to D55636: static dtb: add BTI note.

The change is correct. I think it is more likely that rebuilding the kernel with a consistent toolchain is the fix for the BTI exception.

Mar 4 2026, 2:09 PM
andrew added reviewers for D55619: arm64: Use a canonical address when TBI is enabled: kib, markj, alc.
Mar 4 2026, 12:33 PM
andrew requested review of D55646: arm64: Optimise the repeated TLBI workaround.
Mar 4 2026, 12:32 PM
andrew added a comment to D55636: static dtb: add BTI note.

How does it fix the Branch Target exception? The kernel doesn't care about the note, it's just there to ensure all source files are built with BTI enabled.

Mar 4 2026, 10:30 AM

Mar 3 2026

andrew committed rGc8c37141a661: virtio_blk: Use bus_dma for command/ack buffer allocations (authored by sarah.walker2_arm.com).
virtio_blk: Use bus_dma for command/ack buffer allocations
Mar 3 2026, 5:38 PM
andrew committed rGc499ad6f997c: virtio: Use bus_dma for ring and indirect buffer allocations (authored by sarah.walker2_arm.com).
virtio: Use bus_dma for ring and indirect buffer allocations
Mar 3 2026, 5:38 PM
andrew closed D54959: virtio: Use bus_dma for ring and indirect buffer allocations.
Mar 3 2026, 5:38 PM
andrew closed D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.
Mar 3 2026, 5:38 PM

Mar 2 2026

andrew requested review of D55619: arm64: Use a canonical address when TBI is enabled.
Mar 2 2026, 5:47 PM
andrew accepted D55534: arm64/pmap: Modify condition of valid_memattr that cannot be true.
Mar 2 2026, 11:40 AM
andrew added a comment to D55564: virtio_net: Use bus_dma for command/ack buffers.

Should the dma sync operations be BUS_DMASYNC_PREWRITE | BUS_DMASYNC_PREREAD and BUS_DMASYNC_POSTREAD | BUS_DMASYNC_POSTWRITE given virtio may read from & write to the buffer.

Mar 2 2026, 11:37 AM

Feb 27 2026

andrew accepted D55535: acpi: build dev/acpi_support/acpi_wmi_if.m on ARM64.
Feb 27 2026, 8:43 PM
andrew added a comment to D55556: ARM64: add thunderbolt to `std.apple`.

Where is the thunderbolt device defined? I don't see it in main.

Feb 27 2026, 10:10 AM
andrew added inline comments to D55535: acpi: build dev/acpi_support/acpi_wmi_if.m on ARM64.
Feb 27 2026, 10:09 AM

Feb 25 2026

andrew added a comment to D55492: virtio_net: Use bus_dma for rxq/txq buffers.

Should the alignment for the rx & tx DMA tags be VTNET_ETHER_ALIGN?

Feb 25 2026, 12:02 PM · network
andrew added reviewers for D55492: virtio_net: Use bus_dma for rxq/txq buffers: bryanv, andrew.
Feb 25 2026, 10:18 AM · network
andrew accepted D55486: elf_common.h: Add AArch64 Memtag ABI constants.
Feb 25 2026, 10:17 AM

Feb 24 2026

andrew accepted D54959: virtio: Use bus_dma for ring and indirect buffer allocations.
Feb 24 2026, 5:05 PM
andrew accepted D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.
Feb 24 2026, 4:27 PM
andrew added inline comments to D55486: elf_common.h: Add AArch64 Memtag ABI constants.
Feb 24 2026, 3:52 PM

Feb 18 2026

andrew committed rG3a960425df75: arm64: Add more HWCAP values (authored by andrew).
arm64: Add more HWCAP values
Feb 18 2026, 3:57 PM
andrew closed D55219: arm64: Add more HWCAP values.
Feb 18 2026, 3:57 PM
andrew committed rGf4d1a3ab0271: arm64: Fix the ESR_ELx_EC_MASK definition (authored by andrew).
arm64: Fix the ESR_ELx_EC_MASK definition
Feb 18 2026, 3:16 PM
andrew committed rGa6ad3d4ca050: CODEOWNERS: Add myself for sys/arm64/vmm (authored by andrew).
CODEOWNERS: Add myself for sys/arm64/vmm
Feb 18 2026, 3:16 PM
andrew committed rGbfb7c81f93b5: nvmecontrol: Remove an incorrect use of PAGE_SIZE (authored by andrew).
nvmecontrol: Remove an incorrect use of PAGE_SIZE
Feb 18 2026, 3:16 PM
andrew closed D55334: nvmecontrol: Remove an incorrect use of PAGE_SIZE.
Feb 18 2026, 3:16 PM
andrew accepted D55284: intrng: Shuffle unhandled interrupts too.
Feb 18 2026, 12:45 PM

Feb 17 2026

andrew requested review of D55334: nvmecontrol: Remove an incorrect use of PAGE_SIZE.
Feb 17 2026, 5:46 PM
andrew added inline comments to D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.
Feb 17 2026, 4:15 PM
andrew added inline comments to D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.
Feb 17 2026, 12:19 PM
andrew updated subscribers of D54959: virtio: Use bus_dma for ring and indirect buffer allocations.

virtio_blk calls bus_dma_tag_set_iommu on PowerPC; would that not be needed for these new tags?

Feb 17 2026, 12:06 PM
andrew added a comment to D55284: intrng: Shuffle unhandled interrupts too.

Do we want to zero the CPU for PPIs & IPIs? I expect that check should be before the handlers == 0 check as they may be sent to all CPUs.

Feb 17 2026, 11:38 AM

Feb 11 2026

andrew requested review of D55250: arm64: Have a common call to userret.
Feb 11 2026, 6:13 PM

Feb 10 2026

andrew closed D55147: vtgpu: Support virtio gpu on Parallels Desktop.
Feb 10 2026, 5:07 PM
andrew committed rG1ea0721e1a56: vtgpu: Support virtio gpu on Parallels Desktop (authored by andrew).
vtgpu: Support virtio gpu on Parallels Desktop
Feb 10 2026, 5:07 PM
andrew committed rG1224347817c4: arm64: Add MOPS implementations of copyin/copyout (authored by sarah.walker2_arm.com).
arm64: Add MOPS implementations of copyin/copyout
Feb 10 2026, 3:44 PM
andrew committed rG7d7295df9b13: arm64: Add MOPS implementation of pagezero() (authored by sarah.walker2_arm.com).
arm64: Add MOPS implementation of pagezero()
Feb 10 2026, 3:44 PM
andrew committed rG2ccbf06c0285: arm64: Add MOPS implementations of memset(), memcpy() and memmove() (authored by sarah.walker2_arm.com).
arm64: Add MOPS implementations of memset(), memcpy() and memmove()
Feb 10 2026, 3:44 PM
andrew committed rG18af5a180b29: arm64: Enable MOPS usage in the kernel (authored by sarah.walker2_arm.com).
arm64: Enable MOPS usage in the kernel
Feb 10 2026, 3:44 PM
andrew closed D54947: arm64: Add MOPS implementations of copyin/copyout.
Feb 10 2026, 3:43 PM
andrew closed D54946: arm64: Add MOPS implementation of pagezero().
Feb 10 2026, 3:43 PM
andrew closed D55051: arm64: Add MOPS implementations of memset(), memcpy() and memmove().
Feb 10 2026, 3:43 PM