User Details
User Details
- User Since
- May 10 2014, 2:21 PM (588 w, 2 d)
Yesterday
Yesterday
andrew added a comment to D51992: virtio/mmio: Remove the unused virtio_mmio_if.m.
It was a beri driver in sys/dev/beri/virtio/virtio_mmio_platform.c
andrew requested review of D51994: dev/fdt: Remove fdt_ic_list.
andrew requested review of D51993: virtio: Remove the unused poll method.
andrew requested review of D51992: virtio/mmio: Remove the unused virtio_mmio_if.m.
kboot: Support reading the smbios vis sysfs
Sat, Aug 16
Sat, Aug 16
andrew added inline comments to D51933: gpioc: remove unnecessary bus_generic_* calls.
Thu, Aug 14
Thu, Aug 14
andrew added inline comments to D51584: gpio: rework gpioaei.
Wed, Aug 13
Wed, Aug 13
uart: Remove the unused cd_port_subtype
uart: Add UART_ACPI_SPCR_CLASS
uart: Remove UART_ACPI_CLASS
andrew added inline comments to D51878: uart: Add UART_ACPI_SPCR_CLASS.
Tue, Aug 12
Tue, Aug 12
andrew requested review of D51879: uart: Remove the unused cd_port_subtype.
andrew requested review of D51878: uart: Add UART_ACPI_SPCR_CLASS.
andrew requested review of D51877: uart: Remove UART_ACPI_CLASS.
Mon, Aug 11
Mon, Aug 11
andrew added inline comments to D51771: uart: Add ns8250 ACPI entry for SPCR rev 2.
Fri, Aug 8
Fri, Aug 8
andrew requested review of D51822: sys/conf: Fix arm64 vmm_nvme dependencies.
andrew requested review of D51821: arm64/vmm: Use FEAT_ECV_POFF to support a timer.
andrew requested review of D51820: arm: Use the Self-Synchronized counter registers.
andrew requested review of D51819: arm64: Add more counter/timer registers.
andrew requested review of D51818: arm64/vmm: Remove support for reading CNTHCTL_EL2.
andrew requested review of D51817: arm64/vmm: Clean up enabling guest timer access.
andrew requested review of D51816: arm64/vmm: Add a feature flag and use it for HCRX.
arm64: Support TBI in userspace
Thu, Aug 7
Thu, Aug 7
bhyve/arm64: Implement PSCI_FNID_CPU_OFF
andrew committed rG6227d0f81a5e: bhyve/arm64: Stop assuming the CPU index is MPIDR (authored by andrew).
bhyve/arm64: Stop assuming the CPU index is MPIDR
bhyve/arm64: Tidy up a licence comment
andrew updated the diff for D51763: bhyve/arm64: Stop assuming the CPU index is MPIDR.
Rebase past 5d56a04d1b99c0187c7799be0d1e93586312bd55
andrew added a comment to D51768: bhyve/arm64: Implement PSCI_FNID_CPU_OFF.
I'm not sure there is anything to assert on. CPU_OFF is defined to "Power down the calling core" & doesn't take any arguments.
bhyve/arm64: Add a missing header file
andrew updated the diff for D51763: bhyve/arm64: Stop assuming the CPU index is MPIDR.
Update based on feedback from @markj
Add a missing header file
bhyve/arm64: Mark CPU0 as on at boot
bhyve/arm64: Fix a race in PSCI CPU_ON
cpuset: Add CPU_TEST_{SET,CLR}_ATOMIC
arm64/vmm: Support reading MPIDR_EL1
andrew added a comment to D51768: bhyve/arm64: Implement PSCI_FNID_CPU_OFF.
CPU_OFF can only be called from the target CPU
Wed, Aug 6
Wed, Aug 6
andrew committed rG81f07332c03f: arm64: tidy up Top-Byte-Ignore (TBI) in the kernel (authored by harry.moulton_arm.com).
arm64: tidy up Top-Byte-Ignore (TBI) in the kernel
arm64: Use a fixed value for sctlr_el1
arm64: Add ADDR_IS_USER
andrew added inline comments to D51765: sys: Add CPU_TEST_{SET,CLR}_ATOMIC.
andrew requested review of D51767: bhyve/arm64: Mark CPU0 as on at boot.
andrew requested review of D51768: bhyve/arm64: Implement PSCI_FNID_CPU_OFF.
andrew requested review of D51766: bhyve/arm64: Fix a race in PSCI CPU_ON.
andrew requested review of D51764: arm64/vmm: Support PMU v3p9.
andrew requested review of D51765: sys: Add CPU_TEST_{SET,CLR}_ATOMIC.
andrew requested review of D51762: arm64/vmm: Support reading MPIDR_EL1.
andrew requested review of D51763: bhyve/arm64: Stop assuming the CPU index is MPIDR.
Tue, Aug 5
Tue, Aug 5
Doesn't appear to be needed, the host kernel won't use it as it's not enabled.
Mon, Aug 4
Mon, Aug 4
arm64: Use xzr directly to set HCRX_EL2
andrew committed rG8986e15f0bb5: arm64: Teach CHECK_CPU_FEAT to handle more values (authored by andrew).
arm64: Teach CHECK_CPU_FEAT to handle more values
Fri, Aug 1
Fri, Aug 1
arm64: Rename ID_AA64MMFR0_ECV_CNTHCTL
arm64: Add CNTPOFF_EL2 op/CR values
arm64: Fix the sign in ID registers
andrew committed rG1c52229528e7: lib: Move libopencsd to /usr/lib and make private (authored by andrew).
lib: Move libopencsd to /usr/lib and make private
Thu, Jul 31
Thu, Jul 31
andrew added inline comments to D51621: kexec: Introduce basic arm64 support.
Wed, Jul 30
Wed, Jul 30
andrew added inline comments to D51637: arm64: Support TBI in userspace.
andrew requested review of D51637: arm64: Support TBI in userspace.
andrew updated the diff for D49119: arm64: tidy up Top-Byte-Ignore (TBI) in the kernel.
Only handle copyin/out/etc
Will keep Harry as Author
andrew retitled D49119: arm64: tidy up Top-Byte-Ignore (TBI) in the kernel from arm64: tidy up and enable top-byte-ignore (TBI) in the kernel to arm64: tidy up Top-Byte-Ignore (TBI) in the kernel.
andrew added a comment to D51456: Add support for bcm2835-virtgpio GPIO controller on some RPi models..
It looks like it's in downstream dts files, e.g. https://github.com/raspberrypi/linux/blob/45079112ab81154eaf418ff05a989e6fdf63db79/arch/arm/boot/dts/broadcom/bcm2710-rpi-cm3.dts#L143-L148
andrew added inline comments to D51621: kexec: Introduce basic arm64 support.
andrew added a comment to D51621: kexec: Introduce basic arm64 support.
Do you plan to return to EL2 on systems that booted from it but don't have VHE?
andrew added inline comments to D51625: kexec: Add dummy headers for powerpc, arm, and riscv.
Mon, Jul 28
Mon, Jul 28
andrew added inline comments to D51585: acpi_gpiobus: implement bus_child_deleted.
andrew added a comment to D51456: Add support for bcm2835-virtgpio GPIO controller on some RPi models..
VM_MEMATTR_UNCACHEABLE should be ok for this as the firmware is running on the GPU
Thu, Jul 24
Thu, Jul 24
andrew added a comment to D51456: Add support for bcm2835-virtgpio GPIO controller on some RPi models..
Is the firmware cache-coherent? If not we will need to ensure the value is written back to memory.
Mon, Jul 21
Mon, Jul 21
dev/ofw: Add interrupt-map support
Jul 18 2025
Jul 18 2025
andrew requested review of D51413: kboot: Support reading the smbios vis sysfs.
andrew updated the diff for D51380: lib: Move libopencsd to /usr/lib and make private.
Rebase + remove libopencsd-all.ucl
andrew added inline comments to D51380: lib: Move libopencsd to /usr/lib and make private.
andrew requested review of D51406: arm64: Add ADDR_IS_USER.
Jul 17 2025
Jul 17 2025
andrew requested review of D51380: lib: Move libopencsd to /usr/lib and make private.
andrew added a comment to D51374: packages: add package ucl for libopencsd-all.
I'm unsure why the libopencsd needs to exist, it will be used by the userspace hwt tool (D40728) to decode trace data from the CPU.
andrew requested review of D51378: arm64: Use xzr directly to set HCRX_EL2.
andrew requested review of D51377: arm64: Set CNTPOFF_EL2 when it's implemented.