Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (616 w, 4 d)

Recent Activity

Yesterday

andrew closed D51764: arm64/vmm: Support PMU v3p9.
Wed, Mar 4, 5:15 PM
andrew committed rGd1650d226205: arm64/vmm: Support PMU v3p9 (authored by andrew).
arm64/vmm: Support PMU v3p9
Wed, Mar 4, 5:15 PM
andrew committed rGe40e5458616d: arm64: Treat the PMUVer field of ID_AA64DFR0 as unsigned (authored by Kajetan Puchalski <kajetan.puchalski@arm.com>).
arm64: Treat the PMUVer field of ID_AA64DFR0 as unsigned
Wed, Mar 4, 5:14 PM
andrew accepted D55636: static dtb: add BTI note.

I see, the issue is the generated ifunc trampolines only have BTI landing pads when the note is in all object files.

Wed, Mar 4, 5:08 PM
andrew added a comment to D55636: static dtb: add BTI note.

The change is correct. I think it is more likely that rebuilding the kernel with a consistent toolchain is the fix for the BTI exception.

Wed, Mar 4, 2:09 PM
andrew added reviewers for D55619: arm64: Use a canonical address when TBI is enabled: kib, markj, alc.
Wed, Mar 4, 12:33 PM
andrew requested review of D55646: arm64: Optimise the repeated TLBI workaround.
Wed, Mar 4, 12:32 PM
andrew added a comment to D55636: static dtb: add BTI note.

How does it fix the Branch Target exception? The kernel doesn't care about the note, it's just there to ensure all source files are built with BTI enabled.

Wed, Mar 4, 10:30 AM

Tue, Mar 3

andrew committed rGc8c37141a661: virtio_blk: Use bus_dma for command/ack buffer allocations (authored by sarah.walker2_arm.com).
virtio_blk: Use bus_dma for command/ack buffer allocations
Tue, Mar 3, 5:38 PM
andrew committed rGc499ad6f997c: virtio: Use bus_dma for ring and indirect buffer allocations (authored by sarah.walker2_arm.com).
virtio: Use bus_dma for ring and indirect buffer allocations
Tue, Mar 3, 5:38 PM
andrew closed D54959: virtio: Use bus_dma for ring and indirect buffer allocations.
Tue, Mar 3, 5:38 PM
andrew closed D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.
Tue, Mar 3, 5:38 PM

Mon, Mar 2

andrew requested review of D55619: arm64: Use a canonical address when TBI is enabled.
Mon, Mar 2, 5:47 PM
andrew accepted D55534: arm64/pmap: Modify condition of valid_memattr that cannot be true.
Mon, Mar 2, 11:40 AM
andrew added a comment to D55564: virtio_net: Use bus_dma for command/ack buffers.

Should the dma sync operations be BUS_DMASYNC_PREWRITE | BUS_DMASYNC_PREREAD and BUS_DMASYNC_POSTREAD | BUS_DMASYNC_POSTWRITE given virtio may read from & write to the buffer.

Mon, Mar 2, 11:37 AM

Fri, Feb 27

andrew accepted D55535: acpi: build dev/acpi_support/acpi_wmi_if.m on ARM64.
Fri, Feb 27, 8:43 PM
andrew added a comment to D55556: ARM64: add thunderbolt to `std.apple`.

Where is the thunderbolt device defined? I don't see it in main.

Fri, Feb 27, 10:10 AM
andrew added inline comments to D55535: acpi: build dev/acpi_support/acpi_wmi_if.m on ARM64.
Fri, Feb 27, 10:09 AM

Wed, Feb 25

andrew added a comment to D55492: virtio_net: Use bus_dma for rxq/txq buffers.

Should the alignment for the rx & tx DMA tags be VTNET_ETHER_ALIGN?

Wed, Feb 25, 12:02 PM · network
andrew added reviewers for D55492: virtio_net: Use bus_dma for rxq/txq buffers: bryanv, andrew.
Wed, Feb 25, 10:18 AM · network
andrew accepted D55486: elf_common.h: Add AArch64 Memtag ABI constants.
Wed, Feb 25, 10:17 AM

Tue, Feb 24

andrew accepted D54959: virtio: Use bus_dma for ring and indirect buffer allocations.
Tue, Feb 24, 5:05 PM
andrew accepted D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.
Tue, Feb 24, 4:27 PM
andrew added inline comments to D55486: elf_common.h: Add AArch64 Memtag ABI constants.
Tue, Feb 24, 3:52 PM

Wed, Feb 18

andrew committed rG3a960425df75: arm64: Add more HWCAP values (authored by andrew).
arm64: Add more HWCAP values
Wed, Feb 18, 3:57 PM
andrew closed D55219: arm64: Add more HWCAP values.
Wed, Feb 18, 3:57 PM
andrew committed rGf4d1a3ab0271: arm64: Fix the ESR_ELx_EC_MASK definition (authored by andrew).
arm64: Fix the ESR_ELx_EC_MASK definition
Wed, Feb 18, 3:16 PM
andrew committed rGa6ad3d4ca050: CODEOWNERS: Add myself for sys/arm64/vmm (authored by andrew).
CODEOWNERS: Add myself for sys/arm64/vmm
Wed, Feb 18, 3:16 PM
andrew committed rGbfb7c81f93b5: nvmecontrol: Remove an incorrect use of PAGE_SIZE (authored by andrew).
nvmecontrol: Remove an incorrect use of PAGE_SIZE
Wed, Feb 18, 3:16 PM
andrew closed D55334: nvmecontrol: Remove an incorrect use of PAGE_SIZE.
Wed, Feb 18, 3:16 PM
andrew accepted D55284: intrng: Shuffle unhandled interrupts too.
Wed, Feb 18, 12:45 PM

Tue, Feb 17

andrew requested review of D55334: nvmecontrol: Remove an incorrect use of PAGE_SIZE.
Tue, Feb 17, 5:46 PM
andrew added inline comments to D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.
Tue, Feb 17, 4:15 PM
andrew added inline comments to D54960: virtio_blk: Use bus_dma for command/ack buffer allocations.
Tue, Feb 17, 12:19 PM
andrew updated subscribers of D54959: virtio: Use bus_dma for ring and indirect buffer allocations.

virtio_blk calls bus_dma_tag_set_iommu on PowerPC; would that not be needed for these new tags?

Tue, Feb 17, 12:06 PM
andrew added a comment to D55284: intrng: Shuffle unhandled interrupts too.

Do we want to zero the CPU for PPIs & IPIs? I expect that check should be before the handlers == 0 check as they may be sent to all CPUs.

Tue, Feb 17, 11:38 AM

Wed, Feb 11

andrew requested review of D55250: arm64: Have a common call to userret.
Wed, Feb 11, 6:13 PM

Tue, Feb 10

andrew closed D55147: vtgpu: Support virtio gpu on Parallels Desktop.
Tue, Feb 10, 5:07 PM
andrew committed rG1ea0721e1a56: vtgpu: Support virtio gpu on Parallels Desktop (authored by andrew).
vtgpu: Support virtio gpu on Parallels Desktop
Tue, Feb 10, 5:07 PM
andrew committed rG1224347817c4: arm64: Add MOPS implementations of copyin/copyout (authored by sarah.walker2_arm.com).
arm64: Add MOPS implementations of copyin/copyout
Tue, Feb 10, 3:44 PM
andrew committed rG7d7295df9b13: arm64: Add MOPS implementation of pagezero() (authored by sarah.walker2_arm.com).
arm64: Add MOPS implementation of pagezero()
Tue, Feb 10, 3:44 PM
andrew committed rG2ccbf06c0285: arm64: Add MOPS implementations of memset(), memcpy() and memmove() (authored by sarah.walker2_arm.com).
arm64: Add MOPS implementations of memset(), memcpy() and memmove()
Tue, Feb 10, 3:44 PM
andrew committed rG18af5a180b29: arm64: Enable MOPS usage in the kernel (authored by sarah.walker2_arm.com).
arm64: Enable MOPS usage in the kernel
Tue, Feb 10, 3:44 PM
andrew closed D54947: arm64: Add MOPS implementations of copyin/copyout.
Tue, Feb 10, 3:43 PM
andrew closed D54946: arm64: Add MOPS implementation of pagezero().
Tue, Feb 10, 3:43 PM
andrew closed D55051: arm64: Add MOPS implementations of memset(), memcpy() and memmove().
Tue, Feb 10, 3:43 PM
andrew closed D54943: arm64: Enable MOPS usage in the kernel.
Tue, Feb 10, 3:43 PM
andrew accepted D55051: arm64: Add MOPS implementations of memset(), memcpy() and memmove().
Tue, Feb 10, 3:26 PM
andrew added a comment to D55219: arm64: Add more HWCAP values.

These should be the same as Linux. Some userspace software defines these values if they are not already defined.

Tue, Feb 10, 3:11 PM
andrew requested review of D55219: arm64: Add more HWCAP values.
Tue, Feb 10, 2:04 PM
andrew accepted D55160: arm64: Explicitly use movz.

This appears to only be a problem for binutils for mov with :abs_g0_nc:

Tue, Feb 10, 11:59 AM
andrew accepted D55079: asan: Use memset_early() to fill shadow memory.
Tue, Feb 10, 10:41 AM

Mon, Feb 9

andrew added a comment to D55051: arm64: Add MOPS implementations of memset(), memcpy() and memmove().

It looks like this is missing the pmap changes for the sanitizer kernels.

Mon, Feb 9, 5:39 PM
andrew accepted D54946: arm64: Add MOPS implementation of pagezero().
Mon, Feb 9, 5:31 PM
andrew accepted D54947: arm64: Add MOPS implementations of copyin/copyout.
Mon, Feb 9, 5:31 PM
andrew accepted D54943: arm64: Enable MOPS usage in the kernel.
Mon, Feb 9, 5:27 PM
andrew committed rG1c41e411b554: arm64: Have get_kernel_reg return void (authored by andrew).
arm64: Have get_kernel_reg return void
Mon, Feb 9, 5:26 PM
andrew committed rGa8c393384044: arm64: Assume get_kernel_reg returns true (authored by andrew).
arm64: Assume get_kernel_reg returns true
Mon, Feb 9, 5:26 PM
andrew closed D55104: arm64: Panic if the ID register isn't known.
Mon, Feb 9, 5:26 PM
andrew closed D55106: arm64: Have get_kernel_reg return void.
Mon, Feb 9, 5:26 PM
andrew committed rG3b0b6aa2cd05: arm64: Panic if the ID register isn't known (authored by andrew).
arm64: Panic if the ID register isn't known
Mon, Feb 9, 5:25 PM
andrew closed D55105: arm64: Assume get_kernel_reg returns true.
Mon, Feb 9, 5:25 PM
andrew committed rG0ea31fe85134: arm64: Move creating the ID register views earlier (authored by andrew).
arm64: Move creating the ID register views earlier
Mon, Feb 9, 5:25 PM
andrew closed D55103: arm64: Move creating the ID register views earlier.
Mon, Feb 9, 5:25 PM
andrew committed rG6bea105bcd96: virtio_p9fs: Use VIRTIO_SIMPLE_PNPINFO (authored by andrew).
virtio_p9fs: Use VIRTIO_SIMPLE_PNPINFO
Mon, Feb 9, 4:34 PM
andrew committed rGbcb8b267f323: arm/gic: Detect broken configurations (authored by andrew).
arm/gic: Detect broken configurations
Mon, Feb 9, 4:34 PM
andrew committed rGe0fdcb8cafa2: arm64/vmm: Set and use the fine-grained traps (authored by andrew).
arm64/vmm: Set and use the fine-grained traps
Mon, Feb 9, 4:30 PM
andrew committed rG93ba7dce8954: arm64: Attach the vgic even if there is no ITS (authored by andrew).
arm64: Attach the vgic even if there is no ITS
Mon, Feb 9, 4:30 PM
andrew committed rG89776ce6a7b7: arm64: Add the Fine-Grained Trap registers (authored by andrew).
arm64: Add the Fine-Grained Trap registers
Mon, Feb 9, 4:30 PM
andrew committed rGc98aa51be91a: arm64/vmm: Add HYP_FEAT_FGT{,2} (authored by andrew).
arm64/vmm: Add HYP_FEAT_FGT{,2}
Mon, Feb 9, 4:30 PM
andrew committed rGc70a68bbdbf6: arm64: Fix kernel panic in get_arm64_sve during core dump (authored by william.a_carrel.org).
arm64: Fix kernel panic in get_arm64_sve during core dump
Mon, Feb 9, 4:29 PM
andrew committed rG5b818d9f3f4d: arm64: Fix MAIR_ATTR_MASK (authored by harry.moulton_arm.com).
arm64: Fix MAIR_ATTR_MASK
Mon, Feb 9, 4:29 PM
andrew committed rGb0d8e99424f6: crypto: Update sha256 and sha512 ifuncs to use passed HWCAP flags (authored by sarah.walker2_arm.com).
crypto: Update sha256 and sha512 ifuncs to use passed HWCAP flags
Mon, Feb 9, 4:29 PM
andrew committed rGd8e700f2eeb9: libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble (authored by sarah.walker2_arm.com).
libc/aarch64: Use MOPS implementations of memcpy/memmove/memset where availble
Mon, Feb 9, 4:29 PM
andrew committed rGdee5c2665452: libc/csu: Pass HWCAP flags to ifunc resolver functions (authored by sarah.walker2_arm.com).
libc/csu: Pass HWCAP flags to ifunc resolver functions
Mon, Feb 9, 4:29 PM
andrew committed rG067250e857b4: libc/aarch64: Add memset for a 64 byte dc zva (authored by andrew).
libc/aarch64: Add memset for a 64 byte dc zva
Mon, Feb 9, 4:29 PM
andrew committed rGdd8075045315: rtld-elf: Pass HWCAP flags to ifunc resolver functions (authored by sarah.walker2_arm.com).
rtld-elf: Pass HWCAP flags to ifunc resolver functions
Mon, Feb 9, 4:29 PM
andrew committed rG2a9a92ba7bd7: arm64: Enable MOPS in userspace (authored by sarah.walker2_arm.com).
arm64: Enable MOPS in userspace
Mon, Feb 9, 4:29 PM
andrew committed rGdb96d49bdebf: libc/aarch64: Split out the MOPS functions (authored by andrew).
libc/aarch64: Split out the MOPS functions
Mon, Feb 9, 4:29 PM
andrew committed rGd8d8be5bbcae: arm64: Provide ifunc HWCAP structure definitions (authored by sarah.walker2_arm.com).
arm64: Provide ifunc HWCAP structure definitions
Mon, Feb 9, 4:29 PM
andrew committed rG5ca05e51c861: arm64: Fix jump to wrong label in case of 0 entries (authored by cingel.marian_gmail.com).
arm64: Fix jump to wrong label in case of 0 entries
Mon, Feb 9, 4:29 PM
andrew committed rG565f47e8f470: arm64: Add FEAT_MOPS register fields (authored by sarah.walker2_arm.com).
arm64: Add FEAT_MOPS register fields
Mon, Feb 9, 4:29 PM
andrew committed rG50144c002555: libc/aarch64: Add a Makefile.inc dependency (authored by andrew).
libc/aarch64: Add a Makefile.inc dependency
Mon, Feb 9, 4:29 PM
andrew updated the diff for D55147: vtgpu: Support virtio gpu on Parallels Desktop.

Add a comment

Mon, Feb 9, 9:56 AM
andrew added a comment to D55012: virtio_gpu: add support for xf86-video-scfb.

What is the overhead form all the extra wakeups this adds? I'd prefer we add a way for userspace to tell the kernel to perform an update.

Mon, Feb 9, 9:16 AM

Fri, Feb 6

andrew updated the test plan for D55147: vtgpu: Support virtio gpu on Parallels Desktop.
Fri, Feb 6, 5:55 PM
andrew requested review of D55147: vtgpu: Support virtio gpu on Parallels Desktop.
Fri, Feb 6, 5:52 PM
andrew added a comment to D55075: kern linker: Mark link_elf_ireloc as no-KASAN.

Does D55079 fix the problem for you?

Fri, Feb 6, 11:24 AM

Thu, Feb 5

andrew committed rGc12d6cc326b7: arm64: Attach the vgic even if there is no ITS (authored by andrew).
arm64: Attach the vgic even if there is no ITS
Thu, Feb 5, 2:03 PM
andrew closed D54791: arm64: Attach the vgic even if there is no ITS.
Thu, Feb 5, 2:03 PM

Wed, Feb 4

andrew added a comment to D55104: arm64: Panic if the ID register isn't known.

The only user of get_kernel_reg_iss_masked that I know about is vmm, however get_kernel_reg_iss is used via the get_kernel_reg macro in many places, see D55105 for the full list.

Wed, Feb 4, 5:42 PM
andrew added a comment to D54943: arm64: Enable MOPS usage in the kernel.

D55103 moves it earlier, along with other cleanups.

Wed, Feb 4, 5:38 PM
andrew requested review of D55106: arm64: Have get_kernel_reg return void.
Wed, Feb 4, 5:27 PM
andrew requested review of D55104: arm64: Panic if the ID register isn't known.
Wed, Feb 4, 5:27 PM
andrew requested review of D55105: arm64: Assume get_kernel_reg returns true.
Wed, Feb 4, 5:27 PM
andrew requested review of D55103: arm64: Move creating the ID register views earlier.
Wed, Feb 4, 5:27 PM

Tue, Feb 3

andrew committed rGa4f0e93c5142: arm64/vmm: Set and use the fine-grained traps (authored by andrew).
arm64/vmm: Set and use the fine-grained traps
Tue, Feb 3, 5:28 PM
andrew committed rG4f82ce5191d5: arm64: Add the Fine-Grained Trap registers (authored by andrew).
arm64: Add the Fine-Grained Trap registers
Tue, Feb 3, 5:28 PM
andrew committed rG095a7871f432: arm64/vmm: Add HYP_FEAT_FGT{,2} (authored by andrew).
arm64/vmm: Add HYP_FEAT_FGT{,2}
Tue, Feb 3, 5:28 PM
andrew committed rG2f3f5055e7f6: virtio_p9fs: Use VIRTIO_SIMPLE_PNPINFO (authored by andrew).
virtio_p9fs: Use VIRTIO_SIMPLE_PNPINFO
Tue, Feb 3, 5:28 PM