Page MenuHomeFreeBSD

andrew (Andrew Turner)
User

Projects

User Details

User Since
May 10 2014, 2:21 PM (584 w, 1 d)

Recent Activity

Fri, Jul 18

andrew requested review of D51413: kboot: Support reading the smbios vis sysfs.
Fri, Jul 18, 3:55 PM
andrew updated the diff for D51380: lib: Move libopencsd to /usr/lib and make private.

Rebase + remove libopencsd-all.ucl

Fri, Jul 18, 11:41 AM
andrew added inline comments to D51380: lib: Move libopencsd to /usr/lib and make private.
Fri, Jul 18, 11:40 AM
andrew requested review of D51406: arm64: Add ADDR_IS_USER.
Fri, Jul 18, 10:59 AM

Thu, Jul 17

andrew requested review of D51380: lib: Move libopencsd to /usr/lib and make private.
Thu, Jul 17, 4:26 PM
andrew added a comment to D51374: packages: add package ucl for libopencsd-all.

I'm unsure why the libopencsd needs to exist, it will be used by the userspace hwt tool (D40728) to decode trace data from the CPU.

Thu, Jul 17, 3:37 PM
andrew requested review of D51378: arm64: Use xzr directly to set HCRX_EL2.
Thu, Jul 17, 3:20 PM
andrew requested review of D51377: arm64: Set CNTPOFF_EL2 when it's implemented.
Thu, Jul 17, 3:20 PM
andrew requested review of D51376: arm64: Add CNTPOFF_EL2 op/CR values.
Thu, Jul 17, 3:20 PM
andrew requested review of D51375: arm64: Teach CHECK_CPU_FEAT to handle more values.
Thu, Jul 17, 3:20 PM
andrew accepted D51353: pmap_enter_{l2,pde}: correct the handling of an error case.

Is my reading of the code correct where uwptpg == NULL in the new else case because it's only set for userspace maps? If so it means we will call pmap_remove_pt_page.

Thu, Jul 17, 1:10 PM
andrew requested review of D51370: arm64: Rename ID_AA64MMFR0_ECV_CNTHCTL.
Thu, Jul 17, 11:33 AM
andrew requested review of D51369: arm64: Fix the sign in ID registers.
Thu, Jul 17, 11:32 AM

Wed, Jul 16

andrew added inline comments to D51353: pmap_enter_{l2,pde}: correct the handling of an error case.
Wed, Jul 16, 6:27 PM

Tue, Jul 15

andrew requested review of D51330: subr_intr: Support per-CPU IPI vectors.
Tue, Jul 15, 4:36 PM

Fri, Jul 11

andrew added a reviewer for D51257: dev/ofw: Add interrupt-map support: nwhitehorn.
Fri, Jul 11, 10:41 AM
andrew added reviewers for D51257: dev/ofw: Add interrupt-map support: ARM, PowerPC, riscv.
Fri, Jul 11, 10:30 AM
andrew requested review of D51258: modules/dtb: Add the ARM dtb module.
Fri, Jul 11, 10:29 AM
andrew requested review of D51257: dev/ofw: Add interrupt-map support.
Fri, Jul 11, 10:29 AM

Thu, Jul 3

andrew accepted D51088: gpio: attach gpiobus when the controller is ready.
Thu, Jul 3, 8:34 AM
andrew accepted D51133: gpiobus: add a gpiobus_add_bus function.
Thu, Jul 3, 8:31 AM

Wed, Jul 2

andrew accepted D51108: gpio: remove redundant calls to bus_attach_children.

We could create a version gpiobus_attach_bus that doesn't call bus_attach_children for use by multi-function devices. That would mean all buses are added together for more control.

Wed, Jul 2, 4:45 PM
andrew committed rG0e0576700fbe: arm64: Only set HCR_EL2.E2H when VHE is supported (authored by andrew).
arm64: Only set HCR_EL2.E2H when VHE is supported
Wed, Jul 2, 10:03 AM
andrew committed rGeba385011bfe: arm64: Use CHECK_CPU_FEAT to check for VHE (authored by andrew).
arm64: Use CHECK_CPU_FEAT to check for VHE
Wed, Jul 2, 10:03 AM
andrew closed D51103: arm64: Only set HCR_EL2.E2H when VHE is supported.
Wed, Jul 2, 10:03 AM
andrew committed rG51da2dd34416: arm64: Fix a typo (authored by andrew).
arm64: Fix a typo
Wed, Jul 2, 10:03 AM
andrew closed D51102: arm64: Use CHECK_CPU_FEAT to check for VHE.
Wed, Jul 2, 10:02 AM
andrew committed rGe80cb2254414: arm64: Export the pointer auth ID fields (authored by andrew).
arm64: Export the pointer auth ID fields
Wed, Jul 2, 10:02 AM
andrew closed D50982: arm64: Export the pointer auth ID fields.
Wed, Jul 2, 10:02 AM

Tue, Jul 1

andrew added inline comments to D51088: gpio: attach gpiobus when the controller is ready.
Tue, Jul 1, 1:27 PM
andrew requested review of D51103: arm64: Only set HCR_EL2.E2H when VHE is supported.
Tue, Jul 1, 12:36 PM
andrew requested review of D51102: arm64: Use CHECK_CPU_FEAT to check for VHE.
Tue, Jul 1, 12:35 PM
andrew committed rG5d0cf80f4501: Makefile.inc1: Always have which succeed (authored by andrew).
Makefile.inc1: Always have which succeed
Tue, Jul 1, 12:30 PM
andrew closed D51075: Makefile.inc1: Always have which succeed.
Tue, Jul 1, 12:30 PM

Fri, Jun 27

andrew requested review of D51075: Makefile.inc1: Always have which succeed.
Fri, Jun 27, 4:18 PM
andrew added a comment to D51067: (draft) if: Ensure additions to groups are visible to readers.

FreeBSD requires all CPUs to be in the same Inner Shareable domain so using ish is correct. This is the same requirement as Linux.

Fri, Jun 27, 12:58 PM
andrew added a comment to D51067: (draft) if: Ensure additions to groups are visible to readers.

I don't think we need the fence here. Assuming the compiler doesn't reorder any of the barriers and memory operations then as long as the store in CK_STAILQ_INSERT_TAIL has been observed on another CPU then the stores before CK_STAILQ_INSERT_TAIL will also be observed.

Fri, Jun 27, 11:10 AM

Wed, Jun 25

andrew committed rG5ec268d09a2e: dev/psci: Use the correct SMCCC TRNG field (authored by andrew).
dev/psci: Use the correct SMCCC TRNG field
Wed, Jun 25, 11:23 AM
andrew committed rG4e17c5fc501d: dev/psci: Use an SMCCC return value (authored by andrew).
dev/psci: Use an SMCCC return value
Wed, Jun 25, 11:23 AM
andrew committed rG288ba78edcfd: dev/psci: Check for functions before calling (authored by andrew).
dev/psci: Check for functions before calling
Wed, Jun 25, 11:23 AM
andrew closed D50979: dev/psci: Use the correct SMCCC TRNG field.
Wed, Jun 25, 11:23 AM
andrew closed D50978: dev/psci: Check for functions before calling.
Wed, Jun 25, 11:23 AM
andrew closed D50977: dev/psci: Use an SMCCC return value.
Wed, Jun 25, 11:23 AM
andrew added inline comments to D50979: dev/psci: Use the correct SMCCC TRNG field.
Wed, Jun 25, 9:30 AM
andrew committed rGfc04d82226e5: arm64: Add AT_HWCAP3 and AT_HWCAP4 support (authored by andrew).
arm64: Add AT_HWCAP3 and AT_HWCAP4 support
Wed, Jun 25, 9:26 AM
andrew committed rG28fd9bceba1d: rtld-elf: Add Add AT_HWCAP3 and AT_HWCAP4 (authored by andrew).
rtld-elf: Add Add AT_HWCAP3 and AT_HWCAP4
Wed, Jun 25, 9:26 AM
andrew committed rGfa1c23da01e0: libsys: Add AT_HWCAP3 and AT_HWCAP4 (authored by andrew).
libsys: Add AT_HWCAP3 and AT_HWCAP4
Wed, Jun 25, 9:26 AM
andrew committed rG85007872d122: sys: Add AT_HWCAP3 and AT_HWCAP4 (authored by andrew).
sys: Add AT_HWCAP3 and AT_HWCAP4
Wed, Jun 25, 9:26 AM
andrew closed D51008: arm64: Add AT_HWCAP3 and AT_HWCAP4 support.
Wed, Jun 25, 9:26 AM
andrew closed D51007: rtld-elf: Add Add AT_HWCAP3 and AT_HWCAP4.
Wed, Jun 25, 9:26 AM
andrew closed D51006: libsys: Add AT_HWCAP3 and AT_HWCAP4.
Wed, Jun 25, 9:26 AM
andrew closed D51005: sys: Add AT_HWCAP3 and AT_HWCAP4.
Wed, Jun 25, 9:26 AM

Tue, Jun 24

andrew added a comment to D50978: dev/psci: Check for functions before calling.

If the firmware doesn't implement the Errata ABI then we may enable a workaround in the kernel even if we don't need to, e.g. when the firmware already has a workaround, or the combination of HW means it's not needed

Tue, Jun 24, 2:36 PM
andrew requested review of D51013: arm64: Enable EPAN and IESB.
Tue, Jun 24, 2:27 PM
andrew requested review of D51012: arm64: Set the endian without a memory access.
Tue, Jun 24, 2:27 PM
andrew requested review of D51011: arm64: Use a fixed value for sctlr_el1.
Tue, Jun 24, 2:27 PM
andrew updated the diff for D51005: sys: Add AT_HWCAP3 and AT_HWCAP4.

Fix the LINUX_AT_HWCAP* comments

Tue, Jun 24, 1:02 PM
andrew updated the diff for D51008: arm64: Add AT_HWCAP3 and AT_HWCAP4 support.

Update LINUX_AT_COUNT to fix a kernel panic

Tue, Jun 24, 12:59 PM
andrew requested review of D51008: arm64: Add AT_HWCAP3 and AT_HWCAP4 support.
Tue, Jun 24, 11:41 AM
andrew requested review of D51007: rtld-elf: Add Add AT_HWCAP3 and AT_HWCAP4.
Tue, Jun 24, 11:41 AM
andrew requested review of D51006: libsys: Add AT_HWCAP3 and AT_HWCAP4.
Tue, Jun 24, 11:40 AM
andrew requested review of D51005: sys: Add AT_HWCAP3 and AT_HWCAP4.
Tue, Jun 24, 11:40 AM

Mon, Jun 23

andrew requested review of D50982: arm64: Export the pointer auth ID fields.
Mon, Jun 23, 5:08 PM
andrew committed rGfe55780e5f10: arm64: Enable pointer authentication with QARMA3 (authored by andrew).
arm64: Enable pointer authentication with QARMA3
Mon, Jun 23, 4:34 PM
andrew closed D49710: arm64: Enable pointer authentication with QARMA3.
Mon, Jun 23, 4:34 PM
andrew committed rGcbc2e34613c4: virtio_blk: Limit use of indirect descriptors (authored by andrew).
virtio_blk: Limit use of indirect descriptors
Mon, Jun 23, 1:20 PM
andrew committed rG124b5dbf5c09: arm64: Add more CPU MIDR values (authored by andrew).
arm64: Add more CPU MIDR values
Mon, Jun 23, 1:20 PM
andrew closed D50726: arm64: Add more CPU MIDR values.
Mon, Jun 23, 1:20 PM
andrew closed D50909: virtio_blk: Limit use of indirect descriptors.
Mon, Jun 23, 1:20 PM
andrew requested review of D50979: dev/psci: Use the correct SMCCC TRNG field.
Mon, Jun 23, 12:46 PM
andrew requested review of D50978: dev/psci: Check for functions before calling.
Mon, Jun 23, 12:46 PM
andrew requested review of D50977: dev/psci: Use an SMCCC return value.
Mon, Jun 23, 12:46 PM
andrew committed rGb47a6c93e262: arm64: Reduce where we decode msr/mrs instructions (authored by andrew).
arm64: Reduce where we decode msr/mrs instructions
Mon, Jun 23, 12:08 PM
andrew committed rG1e4b86aaf28a: arm64: Remove the MRS_REG macro and it's users (authored by andrew).
arm64: Remove the MRS_REG macro and it's users
Mon, Jun 23, 12:08 PM
andrew committed rG128085a3e7f3: arm64: Use ISS to search for a special register (authored by andrew).
arm64: Use ISS to search for a special register
Mon, Jun 23, 12:08 PM
andrew committed rG59486443cccd: arm64: Remove extract_user_id_field (authored by andrew).
arm64: Remove extract_user_id_field
Mon, Jun 23, 12:08 PM
andrew closed D50214: arm64: Reduce where we decode msr/mrs instructions.
Mon, Jun 23, 12:08 PM
andrew closed D50906: arm64: Remove the MRS_REG macro and it's users.
Mon, Jun 23, 12:08 PM
andrew committed rGf820b6ed34d5: arm64: Switch to get_user_reg in fill_dbregs (authored by andrew).
arm64: Switch to get_user_reg in fill_dbregs
Mon, Jun 23, 12:08 PM
andrew committed rG3113ac28cf84: arm64: Add get_user_reg (authored by andrew).
arm64: Add get_user_reg
Mon, Jun 23, 12:08 PM
andrew closed D50905: arm64: Use ISS to search for a special register.
Mon, Jun 23, 12:08 PM
andrew closed D50904: arm64: Remove extract_user_id_field.
Mon, Jun 23, 12:08 PM
andrew closed D50903: arm64: Switch to get_user_reg in fill_dbregs.
Mon, Jun 23, 12:08 PM
andrew closed D50902: arm64: Add get_user_reg.
Mon, Jun 23, 12:08 PM

Jun 17 2025

andrew requested review of D50909: virtio_blk: Limit use of indirect descriptors.
Jun 17 2025, 3:18 PM
andrew committed rGea8dc498aa8e: arm64: Create an L3 table to limit permissions (authored by andrew).
arm64: Create an L3 table to limit permissions
Jun 17 2025, 1:29 PM
andrew closed D45064: arm64: Create an L3 table to limit permissions.
Jun 17 2025, 1:29 PM
andrew updated the diff for D50214: arm64: Reduce where we decode msr/mrs instructions.

Rebase on D50906 to move all MRS_ macros to undefined.c

Jun 17 2025, 1:26 PM
andrew updated the summary of D50214: arm64: Reduce where we decode msr/mrs instructions.
Jun 17 2025, 1:25 PM
andrew requested review of D50906: arm64: Remove the MRS_REG macro and it's users.
Jun 17 2025, 1:23 PM
andrew requested review of D50905: arm64: Use ISS to search for a special register.
Jun 17 2025, 1:23 PM
andrew requested review of D50904: arm64: Remove extract_user_id_field.
Jun 17 2025, 1:23 PM
andrew requested review of D50903: arm64: Switch to get_user_reg in fill_dbregs.
Jun 17 2025, 1:23 PM
andrew requested review of D50902: arm64: Add get_user_reg.
Jun 17 2025, 1:22 PM

Jun 16 2025

andrew updated the diff for D45064: arm64: Create an L3 table to limit permissions.

Update based on feedback from @alc

Jun 16 2025, 2:46 PM

Jun 12 2025

andrew committed rGe6928c33f60c: arm64: Reduce the kernel executable pages (authored by andrew).
arm64: Reduce the kernel executable pages
Jun 12 2025, 9:50 AM
andrew committed rG95059bef2437: arm64: Use tables to find early page tables (authored by andrew).
arm64: Use tables to find early page tables
Jun 12 2025, 9:50 AM
andrew closed D45063: arm64: Reduce the kernel executable pages.
Jun 12 2025, 9:49 AM
andrew closed D45062: arm64: Use tables to find early page tables.
Jun 12 2025, 9:49 AM

Jun 11 2025

andrew committed rGd41a2ba73cbe: scmi: Avoid a use-after-free (authored by andrew).
scmi: Avoid a use-after-free
Jun 11 2025, 9:35 AM