Differential D51375

arm64: Teach CHECK_CPU_FEAT to handle more values
ClosedPublic
Actions

Authored by andrew on Jul 17 2025, 3:20 PM.

Details

Reviewers

manu

Group Reviewers

arm64

Commits

rG8986e15f0bb5: arm64: Teach CHECK_CPU_FEAT to handle more values

Summary

CHECK_CPU_FEAT only supported checking for features that were enabled
when the field is non-zero. There are some features we might need to
check where we move between two non-zero values.

Support this by passing in the field value name to compare rather than
assuming a non-zero value.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jul 17 2025, 3:20 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 17 2025, 3:20 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Jul 17 2025, 3:20 PM

Harbormaster completed remote builds in B65517: Diff 158669.Jul 17 2025, 3:20 PM

andrew added a child revision: D51376: arm64: Add CNTPOFF_EL2 op/CR values.Jul 17 2025, 3:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 4 2025, 11:15 AM

Closed by commit rG8986e15f0bb5: arm64: Teach CHECK_CPU_FEAT to handle more values (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG8986e15f0bb5: arm64: Teach CHECK_CPU_FEAT to handle more values.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

locore.S

8 lines

include/

asm.h

7 lines

Diff 159705

View Options

sys/arm64/arm64/locore.S