arm64: Add ADDR_IS_USER
ClosedPublic
Actions

Authored by andrew on Jul 18 2025, 10:59 AM.

Details

Reviewers

alc
kib
markj
manu

Group Reviewers

arm64

Commits

rG16597773bc90: arm64: Add ADDR_IS_USER

Summary

In most of the places we used ADDR_IS_KERNEL to decide which address
space was being used it was to see if the address was for userspace.

To make the checks more descriptive add ADDR_IS_USER rather than
checking for not ADDR_IS_KERNEL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jul 18 2025, 10:59 AM

Herald added a reviewer: manu. · View Herald TranscriptJul 18 2025, 10:59 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Jul 18 2025, 10:59 AM

Harbormaster completed remote builds in B65557: Diff 158732.Jul 18 2025, 10:59 AM

kib accepted this revision.Jul 18 2025, 12:13 PM

kib added inline comments.

sys/arm64/include/vmparam.h
216	Might be test the bit 55 is 0 instead of using !ADDR_IS_KERNEL(). Also the comment in line 214 can be updated, or a new comment line added.

This revision is now accepted and ready to land.Jul 18 2025, 12:13 PM

markj accepted this revision.Jul 18 2025, 2:24 PM

alc accepted this revision.Jul 18 2025, 5:22 PM

Closed by commit rG16597773bc90: arm64: Add ADDR_IS_USER (authored by andrew). · Explain WhyAug 6 2025, 5:38 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG16597773bc90: arm64: Add ADDR_IS_USER.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

pmap.c

32 lines

include/

vmparam.h

2 lines

Diff 159886

View Options

sys/arm64/arm64/pmap.c