virtio_blk: Limit use of indirect descriptors
ClosedPublic
Actions

Authored by andrew on Jun 17 2025, 3:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 17, 1:21 AM

	Unknown Object (File)
	Sun, May 17, 1:21 AM

	Unknown Object (File)
	Sun, May 17, 1:11 AM

	Unknown Object (File)
	Fri, May 15, 3:03 PM

	Unknown Object (File)
	Fri, May 15, 11:06 AM

	Unknown Object (File)
	Fri, May 15, 3:18 AM

	Unknown Object (File)
	Fri, May 15, 12:21 AM

	Unknown Object (File)
	Tue, May 12, 6:42 AM

View All 65 Files

Subscribers

imp

Details

Reviewers

bryanv
harry.moulton_arm.com

Commits

rGcbc2e34613c4: virtio_blk: Limit use of indirect descriptors

Summary

Pass 0 as the number of indirect descriptors when they are not
supported.

This fixes an issue on the Arm FVP model where we don't negotiate
them, however pass a number of segments greater than
VIRTIO_MAX_INDIRECT. This leads to virtqueue_alloc failing and
virtio_blk failing to attach.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jun 17 2025, 3:18 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 17 2025, 3:18 PM

andrew requested review of this revision.Jun 17 2025, 3:18 PM

Harbormaster completed remote builds in B64944: Diff 157184.Jun 17 2025, 3:18 PM

harry.moulton_arm.com accepted this revision.Jun 19 2025, 11:59 AM

This revision is now accepted and ready to land.Jun 19 2025, 11:59 AM

Closed by commit rGcbc2e34613c4: virtio_blk: Limit use of indirect descriptors (authored by andrew). · Explain WhyJun 23 2025, 1:20 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGcbc2e34613c4: virtio_blk: Limit use of indirect descriptors.

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

block/

virtio_blk.c

6 lines

Diff 157452

View Options

sys/dev/virtio/block/virtio_blk.c

virtio_blk: Limit use of indirect descriptorsClosedPublicActions