In D17454#375324, @bapt wrote:

fine with me. my plan was in long term to extend mandoc's man.conf to have the missing features we have in our man(1) like able to read: /usr/local/etc/man.d/*
And then swictch fully to upstream's man.conf and remove our man(1), so go ahead for your patch :)

In D17454#375268, @bapt wrote:

We could bring again apropos and whatis as hardlinks to man(1) moving the binaries in libexec so manpath is built before calling them as well

In D17454#375266, @bapt wrote:

what about building MANPATH before calling apropos in man(1) ?

That would be less intrusive

In D17449#375264, @bapt wrote:

First we should ship the said manpage :)

I think this is debattable, but I think upstream is opened enought to accept such change, you should anyway talk to them to see if that will remain a freebsd only patch or not :)

In D17575#375226, @eugen_grosbein.net wrote:

Looks good. While you are here, please also replace last "/etc" literal in the pw.c's main() function with _PATH_PWD used with all other places of pw(1) sources.

Suggestion from Eugene.

In D17566#374930, @eugen_grosbein.net wrote:

In D17566#374928, @yuripv wrote:

In D17566#374923, @eugen_grosbein.net wrote:

While the change seems to be semantically right, I don't really like we have more and more places with hard-coded "pw.conf" in the pw(8) sources.

Could you please to add #define _PW_CONF "pw.conf" to pw.h and use "%s/" _PW_CONF (concatenation of C string literals) instead of "%s/pw.conf" ? And make same change to pw_utils.c' get_userconfig() function too, while you are here.

Sure, done.

I have not asked to touch _PATH_PW_CONF in the pw.h and I'm not sure it is completely correct to change it like this, with space and without parenthesis. I'd like to change it back as it was to be sure.

In D17566#374923, @eugen_grosbein.net wrote:

While the change seems to be semantically right, I don't really like we have more and more places with hard-coded "pw.conf" in the pw(8) sources.

Could you please to add #define _PW_CONF "pw.conf" to pw.h and use "%s/" _PW_CONF (concatenation of C string literals) instead of "%s/pw.conf" ? And make same change to pw_utils.c' get_userconfig() function too, while you are here.

Add and use _PW_CONF instead of hardcoding "pw.conf".

In D17566#374919, @bapt wrote:

if you can provide a regression test, that would be nice

In D17550#374675, @kib wrote:

In D17550#374670, @yuripv wrote:

In D17550#374655, @kib wrote:

So we apparently have Y2K bug ?

If you mean the negative values for tm_year, then it likely should be called Y1.9K bug. Otherwise, we seem to have followed the standard, just didn't care about %C and %y both appearing in the format string in arbitrary order.

I mean that %y%C leads to invalid century.

In D17550#374655, @kib wrote:

So we apparently have Y2K bug ?

style

In D17546#374448, @ngie wrote:

Regarding this comment, do you mean that the test fails when you remove the atf_tc_expect_fail call on 231-234? If so, please restore that line, but feel free to update the message to improve the clarity, since what I put in there a couple years back is pretty vague.

Agreed, this needs to be looked at, and according to tests results, there are a lot more issues with strptime() (comparing with standard and linux output as well).

simplify even more

simplify the check

style fixes

Address comments.

copy/paste error

In D17473#373892, @sbruno wrote:

@yuripv Do you want me to commit this or are you going to be able to send the request to release engineering?

https://wiki.freebsd.org/Releng/ChangeRequestGuidelines

Sorry, I forgot to add the output from devmatch -d for fixed versions. Done now.

full context

update copyright

Looks good.

Please provide the diff with full context, e.g. by using -U10000 (a number big enough to include entire file contents) for git diff or git log.

The order currently follows what we have in the actual top output, and seems logically more correct than sorting alphabetically.

So.. if this looks all good, can anyone please commit it? :)

Address review comments.

In D17321#369299, @cem wrote:

I am unfamiliar with usage of T, but assuming the example provided is correct, I agree that adding an example is a good idea. (And the markup/text changes look good.)

add fix for PR231653 helping added test cases

add test case

In D17267#367979, @johalun0_gmail.com wrote:

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

Looks good to me, FWIW.

Please provide the diff with full context, e.g. by using -U with number of lines big enough to include full file contents if you are using git diff or git log -p.

use bus_generic_detach().

I don't see an easy way to check for leftovers in the working directory using standard kyua commands, so simply add the check for '.!'* files to all inplace cases.

Fixes the issue for me, ums.ko is correctly auto-loaded.

Add a simple test case (hopefully not TOO simple).

In D16798#357446, @markj wrote:

This seems reasonable to me. Would you be willing to add a regression test?