Page MenuHomeFreeBSD

johalun0_gmail.com (Johannes Lundberg)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 13 2016, 9:42 PM (122 w, 13 h)

Recent Activity

Thu, Dec 13

johalun0_gmail.com abandoned D13431: [new port] x11/wm-sway: i3-compatible Wayland compositor.

Yeah, Sway is on hold until we can find time to get the new version that is based on wlroots ported. I might give this a shot during the holidays. Marking this as abandoned.

Thu, Dec 13, 11:08 AM

Sun, Nov 25

johalun0_gmail.com added inline comments to D18328: [WIP] drm ports: move .
Sun, Nov 25, 9:53 PM
johalun0_gmail.com added a comment to D18328: [WIP] drm ports: move .

I created the necessary git branches to point these ports to. It would be good if we could let 11.2 use 4.11 so we can scrap 4.9 all together (and thus remove some legacy code from lkpi).

Sun, Nov 25, 12:00 PM

Tue, Nov 20

johalun0_gmail.com accepted D18052: Summary: linuxkpi: Add some basic swap functions These are used by kms-drm to determine various heuristics related to low memory conditions..
Tue, Nov 20, 7:38 AM

Nov 1 2018

johalun0_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Thanks for doing this! Works great on my Dell 7490.
Suspend/resume not tested. Please also add EVDEV to this driver so we can get things like horizontal scrolling :)

Nov 1 2018, 11:10 AM · Contributor Reviews (base)

Oct 31 2018

johalun0_gmail.com added inline comments to D17775: Commit candidate for D16719.
Oct 31 2018, 3:03 PM
johalun0_gmail.com accepted D17775: Commit candidate for D16719.
Oct 31 2018, 8:59 AM

Oct 29 2018

johalun0_gmail.com updated the diff for D16719: Add pci_early function for Intel stolen memory (and possibly more).

Fix comments.

Oct 29 2018, 12:39 PM
johalun0_gmail.com added inline comments to D16719: Add pci_early function for Intel stolen memory (and possibly more).
Oct 29 2018, 12:39 PM

Oct 25 2018

johalun0_gmail.com updated the diff for D16719: Add pci_early function for Intel stolen memory (and possibly more).

Changes: Disable phys_avail until KPI is in.

Oct 25 2018, 12:39 PM

Oct 24 2018

johalun0_gmail.com added inline comments to D17431: phys_avail manipulation routine.
Oct 24 2018, 7:59 AM

Oct 23 2018

johalun0_gmail.com added inline comments to D17431: phys_avail manipulation routine.
Oct 23 2018, 3:19 PM

Oct 22 2018

johalun0_gmail.com added a comment to D16660: devmatch ugly hack.
In D16660#376951, @imp wrote:

So why the special case for vgapci0?

Oct 22 2018, 3:57 PM
johalun0_gmail.com added a comment to D16660: devmatch ugly hack.
In D16660#376945, @imp wrote:

I have no clue what this is trying to fix.
I am aware of a bug that we need to read all the files in the path (which part of this does), but the special case for vgapci0 seems unwarranted and dangerous.
So there's some relevance to this, but I have some concerns.

Oct 22 2018, 3:32 PM
johalun0_gmail.com added a comment to D16660: devmatch ugly hack.

Ping is this patch still relevant?

Oct 22 2018, 9:35 AM

Oct 9 2018

johalun0_gmail.com updated the diff for D17431: phys_avail manipulation routine.

Patch srat.c to use phys_avail_reserve()

Oct 9 2018, 1:20 PM
johalun0_gmail.com added inline comments to D17431: phys_avail manipulation routine.
Oct 9 2018, 9:11 AM

Oct 8 2018

johalun0_gmail.com updated the diff for D16719: Add pci_early function for Intel stolen memory (and possibly more).

physmem.h has moved from machine/ to x86/

Oct 8 2018, 11:54 AM

Oct 5 2018

johalun0_gmail.com updated the test plan for D16719: Add pci_early function for Intel stolen memory (and possibly more).
Oct 5 2018, 1:12 PM
johalun0_gmail.com updated the diff for D16719: Add pci_early function for Intel stolen memory (and possibly more).

phys_avail_reserve has been moved to a separate diff https://reviews.freebsd.org/D17431 and this diff should be applied after D17431.

Oct 5 2018, 1:02 PM
johalun0_gmail.com created D17431: phys_avail manipulation routine.
Oct 5 2018, 1:00 PM
johalun0_gmail.com updated the summary of D16719: Add pci_early function for Intel stolen memory (and possibly more).
Oct 5 2018, 12:57 PM

Sep 21 2018

johalun0_gmail.com added a comment to D17267: We don't need shell protection for when we're expanding matches. Don't add it. This should fix when we do regepx matches against variables we've set and fix wifi bring up..
In D17267#368025, @yuripv_yuripv.net wrote:

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

Weird, works for me, and regex in Testing device-name line looks correct now without any changes to devd.conf. Make sure you are running correct binary?

Sep 21 2018, 8:48 AM
johalun0_gmail.com added a comment to D17267: We don't need shell protection for when we're expanding matches. Don't add it. This should fix when we do regepx matches against variables we've set and fix wifi bring up..

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

Sep 21 2018, 7:26 AM

Sep 10 2018

johalun0_gmail.com accepted D17109: Style fixes for in6_pcblookup_lbgroup()..
Sep 10 2018, 7:19 PM

Sep 6 2018

johalun0_gmail.com accepted D17065: Use ratecheck(9) in in_pcbinslbgrouphash()..
Sep 6 2018, 6:30 PM
johalun0_gmail.com accepted D17031: Fix synchronization of lbgroup access..

Yeah, CK work was committed soon after so_reuseport_lb was merged so this was missed. Thanks for fixing!

Sep 6 2018, 3:27 PM

Sep 5 2018

johalun0_gmail.com accepted D17030: Fix style bugs in in_pcblookup_lbgroup()..

Thanks for cleaning this up.

Sep 5 2018, 7:40 AM

Aug 27 2018

johalun0_gmail.com added inline comments to D16719: Add pci_early function for Intel stolen memory (and possibly more).
Aug 27 2018, 2:45 PM
johalun0_gmail.com added inline comments to D16719: Add pci_early function for Intel stolen memory (and possibly more).
Aug 27 2018, 7:56 AM

Aug 26 2018

johalun0_gmail.com accepted D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

LGTM and I assume there's another patch coming that will fix the loader issues?

Aug 26 2018, 3:09 PM
johalun0_gmail.com accepted D16899: SO_REUSEPORT_LB critical bug fix: avoid IPv4 listen group in IPv6.

Thanks for finding and fixing this!

Aug 26 2018, 12:37 PM

Aug 24 2018

johalun0_gmail.com added a comment to D16876: Expand min/max_offset macros in vm_map.h to reduce pollution.

Thank you <3 This will make life easier for us drm developers.

Aug 24 2018, 7:19 AM

Aug 15 2018

johalun0_gmail.com added a comment to D16719: Add pci_early function for Intel stolen memory (and possibly more).
In D16719#355599, @imp wrote:

This strikes me as two different changes. One for the phys_avail_reserve() and another to use it for the pci early stuff. I'm a little uneasy with the pci early name, but the code is clearly PCI specific.
Would there ever be a need to do things like this when running the 32-bit kernel? I know we don't support graphics cards there, but when we're bringing in new interfaces, it's a question that suggests itself.
RPi has this sort of thing too, but it's dealt with in the bowels of the FDT code...

Aug 15 2018, 4:18 PM
johalun0_gmail.com created D16719: Add pci_early function for Intel stolen memory (and possibly more).
Aug 15 2018, 12:45 PM

Aug 10 2018

johalun0_gmail.com updated the summary of D16660: devmatch ugly hack.
Aug 10 2018, 5:52 PM
johalun0_gmail.com updated the summary of D16660: devmatch ugly hack.
Aug 10 2018, 5:24 PM
johalun0_gmail.com created D16660: devmatch ugly hack.
Aug 10 2018, 5:24 PM

Jul 19 2018

johalun0_gmail.com added a comment to D16300: Improve netmap TX handling when TX IRQs are not used/supported.

Results with I219LM (em0) TX and Macbook thunderbolt dongle (bge0) RX

Jul 19 2018, 8:06 PM
johalun0_gmail.com added a comment to D16300: Improve netmap TX handling when TX IRQs are not used/supported.

I tried the first version again and it seems OK on the TX side. Not sure about RX, seeing some poll error but that might be my messed up I218LM which can't do more than 70 Kpps TX (it does 14 Mpps with FreeBSD 11) but that's another problem.
Between I219LM and a Realtek NIC I get stable 150 Kpps and I guess that's the limit for emulated netmap.

Jul 19 2018, 5:31 PM
johalun0_gmail.com added a comment to D16300: Improve netmap TX handling when TX IRQs are not used/supported.

OK, switching TX/RX between I128LM and I219LM makes no difference, still 5 Kpps. iperf between the two machine measure +900 Mbps.

Are the counters in dev.em.X.mac_stats.xoff_txd and dev.em.X.mac_stats.xon_txd incrementing? If so, you can try turning off flow control... sysctl dev.em.X.fc=0

Jul 19 2018, 8:12 AM

Jul 18 2018

johalun0_gmail.com added a comment to D16300: Improve netmap TX handling when TX IRQs are not used/supported.

OK, switching TX/RX between I128LM and I219LM makes no difference, still 5 Kpps. iperf between the two machine measure +900 Mbps.

Jul 18 2018, 9:27 PM
johalun0_gmail.com added a comment to D16300: Improve netmap TX handling when TX IRQs are not used/supported.

Use the same callout reset logic in the admin task as the txq timer.

@johalun0_gmail.com I wonder if the admin task was overriding the txqs
with a longer timeout in your case.

Jul 18 2018, 8:58 PM
johalun0_gmail.com added a comment to D16300: Improve netmap TX handling when TX IRQs are not used/supported.

Test between two 1000baseT FD, connected with 1GB switch. I128LM is sending, I129LM is receiving.
Kernel from 2018-07-18 (how to find svn revision when building from github?)
Patched kernel only on sending side. Receiving side is same revision but unpatched.

Jul 18 2018, 9:48 AM

Jun 11 2018

johalun0_gmail.com abandoned D15452: Update LinuxKPI to 4.15 .

Committed.

Jun 11 2018, 7:23 PM

Jun 7 2018

johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .

Rebase diff

Jun 7 2018, 2:47 PM
johalun0_gmail.com added inline comments to D15452: Update LinuxKPI to 4.15 .
Jun 7 2018, 1:50 PM

Jun 6 2018

johalun0_gmail.com added inline comments to D15452: Update LinuxKPI to 4.15 .
Jun 6 2018, 5:49 PM
johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .

Add license and clean up some reorder diffs

Jun 6 2018, 5:49 PM
johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .

Rebase to r334720

Jun 6 2018, 5:15 PM
johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .

Rebase against today's head

Jun 6 2018, 1:06 PM

Jun 1 2018

johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .

Some stuff has been committed so rebase against head.

Jun 1 2018, 3:55 PM
johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .

Don't increment index in radix_tree_iter_delete

Jun 1 2018, 11:56 AM

May 31 2018

johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .

Update since some parts have been committed to head.
Also,

  • Remove fcheck() macro, patch driver source code instead to use fget() and fput().
  • Derive PAGE_MASK from PAGE_SIZE since PAGE_MASK is different on FreeBSD and Linux
May 31 2018, 2:56 PM

May 30 2018

johalun0_gmail.com updated the diff for D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Remove whitespace change.

May 30 2018, 10:31 AM
johalun0_gmail.com added inline comments to D11003: Load balance sockets with new SO_REUSEPORT_LB option.
May 30 2018, 10:31 AM
johalun0_gmail.com updated the diff for D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Updated diff against today's kernel.

May 30 2018, 9:58 AM

May 29 2018

johalun0_gmail.com added inline comments to D15452: Update LinuxKPI to 4.15 .
May 29 2018, 1:16 PM

May 28 2018

johalun0_gmail.com added inline comments to D15452: Update LinuxKPI to 4.15 .
May 28 2018, 3:05 PM
johalun0_gmail.com added inline comments to D15452: Update LinuxKPI to 4.15 .
May 28 2018, 12:48 PM
johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .

Revert change to MPASS test in scheduler code.

May 28 2018, 12:29 PM
johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .
May 28 2018, 12:21 PM

May 27 2018

johalun0_gmail.com updated the summary of D15452: Update LinuxKPI to 4.15 .
May 27 2018, 8:39 AM
johalun0_gmail.com updated the diff for D15452: Update LinuxKPI to 4.15 .

Added TASK_KILLABLE to TASK_NORMAL so that the assert don't cause panic in linux_add_to_sleepqueue().

May 27 2018, 8:38 AM
johalun0_gmail.com updated the summary of D15452: Update LinuxKPI to 4.15 .
May 27 2018, 8:35 AM

May 25 2018

johalun0_gmail.com added a comment to D15567: amdtemp and amdsmn update for new devices.
In D15567#328787, @cem wrote:

I don't have any doc for the new Zen APUs, sorry. My TR doesn't have any 15eb devices.

May 25 2018, 3:42 PM
johalun0_gmail.com updated the summary of D15567: amdtemp and amdsmn update for new devices.
May 25 2018, 9:21 AM
johalun0_gmail.com created D15567: amdtemp and amdsmn update for new devices.
May 25 2018, 9:21 AM

May 22 2018

johalun0_gmail.com added a comment to D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Have you addressed all of @rwatson's comments?

May 22 2018, 7:28 AM

May 16 2018

johalun0_gmail.com added a comment to D15455: Work around lack of TX queues in iflib for netmap.

And netmap is alive again on I218-LM :)

May 16 2018, 6:28 PM
johalun0_gmail.com updated the diff for D11003: Load balance sockets with new SO_REUSEPORT_LB option.
  • Omit the inheritance part for now so that we can get this committed. Need more time and eyes to figure out a safe way to solve the locking issues. (this is anyway not a critical function but more a nice-to-have thing)
  • Add leading zeros to the rest of the SO_* options to indicate that they are now 32 bit.
May 16 2018, 5:07 PM
johalun0_gmail.com created D15452: Update LinuxKPI to 4.15 .
May 16 2018, 3:16 PM

May 11 2018

johalun0_gmail.com accepted D15385: uhid driver for Super Nintendo gamepads.

Looks good. Approved!

May 11 2018, 8:24 AM
johalun0_gmail.com added a comment to D15385: uhid driver for Super Nintendo gamepads.

Did you check if this driver is already supported by webcamd?

May 11 2018, 7:20 AM

May 10 2018

johalun0_gmail.com updated the summary of D15385: uhid driver for Super Nintendo gamepads.
May 10 2018, 9:33 PM
johalun0_gmail.com created D15385: uhid driver for Super Nintendo gamepads.
May 10 2018, 9:30 PM

Apr 30 2018

johalun0_gmail.com added a comment to D11003: Load balance sockets with new SO_REUSEPORT_LB option.

@rwatson If you have time, I would appreciate if you could take a look at the updates.

Apr 30 2018, 9:15 AM

Apr 27 2018

johalun0_gmail.com added a comment to D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Added comment - unsure about locking in one place...

Apr 27 2018, 2:16 PM
johalun0_gmail.com updated the diff for D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Improving locking
Refactor
Fix style

Apr 27 2018, 2:13 PM
johalun0_gmail.com added inline comments to D11003: Load balance sockets with new SO_REUSEPORT_LB option.
Apr 27 2018, 2:10 PM

Apr 26 2018

johalun0_gmail.com updated the diff for D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Add entry in man page

Apr 26 2018, 2:01 PM
johalun0_gmail.com updated the diff for D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Full context for all files.

Apr 26 2018, 12:32 PM
johalun0_gmail.com added a comment to D11003: Load balance sockets with new SO_REUSEPORT_LB option.

@gnn @rwatson Are we good to go?

Apr 26 2018, 10:35 AM

Apr 24 2018

johalun0_gmail.com added a comment to D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Thanks for the feedback!

Apr 24 2018, 5:38 PM
johalun0_gmail.com updated the diff for D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Changes:

  • Fix style
  • Add lock assertions
  • Acquire INP_HASH_RLOCK in_pcblookup_lbgroup_last()
  • Acquire INP_WLOCK before calling soinherit()
Apr 24 2018, 5:26 PM

Apr 20 2018

johalun0_gmail.com updated the diff for D11003: Load balance sockets with new SO_REUSEPORT_LB option.

Update to apply cleanly to HEAD as of 20180420.

Apr 20 2018, 10:17 AM
johalun0_gmail.com updated the summary of D11003: Load balance sockets with new SO_REUSEPORT_LB option.
Apr 20 2018, 8:18 AM

Mar 29 2018

johalun0_gmail.com accepted D14027: Properly range check the keyboard repeat values in the KDSETREPEAT IOCTLs in the kernel.

Together with r331692 this issue is solved.

Mar 29 2018, 12:34 PM

Feb 20 2018

johalun0_gmail.com abandoned D14016: Update linuxkpi to Linux 4.11.

Committed.

Feb 20 2018, 4:46 PM
johalun0_gmail.com accepted D14016: Update linuxkpi to Linux 4.11.

Everything in HEAD now.

Feb 20 2018, 4:32 PM

Feb 17 2018

johalun0_gmail.com updated the summary of D14016: Update linuxkpi to Linux 4.11.
Feb 17 2018, 9:57 AM

Feb 1 2018

johalun0_gmail.com updated the diff for D14016: Update linuxkpi to Linux 4.11.

Minor style fixes

Feb 1 2018, 3:55 PM
johalun0_gmail.com updated the diff for D14016: Update linuxkpi to Linux 4.11.

Simplify tasklet_enable function.

Feb 1 2018, 3:44 PM
johalun0_gmail.com updated the diff for D14016: Update linuxkpi to Linux 4.11.

Fix comments and various style fixes.

Feb 1 2018, 3:28 PM
johalun0_gmail.com added inline comments to D14016: Update linuxkpi to Linux 4.11.
Feb 1 2018, 3:24 PM

Jan 31 2018

johalun0_gmail.com updated the summary of D14016: Update linuxkpi to Linux 4.11.
Jan 31 2018, 6:40 PM
johalun0_gmail.com added a comment to D14016: Update linuxkpi to Linux 4.11.

Fixed some comments. Will update the diff when the last one is fixed.
@hselasky please check my comments in list.h and wait.h.

Jan 31 2018, 6:39 PM

Jan 30 2018

johalun0_gmail.com added a comment to D14016: Update linuxkpi to Linux 4.11.

@hselasky
Thanks for the feedback! I will look at the issues. Please look at my replies to your comments.
The work was started before the split of linuxkpi so merging it back into the two different parts is somewhat messy...

Jan 30 2018, 4:52 PM
johalun0_gmail.com abandoned D7496: Add kevent support to drm.

Not relevant anymore.

Jan 30 2018, 10:13 AM

Jan 26 2018

johalun0_gmail.com added a comment to D14027: Properly range check the keyboard repeat values in the KDSETREPEAT IOCTLs in the kernel.

Seem to help against ukbd irqs but the problem is still there. I now discovered how I can get the same behavior in i3 and X.
I did this in xfce4-terminal, don't know if it has to be that or not. Hold down CTRL (with USB keyboard), press any other key and let go, but hold down CTRL the whole time. Now interrupt storms start on CPU 0 timer.

Jan 26 2018, 10:30 PM