Add a port for the Wayland compositor, Sway.
Is the x11@ team fine with that?
The indentation is off by 2 tabs here.
Do you plan on making them options?
Remove GH_TAGNAME and PORTVERSION and use DISTVERSION=0.15-rc3 instead.
Is there any way we can build it with Clang?
This needs to be at least a paragraph or more and not just a repeat of COMMENT.
Thanks for the feedback!
Sorry the previous patch was a bit old. I updated and fixed according to recommendations.
When digging deeper in the clang build error it turned out to be a really simple thing so it builds with clang now :)
I tried test building Sway today, but it failed in Poudriere on 11.1 on:
/wrkdirs/usr/ports/x11-wm/sway/work/sway-0.15/sway/commands/clipboard.c:33:2: error: implicit declaration of function 'wlc_set_selection' is invalid in C99 [-Werror,-Wimplicit-function-declaration] wlc_set_selection(str, types, 2, &send_clipboard);
Full build log: https://pastebin.com/raw/q6BacPs2
Removing -Werror lets the build proceed a little further but reveals more problems: https://pkg.tobik.me/logs/sway-0.15.log
Does this need the wlc update from https://bugs.freebsd.org/224202 ?
Normally the one who submits it becomes the maintainer :)
This fails to fetch for me:
=> Fetched file size mismatch (expected 5394885, actual 5397948)
Using @sample in the pkg-plist will cause the sample to get copied to the non-sample file name. See:
Making it an option was probably copied from a similar port. Not sure there's a use case where SUID is not used.. Maybe if you want to only run with X11 backend there's no need to involve root.
This tool, here, Phabricator, is a code review tool, not a patch queue for things to be committed, which is what Bugzilla is for.
If you are not a committer, or do not plan to commit it yourself, it is best to always open a PR on our bugzilla in parallel so that the change actually goes in our pipeline.
The Sway GitHub say page it is necessary on systems without logind:
On systems without logind, you need to suid the sway binary:
sudo chmod a+s /usr/local/bin/sway
Sway will drop root permissions shortly after startup.