Page MenuHomeFreeBSD

amdtemp and amdsmn update for new devices
AbandonedPublic

Authored by cem on May 25 2018, 9:21 AM.

Details

Summary

First version of this patch adds a device id for AMD Ryzen 3 2200G. When attaching the driver to the PCI root, the driver seem to show correct temperature value but the sysctls for dev.cpu.X.temp are not created.

However, according to https://patchwork.kernel.org/patch/10381565/ the correct way to do it is to connect to Data Fabric Function 3. If this is done, the dev.cpu.X.temp sysctls are created but all temperatures are 0.

This patch is a WIP to address this.

Bug report here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228480

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

I don't have any doc for the new Zen APUs, sorry. My TR doesn't have any 15eb devices.

In D15567#328787, @cem wrote:

I don't have any doc for the new Zen APUs, sorry. My TR doesn't have any 15eb devices.

No worries. I'll continue tinker with this. Do you have a 0x1463 device (in the same machine is 0x1450)?

No worries. I'll continue tinker with this. Do you have a 0x1463 device (in the same machine is 0x1450)?

Yep, and the same number:

$ pciconf -lv | grep -A3 1463
hostb10@pci0:0:24:3:    class=0x060000 card=0x00000000 chip=0x14631022 rev=0x00 hdr=0x00
    vendor     = 'Advanced Micro Devices, Inc. [AMD]'
    class      = bridge
    subclass   = HOST-PCI
--
hostb18@pci0:0:25:3:    class=0x060000 card=0x00000000 chip=0x14631022 rev=0x00 hdr=0x00
    vendor     = 'Advanced Micro Devices, Inc. [AMD]'
    class      = bridge
    subclass   = HOST-PCI
$ pciconf -lv | grep -A3 1450
hostb0@pci0:0:0:0:      class=0x060000 card=0x14501849 chip=0x14501022 rev=0x00 hdr=0x00
    vendor     = 'Advanced Micro Devices, Inc. [AMD]'
    class      = bridge
    subclass   = HOST-PCI
--
hostb23@pci0:64:0:0:    class=0x060000 card=0x14501022 chip=0x14501022 rev=0x00 hdr=0x00
    vendor     = 'Advanced Micro Devices, Inc. [AMD]'
    class      = bridge
    subclass   = HOST-PCI

(And yes, this machine has *30* PCI devices that hostb attaches to. Both Intel machines I have access to at the moment have only one.)

I think this one can be closed, a version of this was committed in r340425

cem abandoned this revision.
cem edited reviewers, added: johalun0_gmail.com; removed: cem.

committed in r340425