Page MenuHomeFreeBSD

Add kevent support to drm
AbandonedPublic

Authored by johalun0_gmail.com on Aug 13 2016, 10:00 PM.

Details

Reviewers
None
Summary

Wayland requires kevent for drm devices. This patch adds that to the 3.8 drm branch (current HEAD).

Question:
Should there be some testing to see if kevent is being used in the wake up function so we don't call mtx_lock() and knote() when we don't need to?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

johalun0_gmail.com retitled this revision from to Add kevent support to drm.
johalun0_gmail.com updated this object.
johalun0_gmail.com edited the test plan for this revision. (Show Details)
johalun0_gmail.com set the repository for this revision to rS FreeBSD src repository - subversion.
wulf_cicgroup.ru added inline comments.
sys/dev/drm2/drmP.h
422

struct drm_file has struct selinfo event_poll member already. Can it be used for kevents too?

423

Can dev->event_lock be reused to not introduce new mutex?
As I see, both notify and kqfilter functions run with this mtx taken

I agree on both suggestions. Will test and see if works as expected.