Page MenuHomeFreeBSD

Fix synchronization of lbgroup access.
ClosedPublic

Authored by markj on Sep 4 2018, 9:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 12 2024, 10:10 AM
Unknown Object (File)
Dec 20 2023, 6:46 AM
Unknown Object (File)
Nov 21 2023, 11:43 PM
Unknown Object (File)
Aug 20 2023, 8:23 PM
Unknown Object (File)
Jun 30 2023, 6:15 PM
Unknown Object (File)
Jun 24 2023, 3:24 AM
Unknown Object (File)
Jun 12 2023, 10:46 AM
Unknown Object (File)
Jun 1 2023, 7:09 AM
Subscribers

Details

Summary

lbgroup hash table lookups are protected by epoch sections, but the hash
chains are regular LISTs instead of CK_LISTs. We also were not
deferring frees of inpcblbgroups.

Test Plan

Regression test in D17110.

gallatin tested the patch on a box at Netflix.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 6 2018, 3:27 PM

Yeah, CK work was committed soon after so_reuseport_lb was merged so this was missed. Thanks for fixing!

FWIW, as I mentioned in private email, the testing went fine. I verified that there were no apparent mem leaks, and that in_pcblbgroup_free_deferred() was called when I bounced nginx several times on a heavily loaded (> 90Gb/s) box.

FWIW, as I mentioned in private email, the testing went fine. I verified that there were no apparent mem leaks, and that in_pcblbgroup_free_deferred() was called when I bounced nginx several times on a heavily loaded (> 90Gb/s) box.

Indeed, thanks. I also wrote some regression tests; see D17110. I submitted this diff to re@ already.

This revision was automatically updated to reflect the committed changes.