Page MenuHomeFreeBSD

We don't need shell protection for when we're expanding matches. Don't add it. This should fix when we do regepx matches against variables we've set and fix wifi bring up.
ClosedPublic

Authored by imp on Sep 21 2018, 5:28 AM.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

Weird, works for me, and regex in Testing device-name line looks correct now without any changes to devd.conf. Make sure you are running correct binary?

In D17267#368025, @yuripv_yuripv.net wrote:

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

Weird, works for me, and regex in Testing device-name line looks correct now without any changes to devd.conf. Make sure you are running correct binary?

Oh you're right. I accidentally scp'd the new file to /usr/sbin *_* Works fine now :)

Does this require any changes to devd.conf to work? Only applying this patch and copy over devd binary to my test machine doesn't change anything for me, the regexp still starts with ^$'(.....

No changes should be required. I'd double check you built right, or that I'm not applying things backwards.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2018, 3:33 PM
This revision was automatically updated to reflect the committed changes.