Page MenuHomeFreeBSD

fix PNP entries for if_ix and if_ixv
ClosedPublic

Authored by yuripv on Oct 8 2018, 4:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 4:33 PM
Unknown Object (File)
Jan 7 2024, 7:45 AM
Unknown Object (File)
Dec 20 2023, 7:14 AM
Unknown Object (File)
Dec 13 2023, 2:54 PM
Unknown Object (File)
Nov 16 2023, 3:05 PM
Unknown Object (File)
Nov 11 2023, 7:36 PM
Unknown Object (File)
Nov 6 2023, 5:50 AM
Unknown Object (File)
Oct 24 2023, 4:31 AM
Subscribers

Details

Summary

While looking at devmatch -d output, I noticed that entries for if_ix and if_ixv are bogus (lots of "0x8086:0:").

Fix this using the proper IFLIB_PNP_INFO macro.

Test Plan

devmatch -d

Module ix_pci in if_ix.ko
PNP info for bus pci format I:vendor;I:device;I:subvendor;I:subdevice;I:revision;I:class;D:#; 44 entries (if_ix.ko)
   0x8086:0x10c6:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10c7:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10dd:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10c8:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x150b:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10b6:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f1:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10ec:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f4:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10e1:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10db:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f7:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1514:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10fb:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10fc:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f9:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x151c:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x10f8:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x152a:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x154d:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1529:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1557:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x154a:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1558:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1528:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1560:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x1563:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15d1:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ab:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15aa:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ad:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ae:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ac:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c2:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c3:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15ce:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c4:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c6:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c7:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15c8:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15e4:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x15e5:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x155c:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
   0x8086:0x155d:0:0:0:0:'Intel(R) PRO/10GbE PCI-Express Network Driver':
Module ixv_pci in if_ixv.ko
PNP info for bus pci format I:vendor;I:device;I:subvendor;I:subdevice;I:revision;I:class;D:#; 5 entries (if_ixv.ko)
   0x8086:0x10ed:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':
   0x8086:0x1515:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':
   0x8086:0x1565:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':
   0x8086:0x15a8:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':
   0x8086:0x15c5:0:0:0:0:'Intel(R) PRO/10GbE Virtual Function Network Driver':

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I can't tell if this is right or not, but it looks like an ok change to me.

Sorry, I forgot to add the output from devmatch -d for fixed versions. Done now.

Seems reasonable to me. The old description looks to not be quite right and this fixes it.

This revision is now accepted and ready to land.Oct 8 2018, 5:28 PM

@yuripv Do you want me to commit this or are you going to be able to send the request to release engineering?

https://wiki.freebsd.org/Releng/ChangeRequestGuidelines

@yuripv Do you want me to commit this or are you going to be able to send the request to release engineering?

https://wiki.freebsd.org/Releng/ChangeRequestGuidelines

I can do this now, yes.

This revision was automatically updated to reflect the committed changes.