Page MenuHomeFreeBSD

PR228448: `unlink -foo` , the original use of `unlink`, no longer works.
ClosedPublic

Authored by yuripv on Sep 12 2018, 12:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 2, 11:33 PM
Unknown Object (File)
Wed, Sep 2, 3:20 AM
Unknown Object (File)
Sat, Aug 29, 8:33 AM
Unknown Object (File)
Tue, Aug 25, 1:55 PM
Unknown Object (File)
Tue, Aug 18, 8:05 PM
Unknown Object (File)
Tue, Aug 18, 4:10 PM
Unknown Object (File)
Tue, Aug 18, 10:17 AM
Unknown Object (File)
Sun, Aug 16, 9:29 PM
Subscribers

Details

Summary

Restore the original behavior of unlink(1), passing the provided filename
directly to unlink(2), handling the first argument being "--" correctly.

This fixes the unlink -foo, broken in r97533.

Reported by: Brennan Vincent <brennan@umanwizard.com>
Submitted by: Brennan Vincent <brennan@umanwizard.com>
PR: 228448

Test Plan

$ kyua test -k /usr/tests/Kyuafile bin/rm
bin/rm/rm_test:unlink_dash_filename -> passed [0.088s]

Results file id is usr_tests.20180912-125312-617400
Results saved to /home/yuri/.kyua/store/results.usr_tests.20180912-125312-617400.db

1/1 passed (0 failed)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 12 2018, 1:19 PM
0mp added a subscriber: 0mp.

The manpage update looks fine.

This revision was automatically updated to reflect the committed changes.