Page MenuHomeFreeBSD

intelspi: don't leak spibus children on detach
ClosedPublic

Authored by yuripv on Sep 8 2018, 5:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 25, 11:21 AM
Unknown Object (File)
Tue, Sep 23, 8:05 PM
Unknown Object (File)
Sep 10 2025, 12:37 PM
Unknown Object (File)
Sep 10 2025, 12:34 PM
Unknown Object (File)
Sep 10 2025, 12:24 PM
Unknown Object (File)
Sep 10 2025, 9:11 AM
Unknown Object (File)
Sep 10 2025, 8:00 AM
Unknown Object (File)
Aug 11 2025, 7:33 AM

Details

Test Plan
  1. kldload intelspi
  2. kldunload intelspi

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/dev/intel/spi.c
500 ↗(On Diff #47809)

There is device delete_children(9). It would be much more convenient to use there.

But I suspect that intelspi should be considered bus and then bus_generic_detach(9) used instead. See the call for bus generic_attach() above.

use bus_generic_detach().

yuripv added inline comments.
sys/dev/intel/spi.c
500 ↗(On Diff #47809)

Even better, works the same.

This revision is now accepted and ready to land.Sep 8 2018, 5:52 PM
This revision was automatically updated to reflect the committed changes.