Page MenuHomeFreeBSD

intelspi: don't leak spibus children on detach
ClosedPublic

Authored by yuripv on Sep 8 2018, 5:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 14, 2:32 PM
Unknown Object (File)
Thu, Oct 3, 4:55 AM
Unknown Object (File)
Sep 25 2024, 7:58 AM
Unknown Object (File)
Sep 24 2024, 10:06 AM
Unknown Object (File)
Sep 24 2024, 6:50 AM
Unknown Object (File)
Sep 24 2024, 3:45 AM
Unknown Object (File)
Sep 22 2024, 7:07 PM
Unknown Object (File)
Sep 10 2024, 3:14 PM

Details

Test Plan
  1. kldload intelspi
  2. kldunload intelspi

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib added inline comments.
sys/dev/intel/spi.c
500

There is device delete_children(9). It would be much more convenient to use there.

But I suspect that intelspi should be considered bus and then bus_generic_detach(9) used instead. See the call for bus generic_attach() above.

use bus_generic_detach().

yuripv added inline comments.
sys/dev/intel/spi.c
500

Even better, works the same.

This revision is now accepted and ready to land.Sep 8 2018, 5:52 PM
This revision was automatically updated to reflect the committed changes.