Page MenuHomeFreeBSD
Feed Advanced Search

Jan 5 2021

andrew requested review of D27969: Update hwpmc on armv7 to handle overflow better.
Jan 5 2021, 10:58 AM
andrew committed rGa7d8bd8c239e: Add missing structs to pmclog_entry (authored by andrew).
Add missing structs to pmclog_entry
Jan 5 2021, 10:09 AM
andrew committed rG9fd96b416c45: Add the missing pmcstat log entries (authored by andrew).
Add the missing pmcstat log entries
Jan 5 2021, 10:09 AM

Jan 4 2021

andrew committed rG12d053032b6b: Support overflow count in hwpmc on arm64 (authored by andrew).
Support overflow count in hwpmc on arm64
Jan 4 2021, 5:23 PM
andrew added inline comments to D27945: Improvements to HWPMC support on FreeBSD/arm64 to handle counter wraparound.
Jan 4 2021, 9:49 AM · arm64

Dec 31 2020

andrew committed rG80062279f770: Add pmu.h missed in 5e78bbb74a1f (authored by andrew).
Add pmu.h missed in 5e78bbb74a1f
Dec 31 2020, 10:19 AM

Dec 30 2020

andrew committed rG5e78bbb74a1f: Split out the FDT arm pmu attachment (authored by andrew).
Split out the FDT arm pmu attachment
Dec 30 2020, 4:20 PM

Dec 27 2020

andrew added inline comments to D27766: Various changes to DTrace FBT to avoid crashed on FreeBSD/arm64..
Dec 27 2020, 1:53 PM · arm64, DTrace
andrew added a comment to D27765: Use L2 blocks when in the identity map.

I removed SOCDEV_VA because it's too difficult to know where the kernel will be loaded so we don't know a good virtual address at compile time.

Dec 27 2020, 1:48 PM

Dec 26 2020

andrew added a comment to D27765: Use L2 blocks when in the identity map.

Does it apply after 6270ee0b6726?

Dec 26 2020, 7:18 PM
andrew committed rG6270ee0b6726: Use the base address for early arm64 page tables (authored by andrew).
Use the base address for early arm64 page tables
Dec 26 2020, 7:11 PM

Dec 24 2020

andrew added a comment to D27765: Use L2 blocks when in the identity map.

I've tested the normal boot and with SOCDEV_PA set (but not used). I haven't tested any of the LINUX_BOOT_ABI paths.

Dec 24 2020, 4:00 PM
andrew requested review of D27765: Use L2 blocks when in the identity map.
Dec 24 2020, 3:57 PM

Dec 15 2020

andrew added a comment to D27621: Extract the logic from pmap_kextract.

This is untested, I just moved the code to a new function as a proof of concept.

Dec 15 2020, 3:00 PM
andrew added a comment to D27528: Fix /dev/mem access lock up.

How about something like D27621?

Dec 15 2020, 2:59 PM
andrew requested review of D27621: Extract the logic from pmap_kextract.
Dec 15 2020, 2:57 PM
andrew accepted D27528: Fix /dev/mem access lock up.

You might want to change the commit message to say you're removing the DMAP check from pmap_kextract as it wass only correct when the DMAP region is contiguous which is no longer true.

Dec 15 2020, 9:17 AM

Dec 13 2020

andrew committed R9:ad5abfc5d91a: - Add myself to authors.ent (authored by andrew).
- Add myself to authors.ent
Dec 13 2020, 5:44 PM
andrew committed R9:0cb68c1be4ba: - Add myself to developers.sgml (authored by andrew).
- Add myself to developers.sgml
Dec 13 2020, 5:31 PM

Dec 10 2020

andrew added a comment to D27529: Allow access to all accessible physical memory through /dev/mem.

Yes, I think the fix for D27528 is to remove the DMAP check from pmap_kextract. You can then use it here in mem.c to see if the mapping is valid & fall through to uiomove_fromphys if not.

Dec 10 2020, 9:50 PM
andrew added a comment to D27529: Allow access to all accessible physical memory through /dev/mem.

We already have a PHYS_IN_DMAP check. It could be extended to also check the return value of pmap_kextract(PHYS_TO_DMAP(v)).

Dec 10 2020, 9:32 PM
andrew added a comment to D27528: Fix /dev/mem access lock up.

All mappings that point to the same physical address need to be the same memory type. Because of this we will demote memory in the DMAP if needed to make this possible, e.g. when marking a page as uncached the DMAP page pointing at the same memory will also be marked as uncached, including a demotion if it's currently part of a larger block.

Dec 10 2020, 9:12 PM
andrew added a comment to D27529: Allow access to all accessible physical memory through /dev/mem.

pmap_kextract, although we will need to remove the DMAP check as it was added before we had a sparse DMAP region.

Dec 10 2020, 8:07 PM
andrew added a comment to D27529: Allow access to all accessible physical memory through /dev/mem.

I would prefer we don't map memory marked as noalloc in the DMAP. If we need to read it in /dev/mem then mem.c should handle unmapped memory within the DMAP region.

Dec 10 2020, 2:27 PM
andrew added a comment to D27528: Fix /dev/mem access lock up.

What will happen if we try to access a DMAP page during the break-before-make sequence while it is being demoted?

Dec 10 2020, 11:38 AM

Dec 8 2020

andrew committed rS368445: Use a macro to find the offset of kern_ttbr0.
Use a macro to find the offset of kern_ttbr0
Dec 8 2020, 3:51 PM
andrew committed rS368444: Free the arm64 bootparams memory after initarm.
Free the arm64 bootparams memory after initarm
Dec 8 2020, 3:41 PM
andrew accepted D27511: cpuset_set{affinity,domain}: do not allow empty masks.
Dec 8 2020, 2:46 PM
andrew accepted D27362: Check that the frame pointer is within the current stack..
Dec 8 2020, 11:22 AM

Dec 7 2020

andrew closed D27497: Ensure the boot CPU is CPU 0 on arm64.
Dec 7 2020, 5:55 PM
andrew committed rS368416: Ensure the boot CPU is CPU 0 on arm64.
Ensure the boot CPU is CPU 0 on arm64
Dec 7 2020, 5:55 PM
andrew updated the summary of D27497: Ensure the boot CPU is CPU 0 on arm64.
Dec 7 2020, 1:29 PM
andrew updated the diff for D27497: Ensure the boot CPU is CPU 0 on arm64.
  • Use the correct ID in cpu_init_fdt
  • Copy a comment explaining why we don't increment the CPU ID to teh FDT code
  • Fix a typo in said comment
Dec 7 2020, 1:25 PM
andrew updated the diff for D27497: Ensure the boot CPU is CPU 0 on arm64.

Simplify by only iterating once with CPU 0 being reserved

Dec 7 2020, 1:21 PM
andrew requested review of D27497: Ensure the boot CPU is CPU 0 on arm64.
Dec 7 2020, 1:05 PM

Dec 2 2020

andrew accepted D27422: Add support of UART_DEV_DBGPORT to uart_bus_fdt.c.
Dec 2 2020, 4:52 PM

Dec 1 2020

andrew added inline comments to D27422: Add support of UART_DEV_DBGPORT to uart_bus_fdt.c.
Dec 1 2020, 4:42 PM

Nov 29 2020

andrew closed D27274: Only set the PCI bus end when we are reducing it.
Nov 29 2020, 4:22 PM
andrew committed rS368156: Only set the PCI bus end when we are reducing it.
Only set the PCI bus end when we are reducing it
Nov 29 2020, 4:22 PM

Nov 26 2020

andrew accepted D27306: Detect ACPI early by FADT, not SPCR.
Nov 26 2020, 3:36 PM
andrew added inline comments to D27362: Check that the frame pointer is within the current stack..
Nov 26 2020, 2:23 PM

Nov 25 2020

andrew added a comment to D27306: Detect ACPI early by FADT, not SPCR.

I think we can just check for the existence of the ACPI tables, i.e. by checking if AcpiOsGetRootPointer returns a non-zero value.

Nov 25 2020, 6:13 PM
andrew accepted D27361: Use uintptr_t instead of uint64_t for pointers in stack frames..
Nov 25 2020, 4:10 PM

Nov 19 2020

andrew added a comment to D27274: Only set the PCI bus end when we are reducing it.

Based on my reading of the ACPI tables I expect this will work on eMAG and the Huawei Taishan, however I don't have access to either to test.

Nov 19 2020, 11:12 AM
andrew requested review of D27274: Only set the PCI bus end when we are reducing it.
Nov 19 2020, 11:08 AM
andrew closed D27247: Fall back to use the GICR address from the distributor struct.
Nov 19 2020, 9:27 AM
andrew committed rS367841: Fall back to use the GICR address from the generic interrupt struct.
Fall back to use the GICR address from the generic interrupt struct
Nov 19 2020, 9:27 AM

Nov 18 2020

andrew added inline comments to D27247: Fall back to use the GICR address from the distributor struct.
Nov 18 2020, 3:32 PM

Nov 17 2020

andrew requested review of D27247: Fall back to use the GICR address from the distributor struct.
Nov 17 2020, 11:12 AM
andrew committed rS367755: Stop calling gic_v3_detach when we haven't called gic_v3_attach.
Stop calling gic_v3_detach when we haven't called gic_v3_attach
Nov 17 2020, 10:28 AM
andrew abandoned D27238: Allow the GICv3 ACPI attachment to work with GICv4.

Committed in rS367754

Nov 17 2020, 10:20 AM
andrew committed rS367754: Allow the GICv3 ACPI driver to attach to a GICv4.
Allow the GICv3 ACPI driver to attach to a GICv4
Nov 17 2020, 10:17 AM
andrew added a comment to D27238: Allow the GICv3 ACPI attachment to work with GICv4.

I'm going to commit this as it allows the device to start attaching. There is a second issue where the HW you have described the interrupt controller in a different way. I have a change in progress that should fix this second issue.

Nov 17 2020, 10:16 AM

Nov 16 2020

andrew requested review of D27238: Allow the GICv3 ACPI attachment to work with GICv4.
Nov 16 2020, 12:58 PM

Nov 6 2020

andrew accepted D27127: Add C startup code tests for PIE binaries..
Nov 6 2020, 7:00 PM
andrew accepted D27126: Fix dso_handle_check for PIE executables..
Nov 6 2020, 7:00 PM
andrew accepted D27125: Rename __JCR_LIST__ to __JCR_END__ in crtend.c..
Nov 6 2020, 7:00 PM

Nov 5 2020

andrew committed rS367365: Stop trying to bounce in memory allocated by bus dma.
Stop trying to bounce in memory allocated by bus dma
Nov 5 2020, 9:56 AM

Nov 4 2020

andrew committed rS367325: Add the pmap.h changes missed in r367320.
Add the pmap.h changes missed in r367320
Nov 4 2020, 11:48 AM
andrew closed D26066: Allow the creation of 3 level page tables.
Nov 4 2020, 10:21 AM
andrew committed rS367320: Allow the creation of 3 level page tables on arm64.
Allow the creation of 3 level page tables on arm64
Nov 4 2020, 10:21 AM

Oct 29 2020

andrew updated the diff for D26066: Allow the creation of 3 level page tables.

Load the free list in pmap_release

Oct 29 2020, 10:53 AM

Oct 28 2020

andrew added a comment to D26975: Enable IPIs on CPU 0 on arm and arm64.

The GIC-500 TRM has the following note against GICD_ISENABLER0: "Writes to bits corresponding to the SGIs are ignored."

Oct 28 2020, 6:15 PM
andrew added a comment to D26975: Enable IPIs on CPU 0 on arm and arm64.

We already enable the SGIs on the non-boot CPUs in arm_gic_init_secondary and PIC_ENABLE_INTR will only be called when mp_ncpus != 1 so will be in a multicore system.

Oct 28 2020, 12:46 PM

Oct 27 2020

andrew requested review of D26975: Enable IPIs on CPU 0 on arm and arm64.
Oct 27 2020, 3:58 PM
andrew requested review of D26971: Switch the arm64 pcpu to a global register variable.
Oct 27 2020, 2:54 PM

Oct 21 2020

andrew added a comment to D26887: Add bus_dma_iommu_set_buswide() stubs.

Would it make sense to move these to subr_bus_dma.c in the non-IOMMU case?

Oct 21 2020, 3:17 PM

Oct 20 2020

andrew added inline comments to D26878: IOMMU support for GICv3 ITS.
Oct 20 2020, 10:21 AM

Oct 19 2020

andrew committed rS366836: Remove unused labels from the arm64 casueword*.
Remove unused labels from the arm64 casueword*
Oct 19 2020, 3:52 PM
andrew committed rS366832: Split the common arm64 fu* and su* asm to a macro.
Split the common arm64 fu* and su* asm to a macro
Oct 19 2020, 12:46 PM
andrew committed rS366831: Move the arm64 userspace access checks to macros.
Move the arm64 userspace access checks to macros
Oct 19 2020, 12:06 PM

Oct 14 2020

andrew committed rS366706: Remove direct user access from the arm64 copyinstr.
Remove direct user access from the arm64 copyinstr
Oct 14 2020, 3:31 PM

Oct 13 2020

andrew committed rS366670: Use adrp in the arm64 efi loader.
Use adrp in the arm64 efi loader
Oct 13 2020, 4:51 PM
andrew committed rS366666: Bump __FreeBSD_version for the fix to arm64 write-only mappings.
Bump __FreeBSD_version for the fix to arm64 write-only mappings
Oct 13 2020, 10:31 AM
andrew committed rS366665: Fix write only mappings on arm64.
Fix write only mappings on arm64
Oct 13 2020, 10:26 AM

Oct 9 2020

andrew accepted D26707: arm64: export a few more HWCAPs.
Oct 9 2020, 9:39 AM

Oct 8 2020

andrew added a comment to D26705: Manage MSI iommu pages.

I'd like to use some of the iommu functions in device code, e.g. non-pci devices on arm64 can be behind an iommu. I'd prefer to not have to teach these devices about PCI just to configure the iommu.

Oct 8 2020, 8:33 AM

Oct 5 2020

andrew accepted D26629: Tweak arm64's cpu_fetch_syscall_args().
Oct 5 2020, 5:14 PM

Oct 2 2020

andrew edited reviewers for D26629: Tweak arm64's cpu_fetch_syscall_args(), added: arm64; removed: ARM.
Oct 2 2020, 8:00 AM

Oct 1 2020

andrew added inline comments to D26629: Tweak arm64's cpu_fetch_syscall_args().
Oct 1 2020, 6:53 PM

Sep 29 2020

andrew accepted D26584: Rename acpi_iommu_get_dma_tag().
Sep 29 2020, 10:30 AM

Sep 24 2020

andrew committed rS366111: Clean up the arm64 bus_dma_run_filter.
Clean up the arm64 bus_dma_run_filter
Sep 24 2020, 10:42 AM
andrew committed rS366110: Ensure arm64 DMA alignment is passed from parents to children.
Ensure arm64 DMA alignment is passed from parents to children
Sep 24 2020, 10:41 AM
andrew committed rS366106: Bounce in more cases in the arm64 busdma.
Bounce in more cases in the arm64 busdma
Sep 24 2020, 7:17 AM
andrew closed D26496: Bounce in more cases in the arm64 busdma.
Sep 24 2020, 7:17 AM
andrew committed rS366105: Ensure we always align and size arm64 busdma allocations to a cacheline.
Ensure we always align and size arm64 busdma allocations to a cacheline
Sep 24 2020, 7:13 AM
andrew closed D26495: Ensure we always align and size arm64 busdma allocations to a cacheline.
Sep 24 2020, 7:13 AM
andrew committed rS366103: Add a coherent flag on the arm64 dma map struct.
Add a coherent flag on the arm64 dma map struct
Sep 24 2020, 7:08 AM
andrew closed D26494: Add a coherent flag on the arm64 dma map struct.
Sep 24 2020, 7:08 AM
andrew committed rS366102: Add bounce helpers to the arm64 busdma.
Add bounce helpers to the arm64 busdma
Sep 24 2020, 7:03 AM
andrew closed D26493: Add bounce helpers to the arm64 busdma.
Sep 24 2020, 7:03 AM

Sep 23 2020

andrew updated the diff for D26496: Bounce in more cases in the arm64 busdma.

Remove debugging

Sep 23 2020, 9:48 AM
andrew updated the diff for D26495: Ensure we always align and size arm64 busdma allocations to a cacheline.

Remove debugging

Sep 23 2020, 9:47 AM
andrew added inline comments to D26495: Ensure we always align and size arm64 busdma allocations to a cacheline.
Sep 23 2020, 9:41 AM
andrew updated the diff for D26496: Bounce in more cases in the arm64 busdma.
  • Use might_bounce/must_bounce in bounce_bus_dma_id_mapped
  • Always create the bounce zone in bounce_bus_dmamap_create
Sep 23 2020, 9:37 AM
andrew updated the diff for D26495: Ensure we always align and size arm64 busdma allocations to a cacheline.

Store the allocated alignment separate from the requested alignment

Sep 23 2020, 9:36 AM
andrew updated the diff for D26494: Add a coherent flag on the arm64 dma map struct.

Remove DMAMAP_COULD_BOUNCE as it's unneeded

Sep 23 2020, 9:36 AM
andrew updated the diff for D26493: Add bounce helpers to the arm64 busdma.

Add more calls to might_bounce/must_bounce

Sep 23 2020, 9:36 AM

Sep 21 2020

andrew accepted D26510: Weaken assertions in pmap_l1_to_l2() and pmap_l2_to_l3()..
Sep 21 2020, 3:32 PM

Sep 20 2020

andrew requested review of D26496: Bounce in more cases in the arm64 busdma.
Sep 20 2020, 3:38 PM