Page MenuHomeFreeBSD

cpuset_set{affinity,domain}: do not allow empty masks
ClosedPublic

Authored by kevans on Dec 8 2020, 2:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 1, 10:00 AM
Unknown Object (File)
Wed, Sep 30, 9:56 PM
Unknown Object (File)
Tue, Sep 29, 1:39 PM
Unknown Object (File)
Tue, Sep 29, 11:02 AM
Unknown Object (File)
Tue, Sep 29, 3:24 AM
Unknown Object (File)
Mon, Sep 7, 7:50 PM
Unknown Object (File)
Sep 4 2026, 9:17 AM
Unknown Object (File)
Aug 29 2026, 5:33 AM
Subscribers

Details

Summary

cpuset_modify() would not currently catch this, because it only checks that the new mask is a subset of the root set and circumvents the EDEADLK check in cpuset_testupdate().

This change both directly validates the mask coming in since we can trivially detect an empty mask, and it updates cpuset_testupdate to catch stuff like this going forward by always ensuring we don't end up with an empty mask.

The check_mask argument has been renamed because the 'check' verbiage does not imply to me that it's actually doing a different operation. We're either augmenting the existing mask, or we are replacing it entirely.

Reported by: syzbot+4e3b1009de98d2fabcda@syzkaller.appspotmail.com

Test Plan

I could not reproduce this one from syzbot's repro, but it's clear that it is a problem

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable