Page MenuHomeFreeBSD
Differential D26584

Rename acpi_iommu_get_dma_tag()
ClosedPublic
Actions

Authored by br on Sep 29 2020, 10:18 AM.
Tags
None
Referenced Files
F132474644: D26584.id77624.diff
Fri, Oct 17, 5:51 AM
F132474642: D26584.id77633.diff
Fri, Oct 17, 5:51 AM
F132474641: D26584.id.diff
Fri, Oct 17, 5:51 AM
F132474632: D26584.id77631.diff
Fri, Oct 17, 5:51 AM
Unknown Object (File)
Thu, Oct 16, 8:29 PM
Unknown Object (File)
Thu, Sep 25, 7:09 AM
Unknown Object (File)
Thu, Sep 25, 5:44 AM
Unknown Object (File)
Thu, Sep 25, 1:09 AM
View All 85 Files
Subscribers
imp

Details

Reviewers
andrew
kib
Commits
rS366257: o Rename acpi_iommu_get_dma_tag() -> iommu_get_dma_tag().
Summary

Rename acpi_iommu_get_dma_tag() as it does not seem to be ACPI dependend
Also on arm64 we may use it for FDT systems as well

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br requested review of this revision.Sep 29 2020, 10:18 AM
br created this revision.
andrew accepted this revision.Sep 29 2020, 10:30 AM
This revision is now accepted and ready to land.Sep 29 2020, 10:30 AM
kib added inline comments.Sep 29 2020, 1:22 PM
sys/dev/acpica/acpi_pci.c
459 ↗(On Diff #77624)

Wouldn't it be better to include iommu.h, instead of repeating the declaration ?

sys/dev/pci/pci.c
5683 ↗(On Diff #77624)

There too.

br updated this revision to Diff 77631.Sep 29 2020, 2:48 PM

Don't repeat iommu_get_dma_tag() declaration, include iommu.h instead.

This revision now requires review to proceed.Sep 29 2020, 2:48 PM
kib accepted this revision.Sep 29 2020, 2:51 PM
This revision is now accepted and ready to land.Sep 29 2020, 2:51 PM
Closed by commit rS366257: o Rename acpi_iommu_get_dma_tag() -> iommu_get_dma_tag(). (authored by br). · Explain WhySep 29 2020, 3:11 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS366257: o Rename acpi_iommu_get_dma_tag() -> iommu_get_dma_tag()..
Herald added a subscriber: imp. · View Herald TranscriptSep 29 2020, 3:11 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
acpica/
7 lines
iommu/
2 lines
2 lines
2 lines
pci/
7 lines

Diff 77633

View Options

head/sys/dev/acpica/acpi_pci.c

Loading...
View Options

head/sys/dev/iommu/busdma_iommu.h

Loading...
View Options

head/sys/dev/iommu/busdma_iommu.c

Loading...
View Options

head/sys/dev/iommu/iommu.h

Loading...
View Options

head/sys/dev/pci/pci.c

Loading...